Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85476,
    "url": "http://patches.dpdk.org/api/patches/85476/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-7-git-send-email-xuemingl@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1608304614-13908-7-git-send-email-xuemingl@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1608304614-13908-7-git-send-email-xuemingl@nvidia.com",
    "date": "2020-12-18T15:16:51",
    "name": "[RFC,6/9] devargs: support new global device syntax",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "31649f98609ecc1f87e6bdab490122745505ac8a",
    "submitter": {
        "id": 1904,
        "url": "http://patches.dpdk.org/api/people/1904/?format=api",
        "name": "Xueming Li",
        "email": "xuemingl@nvidia.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-7-git-send-email-xuemingl@nvidia.com/mbox/",
    "series": [
        {
            "id": 14378,
            "url": "http://patches.dpdk.org/api/series/14378/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14378",
            "date": "2020-12-18T15:16:52",
            "name": "support global syntax",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/14378/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/85476/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/85476/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C9DE1A09FD;\n\tFri, 18 Dec 2020 16:19:17 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 93BDCCBA8;\n\tFri, 18 Dec 2020 16:17:21 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 6213DCB1A\n for <dev@dpdk.org>; Fri, 18 Dec 2020 16:17:10 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Dec 2020 17:17:05 +0200",
            "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BIFH4qe010856;\n Fri, 18 Dec 2020 17:17:04 +0200"
        ],
        "From": "Xueming Li <xuemingl@nvidia.com>",
        "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>, Matan Azrad <matan@nvidia.com>",
        "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>",
        "Date": "Fri, 18 Dec 2020 15:16:51 +0000",
        "Message-Id": "<1608304614-13908-7-git-send-email-xuemingl@nvidia.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>",
        "References": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>",
        "Subject": "[dpdk-dev] [RFC 6/9] devargs: support new global device syntax",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When parsing a device syntax, try to parse new global syntax firstly,\nthen try to parse as legacy syntax if failed.\n\nExample of new global syntax:\n -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n lib/librte_eal/common/eal_common_devargs.c | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex e1a3cd7367..a79eea12d3 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -57,6 +57,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \tstruct rte_class *cls = NULL;\n \tstruct rte_bus *bus = NULL;\n \tconst char *s = devstr;\n+\tconst char *id;\n \tsize_t nblayer;\n \tsize_t i = 0;\n \tint ret = 0;\n@@ -116,6 +117,8 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tif (layers[i].kvlist == NULL)\n \t\t\tcontinue;\n \t\tkv = &layers[i].kvlist->pairs[0];\n+\t\tif (!kv->key)\n+\t\t\tcontinue;\n \t\tif (strcmp(kv->key, \"bus\") == 0) {\n \t\t\tbus = rte_bus_find_by_name(kv->value);\n \t\t\tif (bus == NULL) {\n@@ -124,6 +127,14 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\t\t\tret = -EFAULT;\n \t\t\t\tgoto get_out;\n \t\t\t}\n+\t\t\tid = rte_kvargs_get(layers[i].kvlist, \"id\");\n+\t\t\tif (!id) {\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Could not find bus id \\\"%s\\\"\\n\",\n+\t\t\t\t\tdevstr);\n+\t\t\t\tret = -EFAULT;\n+\t\t\t\tgoto get_out;\n+\t\t\t}\n+\t\t\tstrncpy(devargs->name, id, sizeof(devargs->name) - 1);\n \t\t} else if (strcmp(kv->key, \"class\") == 0) {\n \t\t\tcls = rte_class_find_by_name(kv->value);\n \t\t\tif (cls == NULL) {\n@@ -190,6 +201,12 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n \tif (da == NULL)\n \t\treturn -EINVAL;\n \n+\t/* First parse according new global syntax */\n+\tif (rte_devargs_layers_parse(da, dev) == 0 && da->bus && da->cls)\n+\t\treturn 0;\n+\n+\t/* Legacy syntax check: */\n+\n \t/* Retrieve eventual bus info */\n \tdo {\n \t\tdevname = dev;\n",
    "prefixes": [
        "RFC",
        "6/9"
    ]
}