Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85473,
    "url": "http://patches.dpdk.org/api/patches/85473/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-3-git-send-email-xuemingl@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1608304614-13908-3-git-send-email-xuemingl@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1608304614-13908-3-git-send-email-xuemingl@nvidia.com",
    "date": "2020-12-18T15:16:47",
    "name": "[RFC,2/9] devargs: fix memory leak on parsing error",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "595b12907372152c426cd38803c894efad0ea384",
    "submitter": {
        "id": 1904,
        "url": "http://patches.dpdk.org/api/people/1904/?format=api",
        "name": "Xueming Li",
        "email": "xuemingl@nvidia.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1608304614-13908-3-git-send-email-xuemingl@nvidia.com/mbox/",
    "series": [
        {
            "id": 14378,
            "url": "http://patches.dpdk.org/api/series/14378/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14378",
            "date": "2020-12-18T15:16:52",
            "name": "support global syntax",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/14378/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/85473/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/85473/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2683A09FD;\n\tFri, 18 Dec 2020 16:18:09 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 57B36CB34;\n\tFri, 18 Dec 2020 16:17:17 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 33A92CADB\n for <dev@dpdk.org>; Fri, 18 Dec 2020 16:17:10 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n xuemingl@nvidia.com) with SMTP; 18 Dec 2020 17:17:04 +0200",
            "from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BIFH4qa010856;\n Fri, 18 Dec 2020 17:17:04 +0200"
        ],
        "From": "Xueming Li <xuemingl@nvidia.com>",
        "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Olivier Matz <olivier.matz@6wind.com>, Matan Azrad <matan@nvidia.com>",
        "Cc": "dev@dpdk.org, xuemingl@nvidia.com, Asaf Penso <asafp@nvidia.com>,\n gaetan.rivet@6wind.com, stable@dpdk.org",
        "Date": "Fri, 18 Dec 2020 15:16:47 +0000",
        "Message-Id": "<1608304614-13908-3-git-send-email-xuemingl@nvidia.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>",
        "References": "<1608304614-13908-1-git-send-email-xuemingl@nvidia.com>",
        "Subject": "[dpdk-dev] [RFC 2/9] devargs: fix memory leak on parsing error",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes memory leak in parsing error handling.\n\nFixes: 338327d731e6 (\"devargs: add function to parse device layers\")\nCc: gaetan.rivet@6wind.com\nCc: stable@dpdk.org\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\n---\n lib/librte_eal/common/eal_common_devargs.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex fcf3d9a3cc..f36f71fbce 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -163,6 +163,11 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t\tif (layers[i].kvlist)\n \t\t\trte_kvargs_free(layers[i].kvlist);\n \t}\n+\tif (ret && devargs->data && devargs->data != devstr) {\n+\t\t/* Free duplicated data. */\n+\t\tfree(devargs->data);\n+\t\tdevargs->data = NULL;\n+\t}\n \tif (ret != 0)\n \t\trte_errno = -ret;\n \treturn ret;\n",
    "prefixes": [
        "RFC",
        "2/9"
    ]
}