Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 85417,
    "url": "http://patches.dpdk.org/api/patches/85417/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-9-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201218093702.3651867-9-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201218093702.3651867-9-jiawenwu@trustnetic.com",
    "date": "2020-12-18T09:36:37",
    "name": "[v3,08/33] net/txgbe: parse syn filter",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "92f56e3869d3b1620d14f99f16f5c731c32e051c",
    "submitter": {
        "id": 1932,
        "url": "http://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201218093702.3651867-9-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 14363,
            "url": "http://patches.dpdk.org/api/series/14363/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14363",
            "date": "2020-12-18T09:36:30",
            "name": "net: add txgbe PMD part 2",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/14363/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/85417/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/85417/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5081A09F6;\n\tFri, 18 Dec 2020 10:37:45 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 75794CAD0;\n\tFri, 18 Dec 2020 10:34:54 +0100 (CET)",
            "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by dpdk.org (Postfix) with ESMTP id C62DECA9D\n for <dev@dpdk.org>; Fri, 18 Dec 2020 10:34:47 +0100 (CET)",
            "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Fri, 18 Dec 2020 17:34:41 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp28t1608284081thui1rf3",
        "X-QQ-SSF": "01400000002000C0D000B00A0000000",
        "X-QQ-FEAT": "ZmZU6NjzbDJEqy5A48ivR2Rb8yE4i8h7sBdOBJpeueACt6TOmNOAd4gMSEw1z\n U0nJ7st+4dT/Q4Dwgb4w4BbHqIabDeo2pVZhy0QlV/ELcL+UHFbyA6c5w/PHOWysj1ZCK2Z\n 2d6IgxOQY2SLynUECgYTCApR4kRsClVXhpd8owicuPBAzYfcuidx+hLRN/gnjQrOYFGjTgG\n Jwlc5qGFK1Lu7N0acVVZmJ9KsUDRlUZCatf9CUzza5q2uTblHH12ZRrDsrdLA1QKzTeOAed\n RAbHOGMQjpvXFPITpaVeSIXsOhDVo8xNEzCQI7jmRvjT8k4lbl0+QZUW0RcpBAOhZaWQ+cD\n KC2poLlXRVoN5GNqoVb9k/axjW5xg==",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Fri, 18 Dec 2020 17:36:37 +0800",
        "Message-Id": "<20201218093702.3651867-9-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "In-Reply-To": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "References": "<20201218093702.3651867-1-jiawenwu@trustnetic.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v3 08/33] net/txgbe: parse syn filter",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Check if the rule is a TCP SYN rule, and get the SYN info.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_flow.c | 263 +++++++++++++++++++++++++++++++++\n 1 file changed, 263 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 96ff0546f..174c9da6e 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -765,6 +765,262 @@ txgbe_parse_ethertype_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+/**\n+ * Parse the rule to see if it is a TCP SYN rule.\n+ * And get the TCP SYN filter info BTW.\n+ * pattern:\n+ * The first not void item must be ETH.\n+ * The second not void item must be IPV4 or IPV6.\n+ * The third not void item must be TCP.\n+ * The next not void item must be END.\n+ * action:\n+ * The first not void action should be QUEUE.\n+ * The next not void action should be END.\n+ * pattern example:\n+ * ITEM\t\tSpec\t\t\tMask\n+ * ETH\t\tNULL\t\t\tNULL\n+ * IPV4/IPV6\tNULL\t\t\tNULL\n+ * TCP\t\ttcp_flags\t0x02\t0xFF\n+ * END\n+ * other members in mask and spec should set to 0x00.\n+ * item->last should be NULL.\n+ */\n+static int\n+cons_parse_syn_filter(const struct rte_flow_attr *attr,\n+\t\t\t\tconst struct rte_flow_item pattern[],\n+\t\t\t\tconst struct rte_flow_action actions[],\n+\t\t\t\tstruct rte_eth_syn_filter *filter,\n+\t\t\t\tstruct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item *item;\n+\tconst struct rte_flow_action *act;\n+\tconst struct rte_flow_item_tcp *tcp_spec;\n+\tconst struct rte_flow_item_tcp *tcp_mask;\n+\tconst struct rte_flow_action_queue *act_q;\n+\n+\tif (!pattern) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM_NUM,\n+\t\t\t\tNULL, \"NULL pattern.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!actions) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION_NUM,\n+\t\t\t\tNULL, \"NULL action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!attr) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR,\n+\t\t\t\t   NULL, \"NULL attribute.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\n+\t/* the first not void item should be MAC or IPv4 or IPv6 or TCP */\n+\titem = next_no_void_pattern(pattern, NULL);\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_ETH &&\n+\t    item->type != RTE_FLOW_ITEM_TYPE_IPV4 &&\n+\t    item->type != RTE_FLOW_ITEM_TYPE_IPV6 &&\n+\t    item->type != RTE_FLOW_ITEM_TYPE_TCP) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by syn filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\t\t/*Not supported last point for range*/\n+\tif (item->last) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\titem, \"Not supported last point for range\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Skip Ethernet */\n+\tif (item->type == RTE_FLOW_ITEM_TYPE_ETH) {\n+\t\t/* if the item is MAC, the content should be NULL */\n+\t\tif (item->spec || item->mask) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Invalid SYN address mask\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\n+\t\t/* check if the next not void item is IPv4 or IPv6 */\n+\t\titem = next_no_void_pattern(pattern, item);\n+\t\tif (item->type != RTE_FLOW_ITEM_TYPE_IPV4 &&\n+\t\t    item->type != RTE_FLOW_ITEM_TYPE_IPV6) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by syn filter\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\n+\t/* Skip IP */\n+\tif (item->type == RTE_FLOW_ITEM_TYPE_IPV4 ||\n+\t    item->type == RTE_FLOW_ITEM_TYPE_IPV6) {\n+\t\t/* if the item is IP, the content should be NULL */\n+\t\tif (item->spec || item->mask) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Invalid SYN mask\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\n+\t\t/* check if the next not void item is TCP */\n+\t\titem = next_no_void_pattern(pattern, item);\n+\t\tif (item->type != RTE_FLOW_ITEM_TYPE_TCP) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by syn filter\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\n+\t/* Get the TCP info. Only support SYN. */\n+\tif (!item->spec || !item->mask) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Invalid SYN mask\");\n+\t\treturn -rte_errno;\n+\t}\n+\t/*Not supported last point for range*/\n+\tif (item->last) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\titem, \"Not supported last point for range\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\ttcp_spec = item->spec;\n+\ttcp_mask = item->mask;\n+\tif (!(tcp_spec->hdr.tcp_flags & RTE_TCP_SYN_FLAG) ||\n+\t    tcp_mask->hdr.src_port ||\n+\t    tcp_mask->hdr.dst_port ||\n+\t    tcp_mask->hdr.sent_seq ||\n+\t    tcp_mask->hdr.recv_ack ||\n+\t    tcp_mask->hdr.data_off ||\n+\t    tcp_mask->hdr.tcp_flags != RTE_TCP_SYN_FLAG ||\n+\t    tcp_mask->hdr.rx_win ||\n+\t    tcp_mask->hdr.cksum ||\n+\t    tcp_mask->hdr.tcp_urp) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by syn filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* check if the next not void item is END */\n+\titem = next_no_void_pattern(pattern, item);\n+\tif (item->type != RTE_FLOW_ITEM_TYPE_END) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\titem, \"Not supported by syn filter\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* check if the first not void action is QUEUE. */\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_QUEUE) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tact_q = (const struct rte_flow_action_queue *)act->conf;\n+\tfilter->queue = act_q->index;\n+\tif (filter->queue >= TXGBE_MAX_RX_QUEUE_NUM) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* check if the next not void item is END */\n+\tact = next_no_void_action(actions, act);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* parse attr */\n+\t/* must be input direction */\n+\tif (!attr->ingress) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\tattr, \"Only support ingress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->egress) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\tattr, \"Not support egress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->transfer) {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\tattr, \"No support for transfer.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Support 2 priorities, the lowest or highest. */\n+\tif (!attr->priority) {\n+\t\tfilter->hig_pri = 0;\n+\t} else if (attr->priority == (uint32_t)~0U) {\n+\t\tfilter->hig_pri = 1;\n+\t} else {\n+\t\tmemset(filter, 0, sizeof(struct rte_eth_syn_filter));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\tattr, \"Not support priority.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_parse_syn_filter(struct rte_eth_dev *dev,\n+\t\t\t     const struct rte_flow_attr *attr,\n+\t\t\t     const struct rte_flow_item pattern[],\n+\t\t\t     const struct rte_flow_action actions[],\n+\t\t\t     struct rte_eth_syn_filter *filter,\n+\t\t\t     struct rte_flow_error *error)\n+{\n+\tint ret;\n+\n+\tret = cons_parse_syn_filter(attr, pattern,\n+\t\t\t\t\tactions, filter, error);\n+\n+\tif (filter->queue >= dev->data->nb_rx_queues)\n+\t\treturn -rte_errno;\n+\n+\tif (ret)\n+\t\treturn ret;\n+\n+\treturn 0;\n+}\n+\n /**\n  * Create or destroy a flow rule.\n  * Theorically one rule can match more than one filters.\n@@ -796,6 +1052,7 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n {\n \tstruct rte_eth_ntuple_filter ntuple_filter;\n \tstruct rte_eth_ethertype_filter ethertype_filter;\n+\tstruct rte_eth_syn_filter syn_filter;\n \tint ret = 0;\n \n \tmemset(&ntuple_filter, 0, sizeof(struct rte_eth_ntuple_filter));\n@@ -810,6 +1067,12 @@ txgbe_flow_validate(struct rte_eth_dev *dev,\n \tif (!ret)\n \t\treturn 0;\n \n+\tmemset(&syn_filter, 0, sizeof(struct rte_eth_syn_filter));\n+\tret = txgbe_parse_syn_filter(dev, attr, pattern,\n+\t\t\t\tactions, &syn_filter, error);\n+\tif (!ret)\n+\t\treturn 0;\n+\n \treturn ret;\n }\n \n",
    "prefixes": [
        "v3",
        "08/33"
    ]
}