Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85321/?format=api
{ "id": 85321, "url": "http://patches.dpdk.org/api/patches/85321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1608205475-20067-16-git-send-email-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1608205475-20067-16-git-send-email-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1608205475-20067-16-git-send-email-michaelba@nvidia.com", "date": "2020-12-17T11:44:33", "name": "[15/17] common/mlx5: share DevX RQ creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c98dd96ca33cda7546e44ad2b9414e3d86e5cf4e", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1608205475-20067-16-git-send-email-michaelba@nvidia.com/mbox/", "series": [ { "id": 14348, "url": "http://patches.dpdk.org/api/series/14348/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14348", "date": "2020-12-17T11:44:23", "name": "common/mlx5: share DevX resources creations", "version": 1, "mbox": "http://patches.dpdk.org/series/14348/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85321/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 896ABA09F6;\n\tThu, 17 Dec 2020 12:49:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EDD05CABB;\n\tThu, 17 Dec 2020 12:45:17 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id E56C4CA12\n for <dev@dpdk.org>; Thu, 17 Dec 2020 12:44:56 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n michaelba@nvidia.com) with SMTP; 17 Dec 2020 13:44:51 +0200", "from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BHBio2e004524;\n Thu, 17 Dec 2020 13:44:51 +0200" ], "From": "Michael Baum <michaelba@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Thu, 17 Dec 2020 11:44:33 +0000", "Message-Id": "<1608205475-20067-16-git-send-email-michaelba@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1608205475-20067-1-git-send-email-michaelba@nvidia.com>", "References": "<1608205475-20067-1-git-send-email-michaelba@nvidia.com>", "Subject": "[dpdk-dev] [PATCH 15/17] common/mlx5: share DevX RQ creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The RQ object in DevX is used currently only in net driver, but it share\nfor future.\n\nAdd a structure that contains all the resources, and provide creation\nand release functions for it.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/common/mlx5/mlx5_common_devx.c | 116 +++++++++++++++++++++++++++++++++\n drivers/common/mlx5/mlx5_common_devx.h | 11 ++++\n 2 files changed, 127 insertions(+)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common_devx.c b/drivers/common/mlx5/mlx5_common_devx.c\nindex 46404d8..0ac67bd 100644\n--- a/drivers/common/mlx5/mlx5_common_devx.c\n+++ b/drivers/common/mlx5/mlx5_common_devx.c\n@@ -276,4 +276,120 @@\n \treturn -rte_errno;\n }\n \n+/**\n+ * Destroy DevX Receive Queue.\n+ *\n+ * @param[in] rq\n+ * DevX RQ to destroy.\n+ */\n+void\n+mlx5_devx_rq_destroy(struct mlx5_devx_rq *rq)\n+{\n+\tif (rq->rq)\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(rq->rq));\n+\tif (rq->umem_obj)\n+\t\tclaim_zero(mlx5_glue->devx_umem_dereg(rq->umem_obj));\n+\tif (rq->umem_buf)\n+\t\tmlx5_free((void *)(uintptr_t)rq->umem_buf);\n+}\n+\n+/**\n+ * Create Receive Queue using DevX API.\n+ *\n+ * Get a pointer to partially initialized attributes structure, and updates the\n+ * following fields:\n+ * wq_umem_valid\n+ * wq_umem_id\n+ * wq_umem_offset\n+ * dbr_umem_valid\n+ * dbr_umem_id\n+ * dbr_addr\n+ * log_wq_pg_sz\n+ * All other fields are updated by caller.\n+ *\n+ * @param[in] ctx\n+ * Context returned from mlx5 open_device() glue function.\n+ * @param[in/out] rq_obj\n+ * Pointer to RQ to create.\n+ * @param[in] wqe_size\n+ * Size of WQE structure.\n+ * @param[in] log_wqbb_n\n+ * Log of number of WQBBs in queue.\n+ * @param[in] attr\n+ * Pointer to RQ attributes structure.\n+ * @param[in] socket\n+ * Socket to use for allocation.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_devx_rq_create(void *ctx, struct mlx5_devx_rq *rq_obj, uint32_t wqe_size,\n+\t\t uint16_t log_wqbb_n,\n+\t\t struct mlx5_devx_create_rq_attr *attr, int socket)\n+{\n+\tstruct mlx5_devx_obj *rq = NULL;\n+\tstruct mlx5dv_devx_umem *umem_obj = NULL;\n+\tvoid *umem_buf = NULL;\n+\tsize_t page_size = rte_mem_page_size();\n+\tsize_t alignment = MLX5_WQE_BUF_ALIGNMENT;\n+\tuint32_t umem_size, umem_dbrec;\n+\tuint16_t rq_size = 1 << log_wqbb_n;\n+\tint ret;\n+\n+\tif (page_size == (size_t)-1 || alignment == (size_t)-1) {\n+\t\tDRV_LOG(ERR, \"Failed to get page_size.\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn -rte_errno;\n+\t}\n+\t/* Allocate memory buffer for WQEs and doorbell record. */\n+\tumem_size = wqe_size * rq_size;\n+\tumem_dbrec = RTE_ALIGN(umem_size, MLX5_DBR_SIZE);\n+\tumem_size += MLX5_DBR_SIZE;\n+\tumem_buf = mlx5_malloc(MLX5_MEM_RTE | MLX5_MEM_ZERO, umem_size,\n+\t\t\t alignment, socket);\n+\tif (!umem_buf) {\n+\t\tDRV_LOG(ERR, \"Failed to allocate memory for RQ.\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn -rte_errno;\n+\t}\n+\t/* Register allocated buffer in user space with DevX. */\n+\tumem_obj = mlx5_glue->devx_umem_reg(ctx, (void *)(uintptr_t)umem_buf,\n+\t\t\t\t\t umem_size, 0);\n+\tif (!umem_obj) {\n+\t\tDRV_LOG(ERR, \"Failed to register umem for RQ.\");\n+\t\trte_errno = errno;\n+\t\tgoto error;\n+\t}\n+\t/* Fill attributes for RQ object creation. */\n+\tattr->wq_attr.wq_umem_valid = 1;\n+\tattr->wq_attr.wq_umem_id = mlx5_os_get_umem_id(rq_obj->umem_obj);\n+\tattr->wq_attr.wq_umem_offset = 0;\n+\tattr->wq_attr.dbr_umem_valid = 1;\n+\tattr->wq_attr.dbr_umem_id = attr->wq_attr.wq_umem_id;\n+\tattr->wq_attr.dbr_addr = umem_dbrec;\n+\tattr->wq_attr.log_wq_pg_sz = rte_log2_u32(page_size);\n+\t/* Create receive queue object with DevX. */\n+\trq = mlx5_devx_cmd_create_rq(ctx, attr, socket);\n+\tif (!rq) {\n+\t\tDRV_LOG(ERR, \"Can't create DevX RQ object.\");\n+\t\trte_errno = ENOMEM;\n+\t\tgoto error;\n+\t}\n+\trq_obj->umem_buf = umem_buf;\n+\trq_obj->umem_obj = umem_obj;\n+\trq_obj->rq = rq;\n+\trq_obj->db_rec = RTE_PTR_ADD(rq_obj->umem_buf, umem_dbrec);\n+\treturn 0;\n+error:\n+\tret = rte_errno;\n+\tif (rq)\n+\t\tclaim_zero(mlx5_devx_cmd_destroy(rq));\n+\tif (umem_obj)\n+\t\tclaim_zero(mlx5_glue->devx_umem_dereg(umem_obj));\n+\tif (umem_buf)\n+\t\tmlx5_free((void *)(uintptr_t)umem_buf);\n+\trte_errno = ret;\n+\treturn -rte_errno;\n+}\n \ndiff --git a/drivers/common/mlx5/mlx5_common_devx.h b/drivers/common/mlx5/mlx5_common_devx.h\nindex 8377d34..1dafbf5 100644\n--- a/drivers/common/mlx5/mlx5_common_devx.h\n+++ b/drivers/common/mlx5/mlx5_common_devx.h\n@@ -30,6 +30,13 @@ struct mlx5_devx_sq {\n \tvolatile uint32_t *db_rec; /* The SQ doorbell record. */\n };\n \n+/* DevX Receive Queue structure. */\n+struct mlx5_devx_rq {\n+\tstruct mlx5_devx_obj *rq; /* The RQ DevX object. */\n+\tstruct mlx5dv_devx_umem *umem_obj; /* The RQ umem object. */\n+\tvolatile void *umem_buf;\n+\tvolatile uint32_t *db_rec; /* The RQ doorbell record. */\n+};\n \n /* mlx5_common_devx.c */\n \n@@ -41,5 +48,9 @@ int mlx5_devx_cq_create(void *ctx, struct mlx5_devx_cq *cq_obj,\n int mlx5_devx_sq_create(void *ctx, struct mlx5_devx_sq *sq_obj,\n \t\t\tuint16_t log_wqbb_n,\n \t\t\tstruct mlx5_devx_create_sq_attr *attr, int socket);\n+void mlx5_devx_rq_destroy(struct mlx5_devx_rq *rq);\n+int mlx5_devx_rq_create(void *ctx, struct mlx5_devx_rq *rq_obj,\n+\t\t\tuint32_t wqe_size, uint16_t log_wqbb_n,\n+\t\t\tstruct mlx5_devx_create_rq_attr *attr, int socket);\n \n #endif /* RTE_PMD_MLX5_COMMON_DEVX_H_ */\n", "prefixes": [ "15/17" ] }