Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8523/?format=api
http://patches.dpdk.org/api/patches/8523/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1446459547-1754-10-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446459547-1754-10-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446459547-1754-10-git-send-email-harry.van.haaren@intel.com", "date": "2015-11-02T10:19:06", "name": "[dpdk-dev,v5,09/10] i40evf: add xstats() implementation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "026e445a565dbeb2450aaefa39cadaaf9a7e68f5", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1446459547-1754-10-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/8523/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/8523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CE4CE91A1;\n\tMon, 2 Nov 2015 11:19:30 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id D24098F9C\n\tfor <dev@dpdk.org>; Mon, 2 Nov 2015 11:19:27 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 02 Nov 2015 02:19:28 -0800", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby orsmga002.jf.intel.com with ESMTP; 02 Nov 2015 02:19:26 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,234,1444719600\"; d=\"scan'208\";a=\"840505453\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 2 Nov 2015 10:19:06 +0000", "Message-Id": "<1446459547-1754-10-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1446459547-1754-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1446204998-17151-2-git-send-email-harry.van.haaren@intel.com>\n\t<1446459547-1754-1-git-send-email-harry.van.haaren@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 09/10] i40evf: add xstats() implementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add implementation of xstats() functions in i40evf PMD.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/i40e/i40e_ethdev_vf.c | 89 +++++++++++++++++++++++++++++++++++++--\n 1 file changed, 86 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex b694400..24153fb 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -112,6 +112,9 @@ static int i40evf_dev_link_update(struct rte_eth_dev *dev,\n \t\t\t\t __rte_unused int wait_to_complete);\n static void i40evf_dev_stats_get(struct rte_eth_dev *dev,\n \t\t\t\tstruct rte_eth_stats *stats);\n+static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstats *xstats, unsigned n);\n+static void i40evf_dev_xstats_reset(struct rte_eth_dev *dev);\n static int i40evf_vlan_filter_set(struct rte_eth_dev *dev,\n \t\t\t\t uint16_t vlan_id, int on);\n static void i40evf_vlan_offload_set(struct rte_eth_dev *dev, int mask);\n@@ -148,6 +151,30 @@ static int i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n /* Default hash key buffer for RSS */\n static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1];\n \n+struct rte_i40evf_xstats_name_off {\n+\tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n+\tunsigned offset;\n+};\n+\n+static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = {\n+\t{\"rx_bytes\", offsetof(struct i40e_eth_stats, rx_bytes)},\n+\t{\"rx_unicast_packets\", offsetof(struct i40e_eth_stats, rx_unicast)},\n+\t{\"rx_multicast_packets\", offsetof(struct i40e_eth_stats, rx_multicast)},\n+\t{\"rx_broadcast_packets\", offsetof(struct i40e_eth_stats, rx_broadcast)},\n+\t{\"rx_dropped_packets\", offsetof(struct i40e_eth_stats, rx_discards)},\n+\t{\"rx_unknown_protocol_packets\", offsetof(struct i40e_eth_stats,\n+\t\trx_unknown_protocol)},\n+\t{\"tx_bytes\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+\t{\"tx_unicast_packets\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+\t{\"tx_multicast_packets\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+\t{\"tx_broadcast_packets\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+\t{\"tx_dropped_packets\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+\t{\"tx_error_packets\", offsetof(struct i40e_eth_stats, tx_bytes)},\n+};\n+\n+#define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \\\n+\t\tsizeof(rte_i40evf_stats_strings[0]))\n+\n static const struct eth_dev_ops i40evf_eth_dev_ops = {\n \t.dev_configure = i40evf_dev_configure,\n \t.dev_start = i40evf_dev_start,\n@@ -158,6 +185,8 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {\n \t.allmulticast_disable = i40evf_dev_allmulticast_disable,\n \t.link_update = i40evf_dev_link_update,\n \t.stats_get = i40evf_dev_stats_get,\n+\t.xstats_get = i40evf_dev_xstats_get,\n+\t.xstats_reset = i40evf_dev_xstats_reset,\n \t.dev_close = i40evf_dev_close,\n \t.dev_infos_get = i40evf_dev_info_get,\n \t.vlan_filter_set = i40evf_vlan_filter_set,\n@@ -888,11 +917,10 @@ i40evf_del_mac_addr(struct rte_eth_dev *dev, struct ether_addr *addr)\n }\n \n static int\n-i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+i40evf_update_stats(struct rte_eth_dev *dev, struct i40e_eth_stats **pstats)\n {\n \tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tstruct i40e_virtchnl_queue_select q_stats;\n-\tstruct i40e_eth_stats *pstats;\n \tint err;\n \tstruct vf_cmd_info args;\n \n@@ -907,9 +935,23 @@ i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \terr = i40evf_execute_vf_cmd(dev, &args);\n \tif (err) {\n \t\tPMD_DRV_LOG(ERR, \"fail to execute command OP_GET_STATS\");\n+\t\t*pstats = NULL;\n \t\treturn err;\n \t}\n-\tpstats = (struct i40e_eth_stats *)args.out_buffer;\n+\t*pstats = (struct i40e_eth_stats *)args.out_buffer;\n+\treturn 0;\n+}\n+\n+static int\n+i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tint ret;\n+\tstruct i40e_eth_stats *pstats = NULL;\n+\n+\tret = i40evf_update_stats(dev, &pstats);\n+\tif (ret != 0)\n+\t\treturn 0;\n+\n \tstats->ipackets = pstats->rx_unicast + pstats->rx_multicast +\n \t\t\t\t\t\tpstats->rx_broadcast;\n \tstats->opackets = pstats->tx_broadcast + pstats->tx_multicast +\n@@ -922,6 +964,47 @@ i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \treturn 0;\n }\n \n+static void\n+i40evf_dev_xstats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n+\tstruct i40e_eth_stats *pstats = NULL;\n+\n+\t/* read stat values to clear hardware registers */\n+\ti40evf_update_stats(dev, &pstats);\n+\n+\t/* set stats offset base on current values */\n+\tvf->vsi.eth_stats_offset = vf->vsi.eth_stats;\n+}\n+\n+static int i40evf_dev_xstats_get(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_xstats *xstats, unsigned n)\n+{\n+\tint ret;\n+\tunsigned i;\n+\tstruct i40e_eth_stats *pstats = NULL;\n+\n+\tif (n < I40EVF_NB_XSTATS)\n+\t\treturn I40EVF_NB_XSTATS;\n+\n+\tret = i40evf_update_stats(dev, &pstats);\n+\tif (ret != 0)\n+\t\treturn 0;\n+\n+\tif (!xstats)\n+\t\treturn 0;\n+\n+\t/* loop over xstats array and values from pstats */\n+\tfor (i = 0; i < I40EVF_NB_XSTATS; i++) {\n+\t\tsnprintf(xstats[i].name, sizeof(xstats[i].name),\n+\t\t\t \"%s\", rte_i40evf_stats_strings[i].name);\n+\t\txstats[i].value = *(uint64_t *)(((char *)pstats) +\n+\t\t\trte_i40evf_stats_strings[i].offset);\n+\t}\n+\n+\treturn I40EVF_NB_XSTATS;\n+}\n+\n static int\n i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vlanid)\n {\n", "prefixes": [ "dpdk-dev", "v5", "09/10" ] }{ "id": 8523, "url": "