Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85042/?format=api
{ "id": 85042, "url": "http://patches.dpdk.org/api/patches/85042/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1607846585-2381-5-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1607846585-2381-5-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1607846585-2381-5-git-send-email-oulijun@huawei.com", "date": "2020-12-13T08:03:02", "name": "[4/7] net/hns3: fix Rx/Tx abnormal errors stats", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0e8a4681f02a7be36a44a3324a826b23e39ff50b", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1607846585-2381-5-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 14275, "url": "http://patches.dpdk.org/api/series/14275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14275", "date": "2020-12-13T08:03:03", "name": "some bugfixes for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/14275/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85042/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85042/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3A8E6A04B5;\n\tSun, 13 Dec 2020 09:04:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 86BF5C996;\n\tSun, 13 Dec 2020 09:03:17 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id 858293257\n for <dev@dpdk.org>; Sun, 13 Dec 2020 09:03:11 +0100 (CET)", "from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ctxnz2dMDz15cD5\n for <dev@dpdk.org>; Sun, 13 Dec 2020 16:02:31 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id\n 14.3.498.0; Sun, 13 Dec 2020 16:02:59 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Sun, 13 Dec 2020 16:03:02 +0800", "Message-ID": "<1607846585-2381-5-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1607846585-2381-1-git-send-email-oulijun@huawei.com>", "References": "<1607846585-2381-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 4/7] net/hns3: fix Rx/Tx abnormal errors stats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nAbnormal errors stats in Rx/Tx datapath are statistics\nitems in driver, and displayed in xstats. They should\nbe cleared by the rte_eth_xstats_reset api, instead of\nthe rte_eth_stats_reset.\n\nFixes: c4b7d6761d01 (\"net/hns3: get Tx abnormal errors in xstats\")\nFixes: 521ab3e93361 (\"net/hns3: add simple Rx path\")\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_stats.c | 59 ++++++++++++++++++++++++++++---------------\n 1 file changed, 39 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 94d34bc..1d1f706 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -551,7 +551,6 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_cmd_desc desc_reset;\n \tstruct hns3_rx_queue *rxq;\n-\tstruct hns3_tx_queue *txq;\n \tuint16_t i;\n \tint ret;\n \n@@ -581,29 +580,15 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\t}\n \t}\n \n-\t/* Clear the Rx BD errors stats */\n-\tfor (i = 0; i != eth_dev->data->nb_rx_queues; ++i) {\n+\t/*\n+\t * Clear soft stats of rx error packet which will be dropped\n+\t * in driver.\n+\t */\n+\tfor (i = 0; i < eth_dev->data->nb_rx_queues; ++i) {\n \t\trxq = eth_dev->data->rx_queues[i];\n \t\tif (rxq) {\n \t\t\trxq->pkt_len_errors = 0;\n \t\t\trxq->l2_errors = 0;\n-\t\t\trxq->l3_csum_errors = 0;\n-\t\t\trxq->l4_csum_errors = 0;\n-\t\t\trxq->ol3_csum_errors = 0;\n-\t\t\trxq->ol4_csum_errors = 0;\n-\t\t}\n-\t}\n-\n-\t/* Clear the Tx errors stats */\n-\tfor (i = 0; i != eth_dev->data->nb_tx_queues; ++i) {\n-\t\ttxq = eth_dev->data->tx_queues[i];\n-\t\tif (txq) {\n-\t\t\ttxq->over_length_pkt_cnt = 0;\n-\t\t\ttxq->exceed_limit_bd_pkt_cnt = 0;\n-\t\t\ttxq->exceed_limit_bd_reassem_fail = 0;\n-\t\t\ttxq->unsupported_tunnel_pkt_cnt = 0;\n-\t\t\ttxq->queue_full_cnt = 0;\n-\t\t\ttxq->pkt_padding_fail_cnt = 0;\n \t\t}\n \t}\n \n@@ -1030,6 +1015,38 @@ hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \treturn size;\n }\n \n+static void\n+hns3_tqp_dfx_stats_clear(struct rte_eth_dev *dev)\n+{\n+\tstruct hns3_rx_queue *rxq;\n+\tstruct hns3_tx_queue *txq;\n+\tint i;\n+\n+\t/* Clear Rx dfx stats */\n+\tfor (i = 0; i < dev->data->nb_rx_queues; ++i) {\n+\t\trxq = dev->data->rx_queues[i];\n+\t\tif (rxq) {\n+\t\t\trxq->l3_csum_errors = 0;\n+\t\t\trxq->l4_csum_errors = 0;\n+\t\t\trxq->ol3_csum_errors = 0;\n+\t\t\trxq->ol4_csum_errors = 0;\n+\t\t}\n+\t}\n+\n+\t/* Clear Tx dfx stats */\n+\tfor (i = 0; i < dev->data->nb_tx_queues; ++i) {\n+\t\ttxq = dev->data->tx_queues[i];\n+\t\tif (txq) {\n+\t\t\ttxq->over_length_pkt_cnt = 0;\n+\t\t\ttxq->exceed_limit_bd_pkt_cnt = 0;\n+\t\t\ttxq->exceed_limit_bd_reassem_fail = 0;\n+\t\t\ttxq->unsupported_tunnel_pkt_cnt = 0;\n+\t\t\ttxq->queue_full_cnt = 0;\n+\t\t\ttxq->pkt_padding_fail_cnt = 0;\n+\t\t}\n+\t}\n+}\n+\n int\n hns3_dev_xstats_reset(struct rte_eth_dev *dev)\n {\n@@ -1045,6 +1062,8 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)\n \t/* Clear reset stats */\n \tmemset(&hns->hw.reset.stats, 0, sizeof(struct hns3_reset_stats));\n \n+\thns3_tqp_dfx_stats_clear(dev);\n+\n \tif (hns->is_vf)\n \t\treturn 0;\n \n", "prefixes": [ "4/7" ] }