Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85039/?format=api
{ "id": 85039, "url": "http://patches.dpdk.org/api/patches/85039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1607846585-2381-6-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1607846585-2381-6-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1607846585-2381-6-git-send-email-oulijun@huawei.com", "date": "2020-12-13T08:03:03", "name": "[5/7] net/hns3: fix location of saving ethdev", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bcb0d76985c6658ce6035eaa24eb2118da82fd6b", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1607846585-2381-6-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 14275, "url": "http://patches.dpdk.org/api/series/14275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14275", "date": "2020-12-13T08:03:03", "name": "some bugfixes for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/14275/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85039/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC27DA04B5;\n\tSun, 13 Dec 2020 09:03:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A6D5237B7;\n\tSun, 13 Dec 2020 09:03:12 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id B741737B7\n for <dev@dpdk.org>; Sun, 13 Dec 2020 09:03:11 +0100 (CET)", "from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ctxnz31Q9z15cDF\n for <dev@dpdk.org>; Sun, 13 Dec 2020 16:02:31 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id\n 14.3.498.0; Sun, 13 Dec 2020 16:02:59 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Sun, 13 Dec 2020 16:03:03 +0800", "Message-ID": "<1607846585-2381-6-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1607846585-2381-1-git-send-email-oulijun@huawei.com>", "References": "<1607846585-2381-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 5/7] net/hns3: fix location of saving ethdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Min Hu (Connor)\" <humin29@huawei.com>\n\nIn current version, procedure of saving eth_dev in\nhns3 PMD init will be called more than twice, one\nfor primary, the other for secondary. That will cause\nsegmentation fault in Multi-process as eth_dev will\nbe changed in secondary process, which is different\nfrom one in primary process.\nThis patch saved eth_dev in dev_private only in\nprimary process, as dev_private is shared by primary\nprocess and secondary process.\n\nFixes: 8929efbc1c46 (\"net/hns3: fix FEC state query\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 3 +--\n drivers/net/hns3/hns3_ethdev_vf.c | 1 +\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 7c34e38..f49b779 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -6106,8 +6106,6 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\thns->eth_dev = eth_dev;\n-\n \teth_dev->process_private = (struct hns3_process_private *)\n \t rte_zmalloc_socket(\"hns3_filter_list\",\n \t\t\t sizeof(struct hns3_process_private),\n@@ -6134,6 +6132,7 @@ hns3_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \t}\n \n+\thns->eth_dev = eth_dev;\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;\n \n \tret = hns3_mp_init_primary();\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex f09cabc..9c382bf 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -2753,6 +2753,7 @@ hns3vf_dev_init(struct rte_eth_dev *eth_dev)\n \t\treturn 0;\n \t}\n \n+\thns->eth_dev = eth_dev;\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;\n \n \tret = hns3_mp_init_primary();\n", "prefixes": [ "5/7" ] }