Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84909/?format=api
{ "id": 84909, "url": "http://patches.dpdk.org/api/patches/84909/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201209235347.16180-16-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201209235347.16180-16-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201209235347.16180-16-ajit.khaparde@broadcom.com", "date": "2020-12-09T23:53:45", "name": "[v3,15/17] net/bnxt: changes to indentation and coding style", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c55f36ccb59ca643a16a7ac86cddedd662b6ed5e", "submitter": { "id": 2064, "url": "http://patches.dpdk.org/api/people/2064/?format=api", "name": "Ajit Khaparde", "email": "ajitkhaparde@gmail.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201209235347.16180-16-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14226, "url": "http://patches.dpdk.org/api/series/14226/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14226", "date": "2020-12-09T23:53:30", "name": "fixes and refactoring changes for bnxt", "version": 3, "mbox": "http://patches.dpdk.org/series/14226/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84909/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/84909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4351AA04DB;\n\tThu, 10 Dec 2020 00:58:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 56ADBCA54;\n\tThu, 10 Dec 2020 00:54:22 +0100 (CET)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 4BCE1C9D3\n for <dev@dpdk.org>; Thu, 10 Dec 2020 00:54:14 +0100 (CET)", "by mail-pg1-f193.google.com with SMTP id t37so2448935pga.7\n for <dev@dpdk.org>; Wed, 09 Dec 2020 15:54:14 -0800 (PST)", "from localhost.localdomain ([192.19.228.250])\n by smtp.gmail.com with ESMTPSA id s7sm4047693pfh.207.2020.12.09.15.54.12\n for <dev@dpdk.org>\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 09 Dec 2020 15:54:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version\n :content-transfer-encoding;\n bh=VyA3/SlRtTbtFeEbm3PQMKzw+mHwXjPVof6WYYEqWjc=;\n b=oRBXLLMAXHRJUivCRFVN3zkQHbqJ69HaN+q2Bg49BS0JV+bzyeRhZFQUU8E2zAg7D9\n nj3wgi/BjKhfdH1onUnajVQTbBmw2g0rsB9yxAkTYf87buxjw2+CBp9hSMKrNz7/P1U+\n c1rQ3Esz7Gr7fS39IzMn+f7Wuk3q/6An8jbHBKvHbGKCHxTsg7wExBkSKXVYHOtQkG8z\n QhuwBvA0V9D9hM+0X4DWM6GyCTOaAUnlUMI75lXICXXdm6rLgo4scKaGiL/C+9qkW2xL\n fEk9wenAFqvDE0ZjhBNfa2KP8YCWZJtIX4jBpQKwUY4OcrJh6UYMI9oEyrw4GYfREaWe\n 6VsA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=VyA3/SlRtTbtFeEbm3PQMKzw+mHwXjPVof6WYYEqWjc=;\n b=LNDzj+rXPTB1HuUzHuupDwPkLaKWPGDLnYmbqRF64ruceE+m7P7tOjHzVU8mUGx/c3\n XcqGiOjKfJTYlmqUkQQEJGJjnnyhpWF7woEQTDC32+Xu4yJFGoT55CGVtWOqP624nVNh\n //cIDCqiZlPB5Mnt/liPSdLMxP83xamCfUCJmyT2/pgvrighVmOye+PY55boHS0M0lOq\n aSc7IZOOQzc/ZsEb5eNh6w1/TBZES1TWhUOKOMRzJH6Oziq+Ps/yZ9Crgx+9lgm0b4Hr\n hZJDUR/SCJwvd5jKBU+xUehB6HdMHolOkvqo28r9MSGvkCqKzPST+B/+kSa3zt/RnM+y\n J+Jw==", "X-Gm-Message-State": "AOAM532FHlrEJBM2k9/6dc6M1KK+WxjhZa5GgLZefNUaJfLAWYBbfLV8\n 1rD1j/JwxpQLv+X4L/MvnXICmHRU0O+N0J5k", "X-Google-Smtp-Source": "\n ABdhPJySc0pbEcnyN7AqrCrqHNBKLyK4bfNfbObPtX4rahXsrOORagc9AQQGRUNuzcAiGkcWfmSCoA==", "X-Received": "by 2002:a17:90b:19d2:: with SMTP id\n nm18mr4575540pjb.159.1607558053224;\n Wed, 09 Dec 2020 15:54:13 -0800 (PST)", "From": "Ajit Khaparde <ajitkhaparde@gmail.com>", "X-Google-Original-From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Date": "Wed, 9 Dec 2020 15:53:45 -0800", "Message-Id": "<20201209235347.16180-16-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201209235347.16180-1-ajit.khaparde@broadcom.com>", "References": "<20201209192233.6518-1-ajit.khaparde@broadcom.com>\n <20201209235347.16180-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 15/17] net/bnxt: changes to indentation and\n\tcoding style", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Indentation and coding style fixes.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 4 ++--\n drivers/net/bnxt/bnxt_ethdev.c | 9 ++++-----\n drivers/net/bnxt/bnxt_reps.c | 2 +-\n drivers/net/bnxt/bnxt_ring.c | 3 +--\n 4 files changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 2a318efaf..556e99203 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -127,9 +127,9 @@\n */\n #ifdef RTE_EXEC_ENV_FREEBSD\n /* In FreeBSD OS, nic_uio driver does not support interrupts */\n-#define BNXT_NUM_ASYNC_CPR(bp) 0\n+#define BNXT_NUM_ASYNC_CPR(bp) 0U\n #else\n-#define BNXT_NUM_ASYNC_CPR(bp) 1\n+#define BNXT_NUM_ASYNC_CPR(bp) 1U\n #endif\n \n #define BNXT_MISC_VEC_ID RTE_INTR_VEC_ZERO_OFFSET\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 21d9e26ca..9d5c8aa0f 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1264,11 +1264,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \t\treturn -EINVAL;\n \t}\n \n-\tif (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) {\n+\tif (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS)\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n-\t\t\tbp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\t}\n+\t\t\t \"RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n+\t\t\t bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \n \tdo {\n \t\trc = bnxt_hwrm_if_change(bp, true);\n@@ -1622,7 +1621,7 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n out:\n \t/* Timed out or success */\n \tif (new.link_status != eth_dev->data->dev_link.link_status ||\n-\tnew.link_speed != eth_dev->data->dev_link.link_speed) {\n+\t new.link_speed != eth_dev->data->dev_link.link_speed) {\n \t\trte_eth_linkstatus_set(eth_dev, &new);\n \n \t\trte_eth_dev_callback_process(eth_dev,\ndiff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c\nindex 167c46ad4..12d677d32 100644\n--- a/drivers/net/bnxt/bnxt_reps.c\n+++ b/drivers/net/bnxt/bnxt_reps.c\n@@ -56,7 +56,7 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf)\n \n \t/* Put this mbuf on the RxQ of the Representor */\n \tprod_rx_buf = &rep_rxr->rx_buf_ring[rep_rxr->rx_prod & mask];\n-\tif (!*prod_rx_buf) {\n+\tif (*prod_rx_buf == NULL) {\n \t\t*prod_rx_buf = mbuf;\n \t\tvfr_bp->rx_bytes[que] += mbuf->pkt_len;\n \t\tvfr_bp->rx_pkts[que]++;\ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 579c48d8c..f83bcaba2 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -599,8 +599,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)\n \n \tif (rxq->rx_started) {\n \t\tif (bnxt_init_one_rx_ring(rxq)) {\n-\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"bnxt_init_one_rx_ring failed!\\n\");\n+\t\t\tPMD_DRV_LOG(ERR, \"bnxt_init_one_rx_ring failed!\\n\");\n \t\t\tbnxt_rx_queue_release_op(rxq);\n \t\t\trc = -ENOMEM;\n \t\t\tgoto err_out;\n", "prefixes": [ "v3", "15/17" ] }