Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84889/?format=api
{ "id": 84889, "url": "http://patches.dpdk.org/api/patches/84889/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201209192233.6518-14-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201209192233.6518-14-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201209192233.6518-14-ajit.khaparde@broadcom.com", "date": "2020-12-09T19:22:29", "name": "[v2,13/17] net/bnxt: fix vnic RSS configure function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "57b2ca21bf2e7e7d63a41ee78e8519d149e447bf", "submitter": { "id": 2064, "url": "http://patches.dpdk.org/api/people/2064/?format=api", "name": "Ajit Khaparde", "email": "ajitkhaparde@gmail.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201209192233.6518-14-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14225, "url": "http://patches.dpdk.org/api/series/14225/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14225", "date": "2020-12-09T19:22:16", "name": "fixes and refactoring changes for bnxt", "version": 2, "mbox": "http://patches.dpdk.org/series/14225/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84889/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C8D3DA04DB;\n\tWed, 9 Dec 2020 20:27:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F157CA32;\n\tWed, 9 Dec 2020 20:23:05 +0100 (CET)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id AFDE8C9E7;\n Wed, 9 Dec 2020 20:22:56 +0100 (CET)", "by mail-pf1-f194.google.com with SMTP id f9so1657220pfc.11;\n Wed, 09 Dec 2020 11:22:56 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id y1sm3342449pfe.80.2020.12.09.11.22.54\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 09 Dec 2020 11:22:55 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=9PzNizc9U1DdhSspnLOvIwGQMtCcM4ukiufiC7APRkg=;\n b=W18wYEPorU/MfLYLEssCnh7roRThHJ3UiqWVRQRYmWOdKpJ5T1p1vhJ/N/2fNCnSC7\n YAANzxGiuFLL0UDvb1+ZclIYuttlB4DX2gXdwY2eha4hHfiSkrX8NzJIf9xmp0nPWqyt\n Rn51fCFOnNIzngM61+vGX6BxmcjKjY80tkw4ZXzdqoCTUltuomRsMCTBoNSPO5FBNLOu\n Xp6Fx9k6OQv0f4heyFrtexr7uBLAiLYi+ZSCgbFSXDNHX7hQ1JgpzSnftDynQXWADHvR\n jxYwsE8MStqHPmDJMY6wPiE7rBrS3Pjv8QAZ0AlgfHJ5hca+f1mRU+3H+RN2qFUsLfEj\n Yk8w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=9PzNizc9U1DdhSspnLOvIwGQMtCcM4ukiufiC7APRkg=;\n b=d1xAeudAUWG0haq1leQvJDL3bdrrtmg7GPoKQB8rXXnrvq9LvXdaalDbA3Ibj2752c\n ZSUOkdwdUEUI0Zn52cpbqwWO0EMHL+WlcN1Zd0f7j+5/XRsfxsxtB3+wbYubUShzj9Pf\n 7msuagZ8Xuj5qJvJet5iwgNnV3BGVQGH+QskmQ5QhkNAeSqQ6/AnTnXwGhzUy+pje5wV\n +ztTb6F/vIsu3TpLBQjsQkBD7kpm3XPIbOBBJTgQPMG/kYsTWEb2ZJADGv2X/rR7KPes\n 70ATAGANQ/uyIqixzW64P4Z6+Fe69PIRfMDsooKA7j1MdIWO4IYX6/2sp+XcFn9yGNZS\n zkjQ==", "X-Gm-Message-State": "AOAM532vO+1pmPopMSyd1ahAkN5eIlBSGQ/XiPsL/8dMAL3JHqHNprcJ\n 4zqDP5nODKZC45KJ+DkW7wSLu3cMMR33AP3n", "X-Google-Smtp-Source": "\n ABdhPJwMEbpjK9xdCLNd3NAaU+dehOyiFDhQ9F+Czfk94UqmCCw1iT2hn0z2ucIL7vubfu9+fUpfhw==", "X-Received": "by 2002:aa7:9af1:0:b029:19e:568e:c452 with SMTP id\n y17-20020aa79af10000b029019e568ec452mr3663399pfp.28.1607541775728;\n Wed, 09 Dec 2020 11:22:55 -0800 (PST)", "From": "Ajit Khaparde <ajitkhaparde@gmail.com>", "X-Google-Original-From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, stable@dpdk.org,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 9 Dec 2020 11:22:29 -0800", "Message-Id": "<20201209192233.6518-14-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201209192233.6518-1-ajit.khaparde@broadcom.com>", "References": "<20201209192233.6518-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 13/17] net/bnxt: fix vnic RSS configure\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. moved invalid VNIC id check to the beginning of the function.\n2. removed a duplicate check which avoids unnecessary code indentation.\n\nFixes: 49d0709b257fc (\"net/bnxt: delete and flush L2 filters cleanly\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 42 +++++++++++++++++-------------------\n 1 file changed, 20 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 6f5402070..cee2656c1 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -4896,37 +4896,35 @@ int bnxt_vnic_rss_configure(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n {\n \tunsigned int rss_idx, fw_idx, i;\n \n+\tif (vnic->fw_vnic_id == INVALID_HW_RING_ID)\n+\t\treturn 0;\n+\n \tif (!(vnic->rss_table && vnic->hash_type))\n \t\treturn 0;\n \n \tif (BNXT_CHIP_P5(bp))\n \t\treturn bnxt_vnic_rss_configure_p5(bp, vnic);\n \n-\tif (vnic->fw_vnic_id == INVALID_HW_RING_ID)\n-\t\treturn 0;\n-\n-\tif (vnic->rss_table && vnic->hash_type) {\n-\t\t/*\n-\t\t * Fill the RSS hash & redirection table with\n-\t\t * ring group ids for all VNICs\n-\t\t */\n-\t\tfor (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;\n-\t\t\trss_idx++, fw_idx++) {\n-\t\t\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n-\t\t\t\tfw_idx %= bp->rx_cp_nr_rings;\n-\t\t\t\tif (vnic->fw_grp_ids[fw_idx] !=\n-\t\t\t\t INVALID_HW_RING_ID)\n-\t\t\t\t\tbreak;\n-\t\t\t\tfw_idx++;\n-\t\t\t}\n-\t\t\tif (i == bp->rx_cp_nr_rings)\n-\t\t\t\treturn 0;\n-\t\t\tvnic->rss_table[rss_idx] = vnic->fw_grp_ids[fw_idx];\n+\t/*\n+\t * Fill the RSS hash & redirection table with\n+\t * ring group ids for all VNICs\n+\t */\n+\tfor (rss_idx = 0, fw_idx = 0; rss_idx < HW_HASH_INDEX_SIZE;\n+\t rss_idx++, fw_idx++) {\n+\t\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n+\t\t\tfw_idx %= bp->rx_cp_nr_rings;\n+\t\t\tif (vnic->fw_grp_ids[fw_idx] != INVALID_HW_RING_ID)\n+\t\t\t\tbreak;\n+\t\t\tfw_idx++;\n \t\t}\n-\t\treturn bnxt_hwrm_vnic_rss_cfg(bp, vnic);\n+\n+\t\tif (i == bp->rx_cp_nr_rings)\n+\t\t\treturn 0;\n+\n+\t\tvnic->rss_table[rss_idx] = vnic->fw_grp_ids[fw_idx];\n \t}\n \n-\treturn 0;\n+\treturn bnxt_hwrm_vnic_rss_cfg(bp, vnic);\n }\n \n static void bnxt_hwrm_set_coal_params(struct bnxt_coal *hw_coal,\n", "prefixes": [ "v2", "13/17" ] }