Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84836/?format=api
{ "id": 84836, "url": "http://patches.dpdk.org/api/patches/84836/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-17-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201208201134.47844-17-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201208201134.47844-17-ajit.khaparde@broadcom.com", "date": "2020-12-08T20:11:33", "name": "[16/17] net/bnxt: add missing comments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5da81c7a46b514af963699b28754fb86b844ef4", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-17-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14211, "url": "http://patches.dpdk.org/api/series/14211/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14211", "date": "2020-12-08T20:11:17", "name": "fixes and refactoring changes for bnxt", "version": 1, "mbox": "http://patches.dpdk.org/series/14211/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84836/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84836/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24839A09E9;\n\tTue, 8 Dec 2020 21:17:00 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 65AAFCA4B;\n\tTue, 8 Dec 2020 21:12:10 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 65CE7CA10\n for <dev@dpdk.org>; Tue, 8 Dec 2020 21:12:03 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id q3so13214179pgr.3\n for <dev@dpdk.org>; Tue, 08 Dec 2020 12:12:03 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.59\n for <dev@dpdk.org>\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 08 Dec 2020 12:12:00 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:subject:date:message-id:in-reply-to:references:mime-version;\n bh=7ZS/VEY6m9I4VLBnqOvdq95VkCTEYuHD2opzH2q91oY=;\n b=D/SYTRSRMhuEhnInqk50A+ZYsTVIBlrAsISj59E1I/DnBMsi1frIwEKWNNDvSxPCmd\n PV7xo+sQ9OLZ3/dsFFl9zT/9MOLATAHiCscrlZ5az5TeZ7j4PwtlTpUPabzCGs0po0pG\n ECoFvW0/4eJQZZCFwVcRSo2MlJqciKdnliKbg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=7ZS/VEY6m9I4VLBnqOvdq95VkCTEYuHD2opzH2q91oY=;\n b=GvnAtGea56bgy5dK6PHZdFyL+cmspudqyyDnuVzot0HHtpGF9HkVO9i8apWmArx4CH\n apXiPubVN0fw19ZZiozRZrnwMZB/2PcsdfSXAfFz8zeGBYCR6ffrRL/wSGTCOu0bgTBY\n LzgCsM1ROAV67MtchAcl6kJM/Ro3dv0+SCDdvR799NUHE2ugq1eX91I6Xppqx/3a2ghY\n VTnxJMp7LSkUAeUy7GV6/slaWU39ayyx4q0dsg09muzioNJ0W6IzBDQIP2DR6FJacNIV\n ESWWAvbo8qoMn9+DizwFcgUV23yYY7AlV2eXVviubV/td0ROjQOHm6lfnLorlQd/zUDb\n ADVg==", "X-Gm-Message-State": "AOAM530rKpAOAWItZxgGTujeKU+HxC1J/wL6q3/rqHp6OQf3jvG/rNhb\n 6wH2gSgGWEPhs9c3fH7soccoyVnenesM7am6yW91+TLe1TEvPcof5TKVeeNtwgD05D6NnE88O7C\n ENMN3T1x2Y6MBbPCeUDqiy97K/Ss7UJx0256aexBqWEiAX78FhsLufn7ufRx8D8eUdg==", "X-Google-Smtp-Source": "\n ABdhPJxGxXatpxJLE9XAzmH7PCg00qxXwY/3J6GtHgf+9zxD+xgtF1Sf2qnqNwOY+hmloYk7dT/TqA==", "X-Received": "by 2002:a17:90a:e28a:: with SMTP id\n d10mr5659316pjz.77.1607458321202;\n Tue, 08 Dec 2020 12:12:01 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Date": "Tue, 8 Dec 2020 12:11:33 -0800", "Message-Id": "<20201208201134.47844-17-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "References": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 16/17] net/bnxt: add missing comments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add and update some missing comments in the code.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 6 ++++++\n drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 +++++\n drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++++++\n 3 files changed, 17 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 556e99203..07d39ee93 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -724,7 +724,13 @@ struct bnxt {\n \tvoid\t\t\t\t*hwrm_short_cmd_req_addr;\n \trte_iova_t\t\t\thwrm_short_cmd_req_dma_addr;\n \trte_spinlock_t\t\t\thwrm_lock;\n+\t/* synchronize between dev_configure_op and int handler */\n \tpthread_mutex_t\t\t\tdef_cp_lock;\n+\t/* synchronize between dev_start_op and async evt handler\n+\t * Locking sequence in async evt handler will be\n+\t * def_cp_lock\n+\t * health_check_lock\n+\t */\n \tpthread_mutex_t\t\t\thealth_check_lock;\n \tuint16_t\t\t\tmax_req_len;\n \tuint16_t\t\t\tmax_resp_len;\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c\nindex 00ada607a..509af7c58 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c\n@@ -8,6 +8,10 @@\n #include \"ulp_template_struct.h\"\n #include \"ulp_rte_parser.h\"\n \n+/*\n+ * Action signature table:\n+ * maps hash id to ulp_act_match_list[] index\n+ */\n uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = {\n \t[BNXT_ULP_ACT_HID_015a] = 1,\n \t[BNXT_ULP_ACT_HID_00eb] = 2,\n@@ -93,6 +97,7 @@ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = {\n \t[BNXT_ULP_ACT_HID_0b4e] = 82\n };\n \n+/* Array for the act matcher list */\n struct bnxt_ulp_act_match_info ulp_act_match_list[] = {\n \t[1] = {\n \t.act_hid = BNXT_ULP_ACT_HID_015a,\ndiff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c\nindex fdb26da3e..d904a04cb 100644\n--- a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c\n+++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c\n@@ -8,6 +8,11 @@\n #include \"ulp_template_struct.h\"\n #include \"ulp_rte_parser.h\"\n \n+/* Define the template structures */\n+/*\n+ * Classification signature table:\n+ * maps hash id to ulp_class_match_list[] index\n+ */\n uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = {\n \t[BNXT_ULP_CLASS_HID_0138] = 1,\n \t[BNXT_ULP_CLASS_HID_03f0] = 2,\n@@ -227,6 +232,7 @@ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = {\n \t[BNXT_ULP_CLASS_HID_01b4] = 216\n };\n \n+/* Array for the proto matcher list */\n struct bnxt_ulp_class_match_info ulp_class_match_list[] = {\n \t[1] = {\n \t.class_hid = BNXT_ULP_CLASS_HID_0138,\n", "prefixes": [ "16/17" ] }