Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84822/?format=api
{ "id": 84822, "url": "http://patches.dpdk.org/api/patches/84822/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-3-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201208201134.47844-3-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201208201134.47844-3-ajit.khaparde@broadcom.com", "date": "2020-12-08T20:11:19", "name": "[02/17] net/bnxt: fix VNIC config on Rx queue stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "df12e34ae4a4043cf99b650fe324212f9ccf9ea6", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201208201134.47844-3-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 14211, "url": "http://patches.dpdk.org/api/series/14211/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14211", "date": "2020-12-08T20:11:17", "name": "fixes and refactoring changes for bnxt", "version": 1, "mbox": "http://patches.dpdk.org/series/14211/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84822/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84822/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22B4CA09E9;\n\tTue, 8 Dec 2020 21:12:33 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ACECFC982;\n\tTue, 8 Dec 2020 21:11:47 +0100 (CET)", "from mail-pl1-f196.google.com (mail-pl1-f196.google.com\n [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id C3165C8FA\n for <dev@dpdk.org>; Tue, 8 Dec 2020 21:11:43 +0100 (CET)", "by mail-pl1-f196.google.com with SMTP id y10so6089089plr.10\n for <dev@dpdk.org>; Tue, 08 Dec 2020 12:11:43 -0800 (PST)", "from localhost.localdomain ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id x10sm5729187pfc.157.2020.12.08.12.11.40\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 08 Dec 2020 12:11:40 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version; bh=1DPiCQMmtWqEoY73vSlXeoeOjxf5AB88I8TCGzGUEq0=;\n b=bEh4yKly+Y8bdc3YLfP/EfL2drjMAVLFh1oDQn7WDSVWw9WXY3ej+CICK7L/TCQTKh\n s3Vu8qrF/JHlFwoHsaXazFunImAL/+HCmzIpAJHHYjTCCOVVsvP5qmb9gmaCLoili3d1\n MXeWYOgx1gr3r9eEVsHIheOUoX+We+3+wdrhE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version;\n bh=1DPiCQMmtWqEoY73vSlXeoeOjxf5AB88I8TCGzGUEq0=;\n b=Rg8rvQaQ2iYW99fS3t1AgvwW4508Ce8aSIF228VIc7ozkao/9X06he+R4pZYsxSJRP\n AVfZCAteIUAQeJKHBBC5/nM2+CiqviAjF/BbMg1HLhsxOj3tU8RNdQwxjNHBuTIUi+bA\n Hvh1k0kt9YXbKK/qn0NfcIrXhCPeB93DwIHb0rqua+r0Z8PoaWeJoBucaJXQQOOrzDo9\n k/xxe8DuVRiceG3oJFlaQhZi6N2chQ0wHXCeVXRpHWkZGZJIaZn7edqErhiNjsuzvVdJ\n M6KmPLQPSxyUxddweC6eOH7moe8XHqPi4071fb9eJDLdPlKVzSAFcGHGxoFA3uQ4tRy8\n anXw==", "X-Gm-Message-State": "AOAM533mR9fROchCkyBQDDKlb68KTtvRWN5JOkPZ3v7mQxpBq0qGu/Qp\n FQaDW4jTP23rSbhM/6dSPWaWzWRf8aaukSIiEIMDlSOhjWX4gsjPvFyu/Qohly/sRop/HVs2lB8\n LLFgjdUIWNwizz8J9bYFZkLN5MGk/Mci0lf8XDkV8volaCU5s2QYN8rrI2Fy53wLFIA==", "X-Google-Smtp-Source": "\n ABdhPJwc91gCR0M1Va0Hqq3faWNu0Z6mmAvXDjR3Ga+6lbtZoSHn6RvRzlxSD5W5C6QSpgo2kGNjOA==", "X-Received": "by 2002:a17:902:8a93:b029:d9:d4a5:dc3c with SMTP id\n p19-20020a1709028a93b02900d9d4a5dc3cmr22260833plo.19.1607458301478;\n Tue, 08 Dec 2020 12:11:41 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Samik Gupta <samik.gupta@broadcom.com>, stable@dpdk.org,\n Lance Richardson <lance.richardson@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 8 Dec 2020 12:11:19 -0800", "Message-Id": "<20201208201134.47844-3-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "References": "<20201208201134.47844-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"US-ASCII\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH 02/17] net/bnxt: fix VNIC config on Rx queue stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Samik Gupta <samik.gupta@broadcom.com>\n\nThis commit reconfigures a vnic's default ring if the current default\nring is stopped by the application. It picks the lowest numbered ring\nthat is currently active to be the new default, and issues the\nhwrm_vnic_cfg command to update the configuration. Applies to adapters\nthat are not Thor-based.\n\nFixes: 9b63c6fd70e3 (\"net/bnxt: support Rx/Tx queue start/stop\")\nCc: stable@dpdk.org\n\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n\nSigned-off-by: Samik Gupta <samik.gupta@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 26 +++++++++++++++++++++-----\n 1 file changed, 21 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex e0ec34216..61196eba9 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -557,12 +557,12 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\trc = bnxt_vnic_rss_configure(bp, vnic);\n \t}\n \n-\tif (BNXT_CHIP_THOR(bp)) {\n-\t\t/* Compute current number of active receive queues. */\n-\t\tfor (i = vnic->start_grp_id; i < vnic->end_grp_id; i++)\n-\t\t\tif (bp->rx_queues[i]->rx_started)\n-\t\t\t\tactive_queue_cnt++;\n+\t/* Compute current number of active receive queues. */\n+\tfor (i = vnic->start_grp_id; i < vnic->end_grp_id; i++)\n+\t\tif (bp->rx_queues[i]->rx_started)\n+\t\t\tactive_queue_cnt++;\n \n+\tif (BNXT_CHIP_THOR(bp)) {\n \t\t/*\n \t\t * For Thor, we need to ensure that the VNIC default receive\n \t\t * ring corresponds to an active receive queue. When no queue\n@@ -582,6 +582,22 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\t\t/* Reconfigure default receive ring. */\n \t\t\tbnxt_hwrm_vnic_cfg(bp, vnic);\n \t\t}\n+\t} else if (active_queue_cnt) {\n+\t\t/*\n+\t\t * If the queue being stopped is the current default queue and\n+\t\t * there are other active queues, pick one of them as the\n+\t\t * default and reconfigure the vnic.\n+\t\t */\n+\t\tif (vnic->dflt_ring_grp == bp->grp_info[rx_queue_id].fw_grp_id) {\n+\t\t\tfor (i = vnic->start_grp_id; i < vnic->end_grp_id; i++) {\n+\t\t\t\tif (bp->rx_queues[i]->rx_started) {\n+\t\t\t\t\tvnic->dflt_ring_grp =\n+\t\t\t\t\t\tbp->grp_info[i].fw_grp_id;\n+\t\t\t\t\tbnxt_hwrm_vnic_cfg(bp, vnic);\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n \t}\n \n \tif (rc == 0)\n", "prefixes": [ "02/17" ] }