Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84777/?format=api
{ "id": 84777, "url": "http://patches.dpdk.org/api/patches/84777/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20201207095302.2133-2-haiyangx.zhao@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20201207095302.2133-2-haiyangx.zhao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20201207095302.2133-2-haiyangx.zhao@intel.com", "date": "2020-12-07T09:53:01", "name": "[V1,1/2] framework/dut: add -a support in create_eal_parameters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a43717976e8a7c76df493b02ec110998e10961a3", "submitter": { "id": 1978, "url": "http://patches.dpdk.org/api/people/1978/?format=api", "name": "Zhao, HaiyangX", "email": "haiyangx.zhao@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20201207095302.2133-2-haiyangx.zhao@intel.com/mbox/", "series": [ { "id": 14197, "url": "http://patches.dpdk.org/api/series/14197/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=14197", "date": "2020-12-07T09:53:00", "name": "framework: add -a option support in eal param", "version": 1, "mbox": "http://patches.dpdk.org/series/14197/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84777/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/84777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD4DBA09E5;\n\tMon, 7 Dec 2020 10:59:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 35D3DC8CC;\n\tMon, 7 Dec 2020 10:59:31 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 8FE62F72\n for <dts@dpdk.org>; Mon, 7 Dec 2020 10:59:29 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Dec 2020 01:59:27 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.57])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Dec 2020 01:59:26 -0800" ], "IronPort-SDR": [ "\n tTb6L4jXgn4Q4sRwO2kxtmZ+D1r3/sVJLHhUij8jCcEH78/GXpzDflNe2cLxwcdh8e3w8IwAAf\n iVRBrgGDApfw==", "\n AtrmEHsVvE6D0lxsG3+8NIv949ChfaeH+WZ8n/Wk8q+7Ep15TR9dw6sj82jg59fCyT+t7a8XFg\n 9iq3moCFyxVw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9827\"; a=\"173783178\"", "E=Sophos;i=\"5.78,399,1599548400\"; d=\"scan'208\";a=\"173783178\"", "E=Sophos;i=\"5.78,399,1599548400\"; d=\"scan'208\";a=\"541448206\"" ], "From": "Haiyang Zhao <haiyangx.zhao@intel.com>", "To": "lijuan.tu@intel.com,\n\tdts@dpdk.org", "Cc": "Haiyang Zhao <haiyangx.zhao@intel.com>", "Date": "Mon, 7 Dec 2020 17:53:01 +0800", "Message-Id": "<20201207095302.2133-2-haiyangx.zhao@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201207095302.2133-1-haiyangx.zhao@intel.com>", "References": "<20201207095302.2133-1-haiyangx.zhao@intel.com>", "Subject": "[dts] [PATCH V1 1/2] framework/dut: add -a support in\n\tcreate_eal_parameters", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "eal parameter -w is deprecated since dpdk 20.11.0-rc3 and should use -a\n instead. For dpdk LTS test and avoid modify the -w option in suites, keep the\n -w support.\n\nSigned-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>\n---\n framework/dut.py | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/framework/dut.py b/framework/dut.py\nindex f3ef8c6..dcf833b 100644\n--- a/framework/dut.py\n+++ b/framework/dut.py\n@@ -116,7 +116,8 @@ class Dut(Crb):\n \"\"\"\n generate eal parameters character string\n :param config:\n- :return: eal_str eg:'-c 0xf -w 0000:88:00.0 -w 0000:88:00.1 --file-prefix=dpdk_1112_20190809143420'\n+ :return: eal_str eg:'-c 0xf -a 0000:88:00.0 -a 0000:88:00.1 --file-prefix=dpdk_1112_20190809143420',\n+ if dpdk version < 20.11-rc4, eal_str eg: '-c 0xf -w 0000:88:00.0 --file-prefix=dpdk_1112_20190809143420',\n \"\"\"\n default_cores = '1S/2C/1T'\n blank = ' '\n@@ -137,19 +138,20 @@ class Dut(Crb):\n # deal with ports\n w_pci_list = []\n if 'ports' in config and len(config['ports']) != 0:\n+ allow_option = '-a' if self.dpdk_version > '20.11.0-rc3' or self.dpdk_version == '20.11.0' else '-w'\n for port in config['ports']:\n if type(port) == int:\n if 'port_options' in config and port in list(config['port_options'].keys()):\n port_option = config['port_options'][port]\n- w_pci_list.append('-w %s,%s' % (self.ports_info[port]['pci'], port_option))\n+ w_pci_list.append('%s %s,%s' % (allow_option, self.ports_info[port]['pci'], port_option))\n else:\n- w_pci_list.append('-w %s' % self.ports_info[port]['pci'])\n+ w_pci_list.append('%s %s' % (allow_option, self.ports_info[port]['pci']))\n else:\n if 'port_options' in config and port in list(config['port_options'].keys()):\n port_option = config['port_options'][port]\n- w_pci_list.append('-w %s,%s' % (port, port_option))\n+ w_pci_list.append('%s %s,%s' % (allow_option, port, port_option))\n else:\n- w_pci_list.append('-w %s' % port)\n+ w_pci_list.append('%s %s' % (allow_option, port))\n w_pci_str = ' '.join(w_pci_list)\n \n # deal with black ports\n", "prefixes": [ "V1", "1/2" ] }