Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8475,
    "url": "http://patches.dpdk.org/api/patches/8475/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1446231319-8185-12-git-send-email-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1446231319-8185-12-git-send-email-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1446231319-8185-12-git-send-email-adrien.mazarguil@6wind.com",
    "date": "2015-10-30T18:55:14",
    "name": "[dpdk-dev,v2,11/16] app/testpmd: fix missing initialization in the RSS hash show command",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a43c8970e04992c3b6e270be39e7fdf5ba256521",
    "submitter": {
        "id": 165,
        "url": "http://patches.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1446231319-8185-12-git-send-email-adrien.mazarguil@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/8475/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/8475/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8F09693B4;\n\tFri, 30 Oct 2015 19:56:21 +0100 (CET)",
            "from mail-wm0-f54.google.com (mail-wm0-f54.google.com\n\t[74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 21AA9926B\n\tfor <dev@dpdk.org>; Fri, 30 Oct 2015 19:56:14 +0100 (CET)",
            "by wmff134 with SMTP id f134so18517260wmf.1\n\tfor <dev@dpdk.org>; Fri, 30 Oct 2015 11:56:14 -0700 (PDT)",
            "from 6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tl186sm4197400wmg.19.2015.10.30.11.56.13\n\t(version=TLSv1.2 cipher=RC4-SHA bits=128/128);\n\tFri, 30 Oct 2015 11:56:13 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind_com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=R2K6wlgos8dtVZXLgpF4ENIWjztV83l0yViRszL0aNE=;\n\tb=qIj/Ypq+CykP+WEhJrLxhHCvlnW+EUa40sJxJOF3ARu2eW0d2LMwHw7hLC5LNqC6WN\n\tdQTpHyEsMsMS+g6ejwhx0YhoN93pKWVhVJTSSjXQnjaddQrRxF1/wjH9TpIDVX8Rp9rC\n\tbaxCSIGO0Vqm5ljPz7xx04T0zUYFGeI9d9W26j9/z+3tNmFfucWI+OPNFiQWQMKHTZ/z\n\t/7vOLsPUSgQLdIeO7gnGLKdnBC6Hn4H7hIxQm2aOE8p8KjHpIiaUf95HNh9rQxFpzZsF\n\tIU4K8aGN27M82VADERDYDB01zt9r+BUKwdo2LOyWpbo/ERvIs32Gys+/LY8b4eZw295V\n\t8bEg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=R2K6wlgos8dtVZXLgpF4ENIWjztV83l0yViRszL0aNE=;\n\tb=mJnbjkx/JotmOJnkGlcAERSCforskFRiGfE6LUzTS+5/ijyGD+rnEYNRzax0XytKTC\n\t4TSMFhgYmtDQCAEAAHIh4W3I1/8/NRfaIkpCDwSQzdRahKanFJp2cZXu6cjvCeXf3a0p\n\t1vy0JtNXqRpMgwTp8KXNSmHDn7jT0sCAFwwJz+dBEYZoFbCBNVyAVj6AJsbPbit3iYm/\n\tUOArGpAghBvS4r8R+glMoZMFvZ/BEZtAzH+cB/p8gdE+0kCShLA+L9nZfGl0Fe5GzMxx\n\tARihW1L30ZRP/o/hGcQRCvn6zKC1qRBDBUwg4T5sqDRw4Jyl3h3A4AKqtVeuiS01TTAX\n\tsG7Q==",
        "X-Gm-Message-State": "ALoCoQmb7ans7WNVjNwm1LBetsxZ4Fro7Yk6F6ATwI6uX/Ei5aw3z/8uLaU+gb5Pzz6hM5JsG3o9",
        "X-Received": "by 10.28.55.7 with SMTP id e7mr4876121wma.18.1446231374006;\n\tFri, 30 Oct 2015 11:56:14 -0700 (PDT)",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 30 Oct 2015 19:55:14 +0100",
        "Message-Id": "<1446231319-8185-12-git-send-email-adrien.mazarguil@6wind.com>",
        "X-Mailer": "git-send-email 2.1.0",
        "In-Reply-To": "<1446231319-8185-1-git-send-email-adrien.mazarguil@6wind.com>",
        "References": "<1444067692-29645-1-git-send-email-adrien.mazarguil@6wind.com>\n\t<1446231319-8185-1-git-send-email-adrien.mazarguil@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v2 11/16] app/testpmd: fix missing initialization\n\tin the RSS hash show command",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The \"show port X rss-hash\" command sometimes displays garbage instead of the\nexpected RSS hash key because the maximum key length is undefined. When the\nrequested key is too large to fit in the buffer,\nrte_eth_dev_rss_hash_conf_get() does not update it.\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n app/test-pmd/config.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 8474706..d6f4e64 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -879,7 +879,7 @@ void\n port_rss_hash_conf_show(portid_t port_id, char rss_info[], int show_rss_key)\n {\n \tstruct rte_eth_rss_conf rss_conf;\n-\tuint8_t rss_key[10 * 4];\n+\tuint8_t rss_key[10 * 4] = \"\";\n \tuint64_t rss_hf;\n \tuint8_t i;\n \tint diag;\n@@ -895,6 +895,7 @@ port_rss_hash_conf_show(portid_t port_id, char rss_info[], int show_rss_key)\n \n \t/* Get RSS hash key if asked to display it */\n \trss_conf.rss_key = (show_rss_key) ? rss_key : NULL;\n+\trss_conf.rss_key_len = sizeof(rss_key);\n \tdiag = rte_eth_dev_rss_hash_conf_get(port_id, &rss_conf);\n \tif (diag != 0) {\n \t\tswitch (diag) {\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "11/16"
    ]
}