Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84718/?format=api
{ "id": 84718, "url": "http://patches.dpdk.org/api/patches/84718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201202130529.7332-2-lironh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201202130529.7332-2-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201202130529.7332-2-lironh@marvell.com", "date": "2020-12-02T13:05:28", "name": "[v1,1/2] meson: update meson build for armada drivers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "341fccfe3d975346ece0d33546c9a5c5b25408e0", "submitter": { "id": 996, "url": "http://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201202130529.7332-2-lironh@marvell.com/mbox/", "series": [ { "id": 14172, "url": "http://patches.dpdk.org/api/series/14172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14172", "date": "2020-12-02T13:05:27", "name": "armada: introduce musdk pkg-config", "version": 1, "mbox": "http://patches.dpdk.org/series/14172/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84718/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5648CA04DB;\n\tWed, 2 Dec 2020 14:06:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C779AC9C8;\n\tWed, 2 Dec 2020 14:05:46 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 775F8C9C2\n for <dev@dpdk.org>; Wed, 2 Dec 2020 14:05:45 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 0B2D0MN3005257; Wed, 2 Dec 2020 05:05:43 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 355w50a2xh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 02 Dec 2020 05:05:43 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 2 Dec 2020 05:05:41 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 2 Dec 2020 05:05:40 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=KrebopIRuvSiAj/sSqM3gs4/Y93u4djgjWm7L6b1rcw=;\n b=WPAGPFuehavjUJoQwNtm51QxhCEk6gsVFgyNkynh1CnKoqch0UAoWckalln/LdRxakN3\n 0CDZ5m5hF69Rut6eEyN0l8QpIdNnh4St+aWiIskd3xw2LfIUkcpRnseDIkixW4cjmuSl\n dcagE0WMEoRzFio6ix5igh5Xu10Q+Whcuz6kpRRbtdaytA6icsSR2OBCn8QEqeOeJJsh\n nxF+Sy2Jn51xHCa26dbY2mycDsSqmWKvxjEBuoyPcCJ6E86QMEymMnhmZOzaUVxjbh2v\n qqo7UR6nx9GLlHEQsf+P141E/7SRNCNBT+f9UsgUpttC9O+jKlONYqGUs91bQhMxsZ+/ bA==", "From": "<lironh@marvell.com>", "To": "<bruce.richardson@intel.com>", "CC": "<dev@dpdk.org>, Liron Himi <lironh@marvell.com>", "Date": "Wed, 2 Dec 2020 15:05:28 +0200", "Message-ID": "<20201202130529.7332-2-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201202130529.7332-1-lironh@marvell.com>", "References": "<20201202130529.7332-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737\n definitions=2020-12-02_06:2020-11-30,\n 2020-12-02 signatures=0", "Subject": "[dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada\n\tdrivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nWith pkg-config support available within musdk library,\nmeson option 'lib_musdk_dir' can be removed.\nPKG_CONFIG_PATH environment variable should be set appropriately\nto use the musdk library.\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/common/mvep/meson.build | 14 +++++---------\n drivers/crypto/mvsam/meson.build | 15 +++++----------\n drivers/net/mvneta/meson.build | 19 +++++--------------\n drivers/net/mvneta/mvneta_ethdev.h | 1 +\n drivers/net/mvpp2/meson.build | 15 +++++----------\n meson_options.txt | 2 --\n 6 files changed, 21 insertions(+), 45 deletions(-)", "diff": "diff --git a/drivers/common/mvep/meson.build b/drivers/common/mvep/meson.build\nindex 8df4bc6e0..863a20ab9 100644\n--- a/drivers/common/mvep/meson.build\n+++ b/drivers/common/mvep/meson.build\n@@ -3,18 +3,14 @@\n # Copyright(c) 2018 Semihalf.\n # All rights reserved.\n #\n-path = get_option('lib_musdk_dir')\n-lib_dir = path + '/lib'\n-inc_dir = path + '/include'\n \n-lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)\n-if not lib.found()\n+dep = dependency('libmusdk', required: false)\n+if not dep.found()\n \tbuild = false\n \treason = 'missing dependency, \"libmusdk\"'\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-\tcflags += ['-DMVCONF_TYPES_PUBLIC', '-DMVCONF_DMA_PHYS_ADDR_T_PUBLIC']\n+\tsubdir_done()\n endif\n \n+ext_deps += dep\n+\n sources = files('mvep_common.c')\ndiff --git a/drivers/crypto/mvsam/meson.build b/drivers/crypto/mvsam/meson.build\nindex 6d97dc8a2..384eacff0 100644\n--- a/drivers/crypto/mvsam/meson.build\n+++ b/drivers/crypto/mvsam/meson.build\n@@ -3,20 +3,15 @@\n # Copyright(c) 2018 Semihalf.\n # All rights reserved.\n \n-path = get_option('lib_musdk_dir')\n-lib_dir = path + '/lib'\n-inc_dir = path + '/include'\n-\n-lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)\n-if not lib.found()\n+dep = dependency('libmusdk', required: false)\n+if not dep.found()\n \tbuild = false\n \treason = 'missing dependency, \"libmusdk\"'\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-\tcflags += ['-DMVCONF_TYPES_PUBLIC', '-DMVCONF_DMA_PHYS_ADDR_T_PUBLIC']\n+\tsubdir_done()\n endif\n \n+ext_deps += dep\n+\n sources = files('rte_mrvl_pmd.c', 'rte_mrvl_pmd_ops.c')\n \n deps += ['bus_vdev', 'common_mvep']\ndiff --git a/drivers/net/mvneta/meson.build b/drivers/net/mvneta/meson.build\nindex 8d7202788..c887ddc10 100644\n--- a/drivers/net/mvneta/meson.build\n+++ b/drivers/net/mvneta/meson.build\n@@ -3,24 +3,15 @@\n # Copyright(c) 2018 Semihalf.\n # All rights reserved.\n \n-path = get_option('lib_musdk_dir')\n-lib_dir = path + '/lib'\n-inc_dir = path + '/include'\n-\n-lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)\n-if not lib.found()\n+dep = dependency('libmusdk', required: false)\n+if not dep.found()\n \tbuild = false\n \treason = 'missing dependency, \"libmusdk\"'\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-\tcflags += [\n-\t '-DMVCONF_TYPES_PUBLIC',\n-\t '-DMVCONF_DMA_PHYS_ADDR_T_PUBLIC',\n-\t '-DMVCONF_DMA_PHYS_ADDR_T_SIZE=64'\n-\t]\n+\tsubdir_done()\n endif\n \n+ext_deps += dep\n+\n sources = files(\n \t'mvneta_ethdev.c',\n \t'mvneta_rxtx.c'\ndiff --git a/drivers/net/mvneta/mvneta_ethdev.h b/drivers/net/mvneta/mvneta_ethdev.h\nindex ef8067790..e090abc25 100644\n--- a/drivers/net/mvneta/mvneta_ethdev.h\n+++ b/drivers/net/mvneta/mvneta_ethdev.h\n@@ -21,6 +21,7 @@\n #undef container_of\n #endif\n \n+#include <env/mv_autogen_comp_flags.h>\n #include <drivers/mv_neta.h>\n #include <drivers/mv_neta_ppio.h>\n \ndiff --git a/drivers/net/mvpp2/meson.build b/drivers/net/mvpp2/meson.build\nindex e06eddaac..3015a5559 100644\n--- a/drivers/net/mvpp2/meson.build\n+++ b/drivers/net/mvpp2/meson.build\n@@ -3,20 +3,15 @@\n # Copyright(c) 2018 Semihalf.\n # All rights reserved.\n \n-path = get_option('lib_musdk_dir')\n-lib_dir = path + '/lib'\n-inc_dir = path + '/include'\n-\n-lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)\n-if not lib.found()\n+dep = dependency('libmusdk', required: false)\n+if not dep.found()\n \tbuild = false\n \treason = 'missing dependency, \"libmusdk\"'\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-\tcflags += ['-DMVCONF_TYPES_PUBLIC', '-DMVCONF_DMA_PHYS_ADDR_T_PUBLIC']\n+\tsubdir_done()\n endif\n \n+ext_deps += dep\n+\n sources = files(\n \t'mrvl_ethdev.c',\n \t'mrvl_flow.c',\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9bf18ab6b..63245b95d 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -20,8 +20,6 @@ option('include_subdir_arch', type: 'string', value: '',\n \tdescription: 'subdirectory where to install arch-dependent headers')\n option('kernel_dir', type: 'string', value: '',\n \tdescription: 'Path to the kernel for building kernel modules. Headers must be in $kernel_dir/build. Modules will be installed in $DEST_DIR/$kernel_dir/extra/dpdk.')\n-option('lib_musdk_dir', type: 'string', value: '',\n-\tdescription: 'path to the MUSDK library installation directory')\n option('machine', type: 'string', value: 'native',\n \tdescription: 'set the target machine type')\n option('max_ethports', type: 'integer', value: 32,\n", "prefixes": [ "v1", "1/2" ] }