Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84508/?format=api
{ "id": 84508, "url": "http://patches.dpdk.org/api/patches/84508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201124123249.14451-5-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201124123249.14451-5-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201124123249.14451-5-ibtisam.tariq@emumba.com", "date": "2020-11-24T12:32:47", "name": "[5/7] examples/qos_sched: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b83f1290797fdf4723948bf8c443f0777effd51f", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201124123249.14451-5-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 14068, "url": "http://patches.dpdk.org/api/series/14068/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14068", "date": "2020-11-24T12:32:43", "name": "[1/7] examples/fips_validation: enhance getopt_long usage", "version": 1, "mbox": "http://patches.dpdk.org/series/14068/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84508/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B5572A04B1;\n\tTue, 24 Nov 2020 13:34:50 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1373DC954;\n\tTue, 24 Nov 2020 13:33:47 +0100 (CET)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id CBEB9C938\n for <dev@dpdk.org>; Tue, 24 Nov 2020 13:33:44 +0100 (CET)", "by mail-wr1-f65.google.com with SMTP id l1so22124397wrb.9\n for <dev@dpdk.org>; Tue, 24 Nov 2020 04:33:44 -0800 (PST)", "from localhost.localdomain ([39.33.169.238])\n by smtp.gmail.com with ESMTPSA id w3sm5409034wma.3.2020.11.24.04.33.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 24 Nov 2020 04:33:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=0rOssm3c5g1ESEh+V5TagxsSV+gyRmy/iN8Y9DJxTzc=;\n b=oPINEokY9SDRmzWrwNl9HmFNJPz9JPJLhtbLhdUow+qQhx+UBIt/cMoMWHto/lbUPe\n pkcRTy2pnhK69IvjKmh1+pm62SalmVddbGyBpP/l0pD15v84U4G9aPSFyrgInrKacOz3\n yf6ux3eBvBF6UkCBkRYsrrq+0MRheEPn3UnsArxmz7/DLSPYBcVI9Ie1DvuV8uVcEGHZ\n R/8i3JDa9YKZq4lFqEy2so1t02cv7M0qUhKOgMmwYxsWtAvpmpq38WU2KRonMpFB/zqb\n csCBuZJPmbu4jppD/onpzW9FKageOzlmJaqZ2RCVwShJkNsBVuukfUCnpId1s5NttgWR\n HFgw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=0rOssm3c5g1ESEh+V5TagxsSV+gyRmy/iN8Y9DJxTzc=;\n b=T2Grg2eSfl84n1c+VPmZVAX14XNgy+wL6mlUM/Ba0TJBcRdUK/EycehnZlFxNk1bkb\n eZXUYDxGeF6GaSBqA2iS2cizOAQhei3EN7TVpCYTzd2HYojVSSqITyP2J8WzxzzkcMtf\n pRRyBEIVN11O5WH4fThibpgv4zIJA9B8Tj/1nvPiIezbHGqz1ROEyYGCzqPf10cZeagn\n 7EZnP9HykKRv+/WixDNp9tUzdCh6SusBUM0ofYbW7iBRC+ZAPmSq4kW439KucIY3WlrV\n 57z6aB2mvThmoolDsOl87NTxMMXPXHqhyHFrTNHZV3LMpG/J2GC2dzp0FrcWT8vx2hwV\n J5oQ==", "X-Gm-Message-State": "AOAM531I+ivkwBA38vPGLpQQvKv3RB0fKzh4bv9zZ9hlmaqjjto2ooqJ\n Y4yNR4oV+C7vvj+pXqeiBNUABA==", "X-Google-Smtp-Source": "\n ABdhPJx/YxN6rG8JCoW2qgBlfRWqSqoiKbV7CsVRYf2Eu8UV/quep4cc8CeDNVfVggMwqFLyggaxFg==", "X-Received": "by 2002:adf:9b85:: with SMTP id d5mr5149972wrc.9.1606221224540;\n Tue, 24 Nov 2020 04:33:44 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n stephen@networkplumber.org", "Date": "Tue, 24 Nov 2020 12:32:47 +0000", "Message-Id": "<20201124123249.14451-5-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201124123249.14451-1-ibtisam.tariq@emumba.com>", "References": "<20201124123249.14451-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: stephen@networkplumber.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv3:\n* Remove str_is function.\n\nv2:\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n\nv1:\n* enhance getopt_long usage.\n---\n examples/qos_sched/args.c | 149 +++++++++++++++++++++-----------------\n 1 file changed, 83 insertions(+), 66 deletions(-)", "diff": "diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c\nindex c369ba9b4..10ca7bea6 100644\n--- a/examples/qos_sched/args.c\n+++ b/examples/qos_sched/args.c\n@@ -81,10 +81,6 @@ app_usage(const char *prgname)\n \t\t);\n }\n \n-static inline int str_is(const char *str, const char *is)\n-{\n-\treturn strcmp(str, is) == 0;\n-}\n \n /* returns core mask used by DPDK */\n static uint64_t\n@@ -297,6 +293,25 @@ app_parse_burst_conf(const char *conf_str)\n \treturn 0;\n }\n \n+enum {\n+#define OPT_PFC \"pfc\"\n+\tOPT_PFC_NUM = 256,\n+#define OPT_MNC \"mnc\"\n+\tOPT_MNC_NUM,\n+#define OPT_RSZ \"rsz\"\n+\tOPT_RSZ_NUM,\n+#define OPT_BSZ \"bsz\"\n+\tOPT_BSZ_NUM,\n+#define OPT_MSZ \"msz\"\n+\tOPT_MSZ_NUM,\n+#define OPT_RTH \"rth\"\n+\tOPT_RTH_NUM,\n+#define OPT_TTH \"tth\"\n+\tOPT_TTH_NUM,\n+#define OPT_CFG \"cfg\"\n+\tOPT_CFG_NUM,\n+};\n+\n /*\n * Parses the argument given in the command line of the application,\n * calculates mask for used cores and initializes EAL with calculated core mask\n@@ -306,20 +321,19 @@ app_parse_args(int argc, char **argv)\n {\n \tint opt, ret;\n \tint option_index;\n-\tconst char *optname;\n \tchar *prgname = argv[0];\n \tuint32_t i, nb_lcores;\n \n \tstatic struct option lgopts[] = {\n-\t\t{ \"pfc\", 1, 0, 0 },\n-\t\t{ \"mnc\", 1, 0, 0 },\n-\t\t{ \"rsz\", 1, 0, 0 },\n-\t\t{ \"bsz\", 1, 0, 0 },\n-\t\t{ \"msz\", 1, 0, 0 },\n-\t\t{ \"rth\", 1, 0, 0 },\n-\t\t{ \"tth\", 1, 0, 0 },\n-\t\t{ \"cfg\", 1, 0, 0 },\n-\t\t{ NULL, 0, 0, 0 }\n+\t\t{OPT_PFC, 1, NULL, OPT_PFC_NUM},\n+\t\t{OPT_MNC, 1, NULL, OPT_MNC_NUM},\n+\t\t{OPT_RSZ, 1, NULL, OPT_RSZ_NUM},\n+\t\t{OPT_BSZ, 1, NULL, OPT_BSZ_NUM},\n+\t\t{OPT_MSZ, 1, NULL, OPT_MSZ_NUM},\n+\t\t{OPT_RTH, 1, NULL, OPT_RTH_NUM},\n+\t\t{OPT_TTH, 1, NULL, OPT_TTH_NUM},\n+\t\t{OPT_CFG, 1, NULL, OPT_CFG_NUM},\n+\t\t{NULL, 0, 0, 0 }\n \t};\n \n \t/* initialize EAL first */\n@@ -342,66 +356,69 @@ app_parse_args(int argc, char **argv)\n \t\t\t\tinteractive = 1;\n \t\t\t\tbreak;\n \t\t\t/* long options */\n-\t\t\tcase 0:\n-\t\t\t\toptname = lgopts[option_index].name;\n-\t\t\t\tif (str_is(optname, \"pfc\")) {\n-\t\t\t\t\tret = app_parse_flow_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid pipe configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"mnc\")) {\n-\t\t\t\t\tapp_main_core = (uint32_t)atoi(optarg);\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"rsz\")) {\n-\t\t\t\t\tret = app_parse_ring_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid ring configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_PFC_NUM:\n+\t\t\t\tret = app_parse_flow_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid pipe configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"bsz\")) {\n-\t\t\t\t\tret = app_parse_burst_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid burst configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_MNC_NUM:\n+\t\t\t\tapp_main_core = (uint32_t)atoi(optarg);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_RSZ_NUM:\n+\t\t\t\tret = app_parse_ring_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid ring configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"msz\")) {\n-\t\t\t\t\tmp_size = atoi(optarg);\n-\t\t\t\t\tif (mp_size <= 0) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid mempool size %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_BSZ_NUM:\n+\t\t\t\tret = app_parse_burst_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid burst configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"rth\")) {\n-\t\t\t\t\tret = app_parse_rth_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid RX threshold configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_MSZ_NUM:\n+\t\t\t\tmp_size = atoi(optarg);\n+\t\t\t\tif (mp_size <= 0) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid mempool size %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"tth\")) {\n-\t\t\t\t\tret = app_parse_tth_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid TX threshold configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_RTH_NUM:\n+\t\t\t\tret = app_parse_rth_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid RX threshold configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"cfg\")) {\n-\t\t\t\t\tcfg_profile = optarg;\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_TTH_NUM:\n+\t\t\t\tret = app_parse_tth_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid TX threshold configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tbreak;\n \n+\t\t\tcase OPT_CFG_NUM:\n+\t\t\t\tcfg_profile = optarg;\n+\t\t\t\tbreak;\n+\n \t\t\tdefault:\n \t\t\t\tapp_usage(prgname);\n \t\t\t\treturn -1;\n", "prefixes": [ "5/7" ] }