Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84357/?format=api
http://patches.dpdk.org/api/patches/84357/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201119094401.1322-1-julien.massonneau@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201119094401.1322-1-julien.massonneau@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201119094401.1322-1-julien.massonneau@6wind.com", "date": "2020-11-19T09:44:01", "name": "usertools: fix parsing error from dpdk-pmdinfo.py", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "33ed187afd80f93ec6820391f9e8850a027819dc", "submitter": { "id": 2050, "url": "http://patches.dpdk.org/api/people/2050/?format=api", "name": "Julien Massonneau", "email": "julien.massonneau@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201119094401.1322-1-julien.massonneau@6wind.com/mbox/", "series": [ { "id": 13972, "url": "http://patches.dpdk.org/api/series/13972/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13972", "date": "2020-11-19T09:44:01", "name": "usertools: fix parsing error from dpdk-pmdinfo.py", "version": 1, "mbox": "http://patches.dpdk.org/series/13972/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84357/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/84357/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3425BA04DD;\n\tThu, 19 Nov 2020 10:44:08 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0CCDA5937;\n\tThu, 19 Nov 2020 10:44:07 +0100 (CET)", "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 152F8DED;\n Thu, 19 Nov 2020 10:44:05 +0100 (CET)", "from ubuntu2004.vm.6wind.com (unknown [10.16.0.145])\n by proxy.6wind.com (Postfix) with ESMTP id C4FF248F93A;\n Thu, 19 Nov 2020 10:44:03 +0100 (CET)" ], "From": "Julien Massonneau <julien.massonneau@6wind.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 19 Nov 2020 10:44:01 +0100", "Message-Id": "<20201119094401.1322-1-julien.massonneau@6wind.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] usertools: fix parsing error from dpdk-pmdinfo.py", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In the display_pmd_info_strings function, the script parses the section\nuntil to find a byte between 32 and 127, and get all data\nuntil a byte equals to 0.\nAfter, it searches \"PMD_INFO_STRING\" in the data and passes the whole\nstring in the parse_pmd_info_string function, which split the string\nwith \"=\" and convert it in python dict with json.loads().\n\nBut the string may contain a \"=\" before \"PMD_INFO_STRING\",\nso it is not correctly split and will lead to an error\n(json.decoder.JSONDecodeError).\n\nExample of a string encountered that leads to an error:\n\n\"Ag%=C£°ÐÊ+Ë®{0´wË-£0òjB·;¾¬úPMD_INFO_STRING= {\"name\" :\n\"net_octeontx\", \"params\" : \"nr_port=<int> \", \"pci_ids\" : []}\"\n\nFixes: c67c9a5c646a (\"tools: query binaries for HW and other support information\")\nCc: stable@dpdk.org\n\nSigned-off-by: Julien Massonneau <julien.massonneau@6wind.com>\n---\n usertools/dpdk-pmdinfo.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py\nindex 95fb0111d..263465086 100755\n--- a/usertools/dpdk-pmdinfo.py\n+++ b/usertools/dpdk-pmdinfo.py\n@@ -349,7 +349,7 @@ def display_pmd_info_strings(self, section_spec):\n mystring = force_unicode(data[dataptr:endptr])\n rc = mystring.find(\"PMD_INFO_STRING\")\n if (rc != -1):\n- self.parse_pmd_info_string(mystring)\n+ self.parse_pmd_info_string(mystring[rc:])\n \n dataptr = endptr\n \n", "prefixes": [] }{ "id": 84357, "url": "