Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84209/?format=api
{ "id": 84209, "url": "http://patches.dpdk.org/api/patches/84209/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com", "date": "2020-11-16T07:55:18", "name": "[5/5] net/softnic: update headers size calculation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dd23ce89f796466f95b83941676229363c5c1a56", "submitter": { "id": 1065, "url": "http://patches.dpdk.org/api/people/1065/?format=api", "name": "Xiaoyu Min", "email": "jackmin@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com/mbox/", "series": [ { "id": 13896, "url": "http://patches.dpdk.org/api/series/13896/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13896", "date": "2020-11-16T07:55:13", "name": "fix protocol size calculation", "version": 1, "mbox": "http://patches.dpdk.org/series/13896/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84209/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/84209/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2E7ECA04DB;\n\tMon, 16 Nov 2020 08:56:59 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EB754C90A;\n\tMon, 16 Nov 2020 08:55:45 +0100 (CET)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id 3D445C8FE\n for <dev@dpdk.org>; Mon, 16 Nov 2020 08:55:43 +0100 (CET)" ], "From": "Xiaoyu Min <jackmin@mellanox.com>", "To": "Jasvinder Singh <jasvinder.singh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Cc": "dev@dpdk.org,\n\tDekel Peled <dekelp@nvidia.com>", "Date": "Mon, 16 Nov 2020 15:55:18 +0800", "Message-Id": "\n <0bbc7b578dc8ad9348e802e2553de977805f80db.1605493464.git.jackmin@nvidia.com>", "X-Mailer": "git-send-email 2.24.0.rc0.3.g12a4aeaad8", "In-Reply-To": "<cover.1605493464.git.jackmin@nvidia.com>", "References": "<cover.1605493464.git.jackmin@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/5] net/softnic: update headers size calculation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dekel Peled <dekelp@nvidia.com>\n\nThe rte_flow_item_eth and rte_flow_item_vlan items were updated in [1].\nThe rte_flow_item_ipv6 item was updated in [2].\nThe structs now contain additional metadata following the header data.\nThe size to use for match should be the header data size only, and\nnot the size of the whole struct.\n\nThis patch replaces the rte_flow_item_* with the corresponding rte_*_hdr.\n\n[1]:commit 09315fc83861 (\"ethdev: add VLAN attributes to ethernet and VLAN\nitems\")\n\n[2]: commit ad976bd40d28 (\"ethdev: add extensions attributes to IPv6 item\")\n\nSigned-off-by: Dekel Peled <dekelp@nvidia.com>\n---\n drivers/net/softnic/rte_eth_softnic_flow.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_flow.c b/drivers/net/softnic/rte_eth_softnic_flow.c\nindex f05ff092fa..7925bad1c0 100644\n--- a/drivers/net/softnic/rte_eth_softnic_flow.c\n+++ b/drivers/net/softnic/rte_eth_softnic_flow.c\n@@ -169,22 +169,22 @@ flow_item_is_proto(enum rte_flow_item_type type,\n \n \tcase RTE_FLOW_ITEM_TYPE_ETH:\n \t\t*mask = &rte_flow_item_eth_mask;\n-\t\t*size = sizeof(struct rte_flow_item_eth);\n+\t\t*size = sizeof(struct rte_ether_hdr);\n \t\treturn 1; /* TRUE */\n \n \tcase RTE_FLOW_ITEM_TYPE_VLAN:\n \t\t*mask = &rte_flow_item_vlan_mask;\n-\t\t*size = sizeof(struct rte_flow_item_vlan);\n+\t\t*size = sizeof(struct rte_vlan_hdr);\n \t\treturn 1;\n \n \tcase RTE_FLOW_ITEM_TYPE_IPV4:\n \t\t*mask = &rte_flow_item_ipv4_mask;\n-\t\t*size = sizeof(struct rte_flow_item_ipv4);\n+\t\t*size = sizeof(struct rte_ipv4_hdr);\n \t\treturn 1;\n \n \tcase RTE_FLOW_ITEM_TYPE_IPV6:\n \t\t*mask = &rte_flow_item_ipv6_mask;\n-\t\t*size = sizeof(struct rte_flow_item_ipv6);\n+\t\t*size = sizeof(struct rte_ipv6_hdr);\n \t\treturn 1;\n \n \tcase RTE_FLOW_ITEM_TYPE_ICMP:\n", "prefixes": [ "5/5" ] }