Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84068/?format=api
{ "id": 84068, "url": "http://patches.dpdk.org/api/patches/84068/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201112163134.1893190-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201112163134.1893190-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201112163134.1893190-1-bruce.richardson@intel.com", "date": "2020-11-12T16:31:34", "name": "[RFC] build: allow passing extra config header to build", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "611cb3374e8a56f85dd485eb9df5a7275bb2dc9c", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201112163134.1893190-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 13848, "url": "http://patches.dpdk.org/api/series/13848/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13848", "date": "2020-11-12T16:31:34", "name": "[RFC] build: allow passing extra config header to build", "version": 1, "mbox": "http://patches.dpdk.org/series/13848/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84068/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84068/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36139A09D3;\n\tThu, 12 Nov 2020 17:32:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4C30156A3;\n\tThu, 12 Nov 2020 17:32:11 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 37FB256A3\n for <dev@dpdk.org>; Thu, 12 Nov 2020 17:32:08 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Nov 2020 08:31:48 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by fmsmga005.fm.intel.com with ESMTP; 12 Nov 2020 08:31:46 -0800" ], "IronPort-SDR": [ "\n 2uCYJaqnLYXhm7WqABojfDFRvrqpRvEbLZlc5rECSU+HefA4ahtUMDHNu/GDNodf+ABqG0lnVc\n oBn/3Xi4rLPA==", "\n U4ILxxZZ9eVfFVg0/CBbwsql4VkS/oMJi67W9ttTBlpurSoSKtUjC9SWRiwICSPC0ltmv99ICC\n vTXiyw/A819A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9803\"; a=\"149608846\"", "E=Sophos;i=\"5.77,472,1596524400\"; d=\"scan'208\";a=\"149608846\"", "E=Sophos;i=\"5.77,472,1596524400\"; d=\"scan'208\";a=\"532228513\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 12 Nov 2020 16:31:34 +0000", "Message-Id": "<20201112163134.1893190-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH] build: allow passing extra config header to\n\tbuild", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To allow per-build override of some settings, without having to change\nDPDK source-code files, i.e. rte_config.h, we can add an option to allow\nthe user to pass in a file containing their own defines for the build.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nThis is just a quick RFC to show what might be possible and to help keep the\ndiscussion going on how to improve build config in DPDK!\n---\n config/meson.build | 10 ++++++++++\n config/rte_config.h | 4 ++++\n meson_options.txt | 2 ++\n 3 files changed, 16 insertions(+)\n\n--\n2.25.1", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 258b01d06..5c137e4f5 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -14,6 +14,16 @@ foreach env:supported_exec_envs\n \tset_variable('is_' + env, exec_env == env)\n endforeach\n\n+if get_option('extra_config') != ''\n+\textra_config = files(get_option('extra_config'))\n+\tconfigure_file(copy: true,\n+\t\t\tinput: extra_config,\n+\t\t\toutput: 'rte_build_config_extra.h',\n+\t\t\tinstall_dir: join_paths(get_option('includedir'),\n+\t\t\t\tget_option('include_subdir_arch')))\n+\tdpdk_conf.set('RTE_BUILD_CONFIG_EXTRA', 1)\n+endif\n+\n # MS linker requires special treatment.\n # TODO: use cc.get_linker_id() with Meson >= 0.54\n is_ms_linker = is_windows and (cc.get_id() == 'clang')\ndiff --git a/config/rte_config.h b/config/rte_config.h\nindex 25219f04a..2f5ecf999 100644\n--- a/config/rte_config.h\n+++ b/config/rte_config.h\n@@ -148,4 +148,8 @@\n #define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32\n #define RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256\n\n+#ifdef RTE_BUILD_CONFIG_EXTRA\n+#include <rte_build_config_extra.h>\n+#endif\n+\n #endif /* _RTE_CONFIG_H_ */\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9bf18ab6b..91319b0e4 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -2,6 +2,8 @@\n\n option('armv8_crypto_dir', type: 'string', value: '',\n \tdescription: 'path to the armv8_crypto library installation directory')\n+option('extra_config', type: 'string', value: '',\n+\tdescription: 'path to a header file with extra build defines. Will be installed as rte_build_config_extra.h')\n option('disable_drivers', type: 'string', value: '',\n \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n", "prefixes": [ "RFC" ] }