Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84056/?format=api
{ "id": 84056, "url": "http://patches.dpdk.org/api/patches/84056/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201112104245.91324-1-kumar.amber@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201112104245.91324-1-kumar.amber@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201112104245.91324-1-kumar.amber@intel.com", "date": "2020-11-12T10:42:45", "name": "[v4] net/i40e: fix argument in RSS action", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "25a95b7b5c8d97b48256f818f281ac9be1e96271", "submitter": { "id": 1516, "url": "http://patches.dpdk.org/api/people/1516/?format=api", "name": "Amber, Kumar", "email": "kumar.amber@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201112104245.91324-1-kumar.amber@intel.com/mbox/", "series": [ { "id": 13838, "url": "http://patches.dpdk.org/api/series/13838/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13838", "date": "2020-11-12T10:42:45", "name": "[v4] net/i40e: fix argument in RSS action", "version": 4, "mbox": "http://patches.dpdk.org/series/13838/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84056/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84056/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 05DCEA09D3;\n\tThu, 12 Nov 2020 11:48:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DC44D5AB3;\n\tThu, 12 Nov 2020 11:48:22 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id 333225928\n for <dev@dpdk.org>; Thu, 12 Nov 2020 11:48:20 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Nov 2020 02:48:18 -0800", "from unknown (HELO localhost.localdomain) ([10.190.212.185])\n by orsmga008.jf.intel.com with ESMTP; 12 Nov 2020 02:48:16 -0800" ], "IronPort-SDR": [ "\n BqNcz17ihg8uYjjlYo6H3iJZrV8FQwxbe7oLBdnTZhMlknWwJZTsnjPZ7YMu6Q148XdSlQVWHu\n XQyfCkbsSYpA==", "\n ex25b5QPf71GIpMBwUq/pF8Iw6jMmdPZnGhyAq1cDi4hd1RtdT+OcDprM2M3J+b9QmILNuzCEM\n lfUIQAexEuBw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9802\"; a=\"254997993\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"254997993\"", "E=Sophos;i=\"5.77,471,1596524400\"; d=\"scan'208\";a=\"355155944\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Kumar Amber <kumar.amber@intel.com>", "To": "dev@dpdk.org", "Cc": "wei.zhao1@intel.com", "Date": "Thu, 12 Nov 2020 16:12:45 +0530", "Message-Id": "<20201112104245.91324-1-kumar.amber@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201111101031.52758-1-kumar.amber@intel.com>", "References": "<20201111101031.52758-1-kumar.amber@intel.com>", "Subject": "[dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The driver must check for the queue number\nin the RSS action list and if not should\nreturn with a proper error message to user.\n\nBugzilla ID: 573\nFixes: 9486d60b94b5 (\"net/i40e: fix flow RSS queue index check\")\nCc: wei.zhao1@intel.com\n\nSigned-off-by: Kumar Amber <kumar.amber@intel.com>\n---\n drivers/net/i40e/i40e_flow.c | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c\nindex 5bec0c7a84..397ed0ae77 100644\n--- a/drivers/net/i40e/i40e_flow.c\n+++ b/drivers/net/i40e/i40e_flow.c\n@@ -4917,6 +4917,18 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,\n \tNEXT_ITEM_OF_ACTION(act, actions, index);\n \trss = act->conf;\n \n+\t/**\n+\t * Check if Queue number is specified\n+\t * in argument else throw an error.\n+\t */\n+\tif (!rss->queue || !rss->queue_num) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact,\n+\t\t\t \"no valid queues\");\n+\t\treturn -rte_errno;\n+\t}\n+\n \t/**\n \t * RSS only supports forwarding,\n \t * check if the first not void action is RSS.\n", "prefixes": [ "v4" ] }