Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84023/?format=api
{ "id": 84023, "url": "http://patches.dpdk.org/api/patches/84023/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111153933.1951384-1-conor.walsh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111153933.1951384-1-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111153933.1951384-1-conor.walsh@intel.com", "date": "2020-11-11T15:39:33", "name": "[v2] net/txgbe: return changed to fix gcc compile error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "14bfe13174575e44f977ade0b22b908384cd9591", "submitter": { "id": 1935, "url": "http://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111153933.1951384-1-conor.walsh@intel.com/mbox/", "series": [ { "id": 13813, "url": "http://patches.dpdk.org/api/series/13813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13813", "date": "2020-11-11T15:39:33", "name": "[v2] net/txgbe: return changed to fix gcc compile error", "version": 2, "mbox": "http://patches.dpdk.org/series/13813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84023/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A919A09D9;\n\tWed, 11 Nov 2020 16:39:43 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2C4C7F90;\n\tWed, 11 Nov 2020 16:39:41 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 3C6D7F64\n for <dev@dpdk.org>; Wed, 11 Nov 2020 16:39:37 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 07:39:36 -0800", "from silpixa00400466.ir.intel.com ([10.237.213.98])\n by fmsmga006.fm.intel.com with ESMTP; 11 Nov 2020 07:39:35 -0800" ], "IronPort-SDR": [ "\n QkPT9mVohbKOvUcoHLX7EYP/Q39UgONS9GxIryq6ttfos80j8j80yBbtCTmYp1DLfWIZ7Cb8f4\n YRKkUejwqwYg==", "\n pizoxI1tCwX4U8cuffDuhTTdxhhLuKiR3TZZfRAbEmYO5Z+cQM0rJYv6nqwb58UaFZnk0sSpzf\n Yhtqo1bh/p1A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9801\"; a=\"167579655\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"167579655\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"530248340\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "jiawenwu@trustnetic.com,\n\tjianwang@trustnetic.com", "Cc": "dev@dpdk.org, linglix.chen@intel.com, Conor Walsh <conor.walsh@intel.com>", "Date": "Wed, 11 Nov 2020 15:39:33 +0000", "Message-Id": "<20201111153933.1951384-1-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201111130542.1949894-1-conor.walsh@intel.com>", "References": "<20201111130542.1949894-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/txgbe: return changed to fix gcc compile\n\terror", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When DPDK is compiled with gcc 7.5 with the optimization level set to 1\ngcc sees the offset variable in txgbe_ethdev.c as possibly being\nuninitialised. To correct this the final return statement in\ntxgbe_get_offset_by_id was simplified to return -1.\n\nSigned-off-by: Conor Walsh <conor.walsh@intel.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 9f533603a1..f8dffe1f12 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -2140,9 +2140,8 @@ txgbe_get_offset_by_id(uint32_t id, uint32_t *offset)\n \t\t\tnb * (TXGBE_NB_QP_STATS * sizeof(uint64_t));\n \t\treturn 0;\n \t}\n-\tid -= TXGBE_NB_QP_STATS * TXGBE_MAX_QP;\n \n-\treturn -(int)(id + 1);\n+\treturn -1;\n }\n \n static int txgbe_dev_xstats_get_names(struct rte_eth_dev *dev,\n", "prefixes": [ "v2" ] }