Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/84000/?format=api
http://patches.dpdk.org/api/patches/84000/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1605086930-189770-1-git-send-email-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605086930-189770-1-git-send-email-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1605086930-189770-1-git-send-email-bingz@nvidia.com", "date": "2020-11-11T09:28:50", "name": "[v2] net/mlx5: fix eCPRI previous layer checking", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae87d9c17be5bc3e121da806dfb7fd534e4dc1cb", "submitter": { "id": 1976, "url": "http://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1605086930-189770-1-git-send-email-bingz@nvidia.com/mbox/", "series": [ { "id": 13804, "url": "http://patches.dpdk.org/api/series/13804/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13804", "date": "2020-11-11T09:28:50", "name": "[v2] net/mlx5: fix eCPRI previous layer checking", "version": 2, "mbox": "http://patches.dpdk.org/series/13804/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/84000/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/84000/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E0455A09D2;\n\tWed, 11 Nov 2020 10:29:03 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E2F012C36;\n\tWed, 11 Nov 2020 10:29:00 +0100 (CET)", "from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130])\n by dpdk.org (Postfix) with ESMTP id E32DB2AB;\n Wed, 11 Nov 2020 10:28:58 +0100 (CET)" ], "From": "Bing Zhao <bingz@nvidia.com>", "To": "viacheslavo@nvidia.com,\n\tmatan@nvidia.com,\n\tferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\torika@nvidia.com,\n\trasland@nvidia.com,\n\tstable@dpdk.org", "Date": "Wed, 11 Nov 2020 17:28:50 +0800", "Message-Id": "<1605086930-189770-1-git-send-email-bingz@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1604382154-336373-1-git-send-email-bingz@nvidia.com>", "References": "<1604382154-336373-1-git-send-email-bingz@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2] net/mlx5: fix eCPRI previous layer checking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Based on the specification, eCPRI can only follow ETH (VLAN) layer\nor UDP layer. When creating a flow with eCPRI item, this should be\nchecked and invalid layout of the layers should be rejected.\n\nFixes: c7eca23657b7 (\"net/mlx5: add flow validation of eCPRI header\")\n\nCc: stable@dpdk.org\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\nv2: remove the line break for error log message.\n---\n drivers/net/mlx5/mlx5_flow.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex a6e60af..859b7f6 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -2896,17 +2896,20 @@ struct mlx5_flow_tunnel_info {\n \t\t\t\t\tMLX5_FLOW_LAYER_OUTER_VLAN);\n \tstruct rte_flow_item_ecpri mask_lo;\n \n+\tif (!(last_item & outer_l2_vlan) &&\n+\t last_item != MLX5_FLOW_LAYER_OUTER_L4_UDP)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"eCPRI can only follow L2/VLAN layer or UDP layer\");\n \tif ((last_item & outer_l2_vlan) && ether_type &&\n \t ether_type != RTE_ETHER_TYPE_ECPRI)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\t \"eCPRI cannot follow L2/VLAN layer \"\n-\t\t\t\t\t \"which ether type is not 0xAEFE.\");\n+\t\t\t\t\t \"eCPRI cannot follow L2/VLAN layer which ether type is not 0xAEFE\");\n \tif (item_flags & MLX5_FLOW_LAYER_TUNNEL)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\t \"eCPRI with tunnel is not supported \"\n-\t\t\t\t\t \"right now.\");\n+\t\t\t\t\t \"eCPRI with tunnel is not supported right now\");\n \tif (item_flags & MLX5_FLOW_LAYER_OUTER_L3)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n@@ -2914,13 +2917,12 @@ struct mlx5_flow_tunnel_info {\n \telse if (item_flags & MLX5_FLOW_LAYER_OUTER_L4_TCP)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\t \"eCPRI cannot follow a TCP layer.\");\n+\t\t\t\t\t \"eCPRI cannot coexist with a TCP layer\");\n \t/* In specification, eCPRI could be over UDP layer. */\n \telse if (item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n-\t\t\t\t\t \"eCPRI over UDP layer is not yet \"\n-\t\t\t\t\t \"supported right now.\");\n+\t\t\t\t\t \"eCPRI over UDP layer is not yet supported right now\");\n \t/* Mask for type field in common header could be zero. */\n \tif (!mask)\n \t\tmask = &rte_flow_item_ecpri_mask;\n@@ -2929,13 +2931,11 @@ struct mlx5_flow_tunnel_info {\n \tif (mask_lo.hdr.common.type != 0 && mask_lo.hdr.common.type != 0xff)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_MASK, mask,\n-\t\t\t\t\t \"partial mask is not supported \"\n-\t\t\t\t\t \"for protocol\");\n+\t\t\t\t\t \"partial mask is not supported for protocol\");\n \telse if (mask_lo.hdr.common.type == 0 && mask->hdr.dummy[0] != 0)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_MASK, mask,\n-\t\t\t\t\t \"message header mask must be after \"\n-\t\t\t\t\t \"a type mask\");\n+\t\t\t\t\t \"message header mask must be after a type mask\");\n \treturn mlx5_flow_item_acceptable(item, (const uint8_t *)mask,\n \t\t\t\t\t acc_mask ? (const uint8_t *)acc_mask\n \t\t\t\t\t\t : (const uint8_t *)&nic_mask,\n", "prefixes": [ "v2" ] }{ "id": 84000, "url": "