Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83999/?format=api
{ "id": 83999, "url": "http://patches.dpdk.org/api/patches/83999/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111090806.43478-1-Cheng1.jiang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111090806.43478-1-Cheng1.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111090806.43478-1-Cheng1.jiang@intel.com", "date": "2020-11-11T09:08:06", "name": "[v2] examples/vhost: fix string split error handling issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "23d41ace44e83a3b51ef68081b8d8588e8f2f1a9", "submitter": { "id": 1530, "url": "http://patches.dpdk.org/api/people/1530/?format=api", "name": "Jiang, Cheng1", "email": "Cheng1.jiang@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111090806.43478-1-Cheng1.jiang@intel.com/mbox/", "series": [ { "id": 13803, "url": "http://patches.dpdk.org/api/series/13803/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13803", "date": "2020-11-11T09:08:06", "name": "[v2] examples/vhost: fix string split error handling issue", "version": 2, "mbox": "http://patches.dpdk.org/series/13803/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83999/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83999/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F1A7A09D2;\n\tWed, 11 Nov 2020 10:17:09 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D3EF5F90;\n\tWed, 11 Nov 2020 10:17:06 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 09F2DDED\n for <dev@dpdk.org>; Wed, 11 Nov 2020 10:17:04 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 01:16:58 -0800", "from dpdk_jiangcheng.sh.intel.com ([10.67.119.112])\n by fmsmga004.fm.intel.com with ESMTP; 11 Nov 2020 01:16:56 -0800" ], "IronPort-SDR": [ "\n hDkci4FrOYEgk7FozffJ0bSvdaCXx/cFvWr+Pgfv/eNJg0FjWeil+uC28x4SRhk2lEcXqA8kif\n 6d1WYH51nuPg==", "\n UT13kjU0Svpz5jJCPdUkvL/wYyyzq6H3igr6eb+6aXD/afEKML7bqmg4efOA2NGn5U6PLn/p0R\n 2PreXYqRD/tA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9801\"; a=\"149393815\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"149393815\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"356560312\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Cheng Jiang <Cheng1.jiang@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, patrick.fu@intel.com, YvonneX.Yang@intel.com,\n Cheng Jiang <Cheng1.jiang@intel.com>", "Date": "Wed, 11 Nov 2020 09:08:06 +0000", "Message-Id": "<20201111090806.43478-1-Cheng1.jiang@intel.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201106032343.9099-1-Cheng1.jiang@intel.com>", "References": "<20201106032343.9099-1-Cheng1.jiang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] examples/vhost: fix string split error\n\thandling issue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add checking return value of string split function to fix the\ncoverity issue.\n\nFixes: 3a04ecb21420 (\"examples/vhost: add async vhost args parsing\")\nCoverity issue: 363739\n\nSigned-off-by: Cheng Jiang <Cheng1.jiang@intel.com>\n---\nv2: checked args_nr explicitly\n\n examples/vhost/ioat.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)\n\n--\n2.29.2", "diff": "diff --git a/examples/vhost/ioat.c b/examples/vhost/ioat.c\nindex b2c74f6537..720c0b0b81 100644\n--- a/examples/vhost/ioat.c\n+++ b/examples/vhost/ioat.c\n@@ -36,7 +36,7 @@ open_ioat(const char *value)\n \tint ret = 0;\n \tuint16_t i = 0;\n \tchar *dma_arg[MAX_VHOST_DEVICE];\n-\tuint8_t args_nr;\n+\tint args_nr;\n\n \twhile (isblank(*addrs))\n \t\taddrs++;\n@@ -54,9 +54,18 @@ open_ioat(const char *value)\n \t}\n \targs_nr = rte_strsplit(substr, strlen(substr),\n \t\t\tdma_arg, MAX_VHOST_DEVICE, ',');\n-\tdo {\n+\tif (args_nr <= 0) {\n+\t\tret = -1;\n+\t\tgoto out;\n+\t}\n+\twhile (i < args_nr) {\n \t\tchar *arg_temp = dma_arg[i];\n-\t\trte_strsplit(arg_temp, strlen(arg_temp), ptrs, 2, '@');\n+\t\tuint8_t sub_nr;\n+\t\tsub_nr = rte_strsplit(arg_temp, strlen(arg_temp), ptrs, 2, '@');\n+\t\tif (sub_nr != 2) {\n+\t\t\tret = -1;\n+\t\t\tgoto out;\n+\t\t}\n\n \t\tstart = strstr(ptrs[0], \"txd\");\n \t\tif (start == NULL) {\n@@ -105,7 +114,7 @@ open_ioat(const char *value)\n\n \t\tdma_info->nr++;\n \t\ti++;\n-\t} while (i < args_nr);\n+\t}\n out:\n \tfree(input);\n \treturn ret;\n", "prefixes": [ "v2" ] }