Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83998/?format=api
{ "id": 83998, "url": "http://patches.dpdk.org/api/patches/83998/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111091112.12606-1-murphyx.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111091112.12606-1-murphyx.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111091112.12606-1-murphyx.yang@intel.com", "date": "2020-11-11T09:11:12", "name": "net/i40e: fix incorrect checksum flag of L4 checksum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d1af0a55d05fd918384d92cde2273810c065b1e4", "submitter": { "id": 1986, "url": "http://patches.dpdk.org/api/people/1986/?format=api", "name": "Murphy Yang", "email": "murphyx.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111091112.12606-1-murphyx.yang@intel.com/mbox/", "series": [ { "id": 13802, "url": "http://patches.dpdk.org/api/series/13802/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13802", "date": "2020-11-11T09:11:12", "name": "net/i40e: fix incorrect checksum flag of L4 checksum", "version": 1, "mbox": "http://patches.dpdk.org/series/13802/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83998/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83998/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F0659A09D2;\n\tWed, 11 Nov 2020 10:13:25 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 59E32F90;\n\tWed, 11 Nov 2020 10:13:24 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 85661DED\n for <dev@dpdk.org>; Wed, 11 Nov 2020 10:13:22 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 01:13:13 -0800", "from unknown (HELO intel-npg-odc-srv02.cd.intel.com)\n ([10.240.178.186])\n by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Nov 2020 01:13:09 -0800" ], "IronPort-SDR": [ "\n tglSrK1JhtdK9bExTslQ7QQrCP0c1gdokt+O9KurpXBLIwyqmdMWPHxbHpYkErxSUq4rPj0b38\n huqX3RZBofeQ==", "\n BUpR5cRcBj2UjagyaaCmW9DBFNcQeeHJbCKTlNJseDtGTlphXZcAui8tIPQRouG+j8H+KYmNrE\n lhOA6GV00OQw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9801\"; a=\"231743580\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"231743580\"", "E=Sophos;i=\"5.77,469,1596524400\"; d=\"scan'208\";a=\"541708557\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "From": "Murphy Yang <murphyx.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, stevex.yang@intel.com, beilei.xing@intel.com,\n jia.guo@intel.com, Murphy Yang <murphyx.yang@intel.com>", "Date": "Wed, 11 Nov 2020 09:11:12 +0000", "Message-Id": "<20201111091112.12606-1-murphyx.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/i40e: fix incorrect checksum flag of L4\n\tchecksum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When send tunneled packet that inner L4 checksum value is correct,\nthe test_pmd output log shows 'ol_flags' value is\n'PKT_RX_L4_CKSUM_UNKNOWN', but expected value is\n'PKT_RX_L4_CKSUM_GOOD'.\n\nAdd the 'PKT_RX_L4_CKSUM_GOOD' to 'l3_l4e_flags' for sse and\n'l3_l4_flags_shuf' for avx2 to ensure that the 'ol_flags' can match\ncorrect flags.\n\nFixes: 9966a00a0688 (\"net/i40e: enable bad checksum flags in vector Rx\")\nFixes: dafadd73762e (\"net/i40e: add AVX2 Rx function\")\n\nSigned-off-by: Murphy Yang <murphyx.yang@intel.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_avx2.c | 40 ++++++++++++++++-----------\n drivers/net/i40e/i40e_rxtx_vec_sse.c | 20 ++++++++------\n 2 files changed, 35 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx2.c b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\nindex 7a558fc73a..fe6ec7deef 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_avx2.c\n@@ -342,24 +342,32 @@ _recv_raw_pkts_vec_avx2(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \t */\n \tconst __m256i l3_l4_flags_shuf = _mm256_set_epi8(0, 0, 0, 0, 0, 0, 0, 0,\n \t\t\t/* shift right 1 bit to make sure it not exceed 255 */\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\tPKT_RX_IP_CKSUM_BAD >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_GOOD) >> 1,\n \t\t\t/* second 128-bits */\n \t\t\t0, 0, 0, 0, 0, 0, 0, 0,\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\tPKT_RX_IP_CKSUM_BAD >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD) >> 1);\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_GOOD) >> 1);\n \n \tconst __m256i cksum_mask = _mm256_set1_epi32(\n \t\t\tPKT_RX_IP_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD |\ndiff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c\nindex 4b2b6a28fc..0bcb48e24e 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_sse.c\n+++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c\n@@ -254,16 +254,18 @@ desc_to_olflags_v(struct i40e_rx_queue *rxq, volatile union i40e_rx_desc *rxdp,\n \n \tconst __m128i l3_l4e_flags = _mm_set_epi8(0, 0, 0, 0, 0, 0, 0, 0,\n \t\t\t/* shift right 1 bit to make sure it not exceed 255 */\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n \t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD |\n-\t\t\t PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_EIP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD) >> 1,\n-\t\t\tPKT_RX_IP_CKSUM_BAD >> 1,\n-\t\t\t(PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD) >> 1);\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_EIP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD |\n+\t\t\t PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_BAD | PKT_RX_IP_CKSUM_GOOD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_BAD) >> 1,\n+\t\t\t(PKT_RX_L4_CKSUM_GOOD | PKT_RX_IP_CKSUM_GOOD) >> 1);\n \n \t/* Unpack \"status\" from quadword 1, bits 0:32 */\n \tvlan0 = _mm_unpackhi_epi32(descs[0], descs[1]);\n", "prefixes": [] }