Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83996/?format=api
{ "id": 83996, "url": "http://patches.dpdk.org/api/patches/83996/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-6-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111081507.19913-6-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111081507.19913-6-ibtisam.tariq@emumba.com", "date": "2020-11-11T08:15:06", "name": "[6/7] examples/vhost: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0d6baad3b1a62bf0cee4770e64f6552450c5c24d", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-6-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 13801, "url": "http://patches.dpdk.org/api/series/13801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13801", "date": "2020-11-11T08:15:01", "name": "[1/7] examples/fips_validation: enhance getopt_long usage", "version": 1, "mbox": "http://patches.dpdk.org/series/13801/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83996/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83996/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77A23A09D2;\n\tWed, 11 Nov 2020 09:17:18 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 997035A8C;\n\tWed, 11 Nov 2020 09:16:01 +0100 (CET)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 6486C5A8C\n for <dev@dpdk.org>; Wed, 11 Nov 2020 09:16:00 +0100 (CET)", "by mail-wr1-f65.google.com with SMTP id o15so1641070wru.6\n for <dev@dpdk.org>; Wed, 11 Nov 2020 00:16:00 -0800 (PST)", "from localhost.localdomain ([39.33.227.210])\n by smtp.gmail.com with ESMTPSA id z3sm909539wrw.87.2020.11.11.00.15.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Nov 2020 00:15:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=SlAv/2Iy/DTPUCpmnrZ3zcXz7WhobArP6u+5jrnsiGw=;\n b=KqqIzrAvs49MKKJwrU4qW77Ga+BxsCq+oVCFzIPfUTyGQ+/Np68bmC6tNkpR3C7JrR\n V9x/1I8BNOriJ3rpKqD6CrIEgYIfRwzBNzmcFlLCNfFwiwSVpuqGLJQlLgvhXTlx41B2\n ynxoqRQE4RhJo8fwOme+hECAyFGCk0FnHa2LkBhKddSpfr9aX2XZU3JY9JPRy+e1M6WU\n tgzc6T8lIY305FvqHJJuCm4EHuDwFccdd/g3LrMoJhWcI7TXRQi2orDljIv997uCr7eN\n g6TMM7DCnrFgdUF5l5nZ+gGr0UzHJ3c6rttjI5AIPQM22gonOAvicBS8BSKRW5gxLNOH\n SF9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=SlAv/2Iy/DTPUCpmnrZ3zcXz7WhobArP6u+5jrnsiGw=;\n b=V3dNbRGLdMnnVEULs1Ia+OULAseY4J2P9byiU3wqB+A2JyuBQeZSGSHkeqMtMuWBKS\n uUEREXOLpjMseN6pRsckMdsD9mH6Poo8aivwR5PvQ8SzHg5bEpGk40NLD8AuG40bYK3k\n vZVVs7WgE5+UNBZRUqVX1PfSRUTLI09fJ1LWvEMOdhE2K92sCETpoaarhIybQPcd3Sja\n gFE8EsF1GBjTOaUb0TS0ADXP2trj9LammTxPypm1TTu1IButkQeJNejC9xKNBFFotWVK\n 8TwrssWwGxZJy9a9I2FtNurm+j+57s2mTqw/nYhByUxp/2XkULtPo7j4/Kd1KIRjAxUR\n 92kQ==", "X-Gm-Message-State": "AOAM5303JoTxKhydCXMvT+F1ncKfJf75GlPmDA84i7x+nDqKt5BFH7Zc\n eZ0B1a+g6umws8ysMKiISUyJvQ==", "X-Google-Smtp-Source": "\n ABdhPJybT7cYLnOHu/aojIao5VoWwoVevHUUU8n7f6pzB5qwge+r55RkwyBzxmw/LXQVFACLX2dYcw==", "X-Received": "by 2002:adf:ce84:: with SMTP id r4mr27042791wrn.281.1605082558987;\n Wed, 11 Nov 2020 00:15:58 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n jiayu.hu@intel.com,\n huawei.xie@intel.com", "Date": "Wed, 11 Nov 2020 08:15:06 +0000", "Message-Id": "<20201111081507.19913-6-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "References": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH 6/7] examples/vhost: enhance getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: jiayu.hu@intel.com\nCc: huawei.xie@intel.com\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv2\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n\nv1\n* enhance getopt_long usage\n---\n examples/vhost/main.c | 273 ++++++++++++++++++++++--------------------\n 1 file changed, 145 insertions(+), 128 deletions(-)", "diff": "diff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex 59a1aff07..c517afe96 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -466,6 +466,33 @@ us_vhost_usage(const char *prgname)\n \t prgname);\n }\n \n+enum {\n+#define OPT_VM2VM \"vm2vm\"\n+\tOPT_VM2VM_NUM = 256,\n+#define OPT_RX_RETRY \"rx-retry\"\n+\tOPT_RX_RETRY_NUM,\n+#define OPT_RX_RETRY_DELAY \"rx-retry-delay\"\n+\tOPT_RX_RETRY_DELAY_NUM,\n+#define OPT_RX_RETRY_NUMB \"rx-retry-num\"\n+\tOPT_RX_RETRY_NUMB_NUM,\n+#define OPT_MERGEABLE \"mergeable\"\n+\tOPT_MERGEABLE_NUM,\n+#define OPT_STATS \"stats\"\n+\tOPT_STATS_NUM,\n+#define OPT_SOCKET_FILE \"socket-file\"\n+\tOPT_SOCKET_FILE_NUM,\n+#define OPT_TX_CSUM \"tx-csum\"\n+\tOPT_TX_CSUM_NUM,\n+#define OPT_TSO \"tso\"\n+\tOPT_TSO_NUM,\n+#define OPT_CLIENT \"client\"\n+#define OPT_BUILTIN_NET_DRIVER \"builtin-net-driver\"\n+#define OPT_DMA_TYPE\t\t\t\"dma-type\"\n+\tOPT_DMA_TYPE_NUM,\n+#define OPT_DMAS\t\t\t\t\"dmas\"\n+\tOPT_DMAS_NUM,\n+};\n+\n /*\n * Parse the arguments given in the command line of the application.\n */\n@@ -477,19 +504,31 @@ us_vhost_parse_args(int argc, char **argv)\n \tunsigned i;\n \tconst char *prgname = argv[0];\n \tstatic struct option long_option[] = {\n-\t\t{\"vm2vm\", required_argument, NULL, 0},\n-\t\t{\"rx-retry\", required_argument, NULL, 0},\n-\t\t{\"rx-retry-delay\", required_argument, NULL, 0},\n-\t\t{\"rx-retry-num\", required_argument, NULL, 0},\n-\t\t{\"mergeable\", required_argument, NULL, 0},\n-\t\t{\"stats\", required_argument, NULL, 0},\n-\t\t{\"socket-file\", required_argument, NULL, 0},\n-\t\t{\"tx-csum\", required_argument, NULL, 0},\n-\t\t{\"tso\", required_argument, NULL, 0},\n-\t\t{\"client\", no_argument, &client_mode, 1},\n-\t\t{\"builtin-net-driver\", no_argument, &builtin_net_driver, 1},\n-\t\t{\"dma-type\", required_argument, NULL, 0},\n-\t\t{\"dmas\", required_argument, NULL, 0},\n+\t\t{OPT_VM2VM, required_argument,\n+\t\t\t\tNULL, OPT_VM2VM_NUM},\n+\t\t{OPT_RX_RETRY, required_argument,\n+\t\t\t\tNULL, OPT_RX_RETRY_NUM},\n+\t\t{OPT_RX_RETRY_DELAY, required_argument,\n+\t\t\t\tNULL, OPT_RX_RETRY_DELAY_NUM},\n+\t\t{OPT_RX_RETRY_NUMB, required_argument,\n+\t\t\t\tNULL, OPT_RX_RETRY_NUMB_NUM},\n+\t\t{OPT_MERGEABLE, required_argument,\n+\t\t\t\tNULL, OPT_MERGEABLE_NUM},\n+\t\t{OPT_STATS, required_argument,\n+\t\t\t\tNULL, OPT_STATS_NUM},\n+\t\t{OPT_SOCKET_FILE, required_argument,\n+\t\t\t\tNULL, OPT_SOCKET_FILE_NUM},\n+\t\t{OPT_TX_CSUM, required_argument,\n+\t\t\t\tNULL, OPT_TX_CSUM_NUM},\n+\t\t{OPT_TSO, required_argument,\n+\t\t\t\tNULL, OPT_TSO_NUM},\n+\t\t{OPT_CLIENT, no_argument, &client_mode, 1},\n+\t\t{OPT_BUILTIN_NET_DRIVER, no_argument,\n+\t\t\t\t&builtin_net_driver, 1},\n+\t\t{OPT_DMA_TYPE, required_argument,\n+\t\t\t\tNULL, OPT_DMA_TYPE_NUM},\n+\t\t{OPT_DMAS, required_argument,\n+\t\t\t\tNULL, OPT_DMAS_NUM},\n \t\t{NULL, 0, 0, 0},\n \t};\n \n@@ -512,145 +551,123 @@ us_vhost_parse_args(int argc, char **argv)\n \t\t\tvmdq_conf_default.rx_adv_conf.vmdq_rx_conf.rx_mode =\n \t\t\t\tETH_VMDQ_ACCEPT_BROADCAST |\n \t\t\t\tETH_VMDQ_ACCEPT_MULTICAST;\n-\n \t\t\tbreak;\n \n-\t\tcase 0:\n-\t\t\t/* Enable/disable vm2vm comms. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"vm2vm\",\n-\t\t\t\tMAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, (VM2VM_LAST - 1));\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n-\t\t\t\t\t\t\"Invalid argument for \"\n-\t\t\t\t\t\t\"vm2vm [0|1|2]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tvm2vm_mode = (vm2vm_type)ret;\n-\t\t\t\t}\n+\t\tcase OPT_VM2VM_NUM:\n+\t\t\tret = parse_num_opt(optarg, (VM2VM_LAST - 1));\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n+\t\t\t\t\t\"Invalid argument for \"\n+\t\t\t\t\t\"vm2vm [0|1|2]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tvm2vm_mode = (vm2vm_type)ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Enable/disable retries on RX. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"rx-retry\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, 1);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry [0|1]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tenable_retry = ret;\n-\t\t\t\t}\n+\t\tcase OPT_RX_RETRY_NUM:\n+\t\t\tret = parse_num_opt(optarg, 1);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry [0|1]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tenable_retry = ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Enable/disable TX checksum offload. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"tx-csum\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, 1);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for tx-csum [0|1]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else\n-\t\t\t\t\tenable_tx_csum = ret;\n+\t\tcase OPT_TX_CSUM_NUM:\n+\t\t\tret = parse_num_opt(optarg, 1);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for tx-csum [0|1]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tenable_tx_csum = ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Enable/disable TSO offload. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"tso\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, 1);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for tso [0|1]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else\n-\t\t\t\t\tenable_tso = ret;\n+\t\tcase OPT_TSO_NUM:\n+\t\t\tret = parse_num_opt(optarg, 1);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for tso [0|1]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tenable_tso = ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Specify the retries delay time (in useconds) on RX. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"rx-retry-delay\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry-delay [0-N]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tburst_rx_delay_time = ret;\n-\t\t\t\t}\n+\t\tcase OPT_RX_RETRY_DELAY_NUM:\n+\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry-delay [0-N]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tburst_rx_delay_time = ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Specify the retries number on RX. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"rx-retry-num\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry-num [0-N]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tburst_rx_retry_num = ret;\n-\t\t\t\t}\n+\t\tcase OPT_RX_RETRY_NUMB_NUM:\n+\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for rx-retry-num [0-N]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tburst_rx_retry_num = ret;\n+\t\t\tbreak;\n \n-\t\t\t/* Enable/disable RX mergeable buffers. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"mergeable\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, 1);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for mergeable [0|1]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tmergeable = !!ret;\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tvmdq_conf_default.rxmode.offloads |=\n-\t\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\t\t\t\tvmdq_conf_default.rxmode.max_rx_pkt_len\n-\t\t\t\t\t\t\t= JUMBO_FRAME_MAX_SIZE;\n-\t\t\t\t\t}\n-\t\t\t\t}\n+\t\tcase OPT_MERGEABLE_NUM:\n+\t\t\tret = parse_num_opt(optarg, 1);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG, \"Invalid argument for mergeable [0|1]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n-\n-\t\t\t/* Enable/disable stats. */\n-\t\t\tif (!strncmp(long_option[option_index].name, \"stats\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n-\t\t\t\tif (ret == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n-\t\t\t\t\t\t\"Invalid argument for stats [0..N]\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t} else {\n-\t\t\t\t\tenable_stats = ret;\n-\t\t\t\t}\n+\t\t\tmergeable = !!ret;\n+\t\t\tif (ret) {\n+\t\t\t\tvmdq_conf_default.rxmode.offloads |=\n+\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t\t\tvmdq_conf_default.rxmode.max_rx_pkt_len\n+\t\t\t\t\t= JUMBO_FRAME_MAX_SIZE;\n \t\t\t}\n+\t\t\tbreak;\n \n-\t\t\t/* Set socket file path. */\n-\t\t\tif (!strncmp(long_option[option_index].name,\n-\t\t\t\t\t\t\"socket-file\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tif (us_vhost_parse_socket_path(optarg) == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n-\t\t\t\t\t\"Invalid argument for socket name (Max %d characters)\\n\",\n-\t\t\t\t\tPATH_MAX);\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n+\t\tcase OPT_STATS_NUM:\n+\t\t\tret = parse_num_opt(optarg, INT32_MAX);\n+\t\t\tif (ret == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n+\t\t\t\t\t\"Invalid argument for stats [0..N]\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tenable_stats = ret;\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(long_option[option_index].name,\n-\t\t\t\t\t\t\"dma-type\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tstrcpy(dma_type, optarg);\n+\t\t/* Set socket file path. */\n+\t\tcase OPT_SOCKET_FILE_NUM:\n+\t\t\tif (us_vhost_parse_socket_path(optarg) == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n+\t\t\t\t\"Invalid argument for socket name (Max %d characters)\\n\",\n+\t\t\t\tPATH_MAX);\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(long_option[option_index].name,\n-\t\t\t\t\t\t\"dmas\", MAX_LONG_OPT_SZ)) {\n-\t\t\t\tif (open_dma(optarg) == -1) {\n-\t\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n-\t\t\t\t\t\t\"Wrong DMA args\\n\");\n-\t\t\t\t\tus_vhost_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n-\t\t\t\tasync_vhost_driver = 1;\n-\t\t\t}\n+\t\tcase OPT_DMA_TYPE_NUM:\n+\t\t\tstrcpy(dma_type, optarg);\n+\t\t\tbreak;\n \n+\t\tcase OPT_DMAS_NUM:\n+\t\t\tif (open_dma(optarg) == -1) {\n+\t\t\t\tRTE_LOG(INFO, VHOST_CONFIG,\n+\t\t\t\t\t\"Wrong DMA args\\n\");\n+\t\t\t\tus_vhost_usage(prgname);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tasync_vhost_driver = 1;\n \t\t\tbreak;\n \n-\t\t\t/* Invalid option - print options. */\n+\t\t/* Invalid option - print options. */\n \t\tdefault:\n \t\t\tus_vhost_usage(prgname);\n \t\t\treturn -1;\n", "prefixes": [ "6/7" ] }