Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83995/?format=api
{ "id": 83995, "url": "http://patches.dpdk.org/api/patches/83995/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-5-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111081507.19913-5-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111081507.19913-5-ibtisam.tariq@emumba.com", "date": "2020-11-11T08:15:05", "name": "[5/7] examples/qos_sched: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea4f015bcb0c1af48463e8b8dcaaa085b3616d7c", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111081507.19913-5-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 13801, "url": "http://patches.dpdk.org/api/series/13801/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13801", "date": "2020-11-11T08:15:01", "name": "[1/7] examples/fips_validation: enhance getopt_long usage", "version": 1, "mbox": "http://patches.dpdk.org/series/13801/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83995/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83995/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C37AFA09D2;\n\tWed, 11 Nov 2020 09:16:55 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 933AF5958;\n\tWed, 11 Nov 2020 09:15:57 +0100 (CET)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 40E2D5953\n for <dev@dpdk.org>; Wed, 11 Nov 2020 09:15:55 +0100 (CET)", "by mail-wr1-f66.google.com with SMTP id 23so1622829wrc.8\n for <dev@dpdk.org>; Wed, 11 Nov 2020 00:15:55 -0800 (PST)", "from localhost.localdomain ([39.33.227.210])\n by smtp.gmail.com with ESMTPSA id z3sm909539wrw.87.2020.11.11.00.15.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 11 Nov 2020 00:15:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=qdz8HBU8UqesCQRtU4Wdn1Dxa/kS1kAAVQUmbk5BqEU=;\n b=NECjrd3Z7IzdSNLtF6IwCSZqXdResUjk0JcFP9DuvWVBMX/gcZMYY6S5h/91lyIq4x\n R0FUwtWUXVJ0/s0Pq6kXdJv2PWg7lkwyoXK91oz2o1UhcRUSKpj2NxU/2Rk5WZpL2C1P\n M1x0AFYnbmlIKAjau2cEMel6BXdtGUa9+u7Uxa7t2QYy9C1UbUCDrbe1Xl315DOLjHsw\n 2l+Tx9tcWV2b8NZZ4Yf13F7sJ4f7QgXnE3MD72qZ3Pufjqy8AbM3kTF/v7mRAUeMQmh8\n NKzh3PA6fx8ZFfB8b8MH/KQ84iraZeGj20GcMsrY4MUz+VIA6gXHc9c3/SJ1cfnUKFsc\n BDIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=qdz8HBU8UqesCQRtU4Wdn1Dxa/kS1kAAVQUmbk5BqEU=;\n b=X0SJ7LMJFHmY8zDcc7u/Tx4ariCOc2BIE+A2OYIdt+gGmCbpiNOpxCOJfVFlaTlKPP\n /i0J7h4ALd/RPXJAEmBPLa25KMiAeYSbNngKc1bMNPiePN4yBEnXxAxnVA7Gf+4jDtmT\n CDC9vSjWJM81XKid84ksI+L9hFODLwb1cP4K6mWRBXaCw5XhbX0QzkKxSaCVtsZ9alyv\n WN44UqORuU1rfVxJLYFo3joAxN8kcPQ2vX7SlJ+Rx3S1SpXKk+b/QOVJzoko5/UwTGtX\n /rIsQGIlpcXzLbx6g45B7THI7XwdQ5Y8bUsid/9DyJ7ZTrmxjzX91+BE0ZQhyU7Cz61a\n rNxg==", "X-Gm-Message-State": "AOAM530NjO9u6pQO+HZlPrAW/iKEv4gQQq9feLsAff1643qi7R14bu3W\n 2zvem/JTHas5hbgu5vBnU52f2slIzKnI6R8oecQ=", "X-Google-Smtp-Source": "\n ABdhPJzY5Xv2YmRmGN+TkobYVINPl66XcPswaFg3IcNYiQ2FEUrb6Qs6fTrfv+9CBvmL/akZIEV0zQ==", "X-Received": "by 2002:a5d:4349:: with SMTP id u9mr28009994wrr.319.1605082554975;\n Wed, 11 Nov 2020 00:15:54 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n stephen@networkplumber.org", "Date": "Wed, 11 Nov 2020 08:15:05 +0000", "Message-Id": "<20201111081507.19913-5-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "References": "<20201111081507.19913-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH 5/7] examples/qos_sched: enhance getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: stephen@networkplumber.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv2\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n\nv1\n* enhance getopt_long usage\n---\n examples/qos_sched/args.c | 145 ++++++++++++++++++++++----------------\n 1 file changed, 83 insertions(+), 62 deletions(-)", "diff": "diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c\nindex c62719623..15bedae13 100644\n--- a/examples/qos_sched/args.c\n+++ b/examples/qos_sched/args.c\n@@ -297,6 +297,25 @@ app_parse_burst_conf(const char *conf_str)\n \treturn 0;\n }\n \n+enum {\n+#define OPT_PFC \"pfc\"\n+\tOPT_PFC_NUM = 256,\n+#define OPT_MNC \"mnc\"\n+\tOPT_MNC_NUM,\n+#define OPT_RSZ \"rsz\"\n+\tOPT_RSZ_NUM,\n+#define OPT_BSZ \"bsz\"\n+\tOPT_BSZ_NUM,\n+#define OPT_MSZ \"msz\"\n+\tOPT_MSZ_NUM,\n+#define OPT_RTH \"rth\"\n+\tOPT_RTH_NUM,\n+#define OPT_TTH \"tth\"\n+\tOPT_TTH_NUM,\n+#define OPT_CFG \"cfg\"\n+\tOPT_CFG_NUM,\n+};\n+\n /*\n * Parses the argument given in the command line of the application,\n * calculates mask for used cores and initializes EAL with calculated core mask\n@@ -306,20 +325,19 @@ app_parse_args(int argc, char **argv)\n {\n \tint opt, ret;\n \tint option_index;\n-\tconst char *optname;\n \tchar *prgname = argv[0];\n \tuint32_t i, nb_lcores;\n \n \tstatic struct option lgopts[] = {\n-\t\t{ \"pfc\", 1, 0, 0 },\n-\t\t{ \"mnc\", 1, 0, 0 },\n-\t\t{ \"rsz\", 1, 0, 0 },\n-\t\t{ \"bsz\", 1, 0, 0 },\n-\t\t{ \"msz\", 1, 0, 0 },\n-\t\t{ \"rth\", 1, 0, 0 },\n-\t\t{ \"tth\", 1, 0, 0 },\n-\t\t{ \"cfg\", 1, 0, 0 },\n-\t\t{ NULL, 0, 0, 0 }\n+\t\t{OPT_PFC, 1, NULL, OPT_PFC_NUM},\n+\t\t{OPT_MNC, 1, NULL, OPT_MNC_NUM},\n+\t\t{OPT_RSZ, 1, NULL, OPT_RSZ_NUM},\n+\t\t{OPT_BSZ, 1, NULL, OPT_BSZ_NUM},\n+\t\t{OPT_MSZ, 1, NULL, OPT_MSZ_NUM},\n+\t\t{OPT_RTH, 1, NULL, OPT_RTH_NUM},\n+\t\t{OPT_TTH, 1, NULL, OPT_TTH_NUM},\n+\t\t{OPT_CFG, 1, NULL, OPT_CFG_NUM},\n+\t\t{NULL, 0, 0, 0 }\n \t};\n \n \t/* initialize EAL first */\n@@ -342,66 +360,69 @@ app_parse_args(int argc, char **argv)\n \t\t\t\tinteractive = 1;\n \t\t\t\tbreak;\n \t\t\t/* long options */\n-\t\t\tcase 0:\n-\t\t\t\toptname = lgopts[option_index].name;\n-\t\t\t\tif (str_is(optname, \"pfc\")) {\n-\t\t\t\t\tret = app_parse_flow_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid pipe configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"mnc\")) {\n-\t\t\t\t\tapp_main_core = (uint32_t)atoi(optarg);\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"rsz\")) {\n-\t\t\t\t\tret = app_parse_ring_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid ring configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_PFC_NUM:\n+\t\t\t\tret = app_parse_flow_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid pipe configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"bsz\")) {\n-\t\t\t\t\tret = app_parse_burst_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid burst configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_MNC_NUM:\n+\t\t\t\tapp_main_core = (uint32_t)atoi(optarg);\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_RSZ_NUM:\n+\t\t\t\tret = app_parse_ring_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid ring configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"msz\")) {\n-\t\t\t\t\tmp_size = atoi(optarg);\n-\t\t\t\t\tif (mp_size <= 0) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid mempool size %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_BSZ_NUM:\n+\t\t\t\tret = app_parse_burst_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid burst configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"rth\")) {\n-\t\t\t\t\tret = app_parse_rth_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid RX threshold configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_MSZ_NUM:\n+\t\t\t\tmp_size = atoi(optarg);\n+\t\t\t\tif (mp_size <= 0) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid mempool size %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"tth\")) {\n-\t\t\t\t\tret = app_parse_tth_conf(optarg);\n-\t\t\t\t\tif (ret) {\n-\t\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid TX threshold configuration %s\\n\", optarg);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_RTH_NUM:\n+\t\t\t\tret = app_parse_rth_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid RX threshold configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n-\t\t\t\tif (str_is(optname, \"cfg\")) {\n-\t\t\t\t\tcfg_profile = optarg;\n-\t\t\t\t\tbreak;\n+\t\t\t\tbreak;\n+\n+\t\t\tcase OPT_TTH_NUM:\n+\t\t\t\tret = app_parse_tth_conf(optarg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tRTE_LOG(ERR, APP, \"Invalid TX threshold configuration %s\\n\",\n+\t\t\t\t\t\t\toptarg);\n+\t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tbreak;\n \n+\t\t\tcase OPT_CFG_NUM:\n+\t\t\t\tcfg_profile = optarg;\n+\t\t\t\tbreak;\n+\n \t\t\tdefault:\n \t\t\t\tapp_usage(prgname);\n \t\t\t\treturn -1;\n", "prefixes": [ "5/7" ] }