Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83990/?format=api
{ "id": 83990, "url": "http://patches.dpdk.org/api/patches/83990/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1605080208-12165-5-git-send-email-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1605080208-12165-5-git-send-email-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1605080208-12165-5-git-send-email-michaelba@nvidia.com", "date": "2020-11-11T07:36:48", "name": "[5/5] common/mlx5: fix flex parser creation error flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6629fa10570c57bfb6a73d3f1ad025ded7d1bba9", "submitter": { "id": 1949, "url": "http://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1605080208-12165-5-git-send-email-michaelba@nvidia.com/mbox/", "series": [ { "id": 13800, "url": "http://patches.dpdk.org/api/series/13800/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13800", "date": "2020-11-11T07:36:44", "name": "[1/5] net/mlx5: fix unused calculation in RSS expansion", "version": 1, "mbox": "http://patches.dpdk.org/series/13800/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83990/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83990/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB12AA09D2;\n\tWed, 11 Nov 2020 08:38:27 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 283852BAB;\n\tWed, 11 Nov 2020 08:38:07 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 9F478DED\n for <dev@dpdk.org>; Wed, 11 Nov 2020 08:38:04 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n michaelba@nvidia.com) with SMTP; 11 Nov 2020 09:38:02 +0200", "from nvidia.com (pegasus07.mtr.labs.mlnx [10.210.16.112])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0AB7b2wp028356;\n Wed, 11 Nov 2020 09:38:01 +0200" ], "From": "Michael Baum <michaelba@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Michael Baum <michaelba@mellanox.com>, stable@dpdk.org", "Date": "Wed, 11 Nov 2020 07:36:48 +0000", "Message-Id": "<1605080208-12165-5-git-send-email-michaelba@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1605080208-12165-1-git-send-email-michaelba@nvidia.com>", "References": "<1605080208-12165-1-git-send-email-michaelba@nvidia.com>", "Subject": "[dpdk-dev] [PATCH 5/5] common/mlx5: fix flex parser creation error\n\tflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Michael Baum <michaelba@mellanox.com>\n\nThe mlx5_devx_cmd_create_flex_parser function defines a local array\n(with constant size) named in, and then allocates a pointer to\nmlx5_devx_obj structure by the mlx5_malloc function.\n\nIf the allocation fails, the function releases the array in and returns\nNULL. However, the array has been defined locally on the stack and the\nmlx5_free function is not required to release it.\n\nRemove the call to the mlx5_free function.\n\nFixes: 66914d19d135 (\"common/mlx5: convert control path memory to unified malloc\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@mellanox.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 5998c4b..9c1d188 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -530,15 +530,13 @@ struct mlx5_devx_obj *\n \tvoid *sample = MLX5_ADDR_OF(parse_graph_flex, flex, sample_table);\n \tvoid *in_arc = MLX5_ADDR_OF(parse_graph_flex, flex, input_arc);\n \tvoid *out_arc = MLX5_ADDR_OF(parse_graph_flex, flex, output_arc);\n-\tstruct mlx5_devx_obj *parse_flex_obj = NULL;\n+\tstruct mlx5_devx_obj *parse_flex_obj = mlx5_malloc\n+\t\t (MLX5_MEM_ZERO, sizeof(*parse_flex_obj), 0, SOCKET_ID_ANY);\n \tuint32_t i;\n \n-\tparse_flex_obj = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*parse_flex_obj), 0,\n-\t\t\t\t SOCKET_ID_ANY);\n \tif (!parse_flex_obj) {\n-\t\tDRV_LOG(ERR, \"Failed to allocate flex parser data\");\n+\t\tDRV_LOG(ERR, \"Failed to allocate flex parser data.\");\n \t\trte_errno = ENOMEM;\n-\t\tmlx5_free(in);\n \t\treturn NULL;\n \t}\n \tMLX5_SET(general_obj_in_cmd_hdr, hdr, opcode,\n", "prefixes": [ "5/5" ] }