Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83971/?format=api
{ "id": 83971, "url": "http://patches.dpdk.org/api/patches/83971/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-30-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-30-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-30-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:28", "name": "[v2,29/37] net/txgbe: support TM shaper profile add and delete", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2ed5ad76e848f0dd5a0f96fd0e9e7fa72506525b", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-30-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83971/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83971/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4A236A09D2;\n\tWed, 11 Nov 2020 07:57:54 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 31F9CC82A;\n\tWed, 11 Nov 2020 07:48:22 +0100 (CET)", "from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])\n by dpdk.org (Postfix) with ESMTP id 64366BB94\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:48:04 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:57 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077278trdd995j", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "uPKj8ga2w7HYs9zJn3i2NbtsObYlrZF3cdIJMcc22c2v8b1dOxQZSqzO6FZP9\n a9EHI1uHgdHVJ+EusIE2So5a+KfDTF1hIJd+h0JrqjqFjFa4U69CrVTauG8um8ToQ0e/T4c\n FNgOm34pgjiqS6A03KxOL415jqaUR5dOu+InNk5XQBozwwAiECBzvCNhI3aYkRzjzm9ly5B\n /kEW+B4moXB0ihXMTNIk/hAhRRmPVuewJE/NpK02fLoIfgsViB0syo9+acy8V52vhFQo54+\n +ilID4heeil7dT4kWTLgTziY4TEq6nj1XK6MP6ZRr4qZ1XKH/5l+aSuiTCIV4UrSqysRqT1\n 9TsRdO9/jVfaK/wfINjja/lJkPYFQ==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:28 +0800", "Message-Id": "<20201111064936.768604-30-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 29/37] net/txgbe: support TM shaper profile\n\tadd and delete", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support traffic manager profile add and delete operations.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_tm.c | 129 +++++++++++++++++++++++++++++++++++\n 1 file changed, 129 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c\nindex 545590ba2..8adb03825 100644\n--- a/drivers/net/txgbe/txgbe_tm.c\n+++ b/drivers/net/txgbe/txgbe_tm.c\n@@ -9,6 +9,13 @@\n static int txgbe_tm_capabilities_get(struct rte_eth_dev *dev,\n \t\t\t\t struct rte_tm_capabilities *cap,\n \t\t\t\t struct rte_tm_error *error);\n+static int txgbe_shaper_profile_add(struct rte_eth_dev *dev,\n+\t\t\t\t uint32_t shaper_profile_id,\n+\t\t\t\t struct rte_tm_shaper_params *profile,\n+\t\t\t\t struct rte_tm_error *error);\n+static int txgbe_shaper_profile_del(struct rte_eth_dev *dev,\n+\t\t\t\t uint32_t shaper_profile_id,\n+\t\t\t\t struct rte_tm_error *error);\n static int txgbe_level_capabilities_get(struct rte_eth_dev *dev,\n \t\t\t\t\tuint32_t level_id,\n \t\t\t\t\tstruct rte_tm_level_capabilities *cap,\n@@ -20,6 +27,8 @@ static int txgbe_node_capabilities_get(struct rte_eth_dev *dev,\n \n const struct rte_tm_ops txgbe_tm_ops = {\n \t.capabilities_get = txgbe_tm_capabilities_get,\n+\t.shaper_profile_add = txgbe_shaper_profile_add,\n+\t.shaper_profile_delete = txgbe_shaper_profile_del,\n \t.level_capabilities_get = txgbe_level_capabilities_get,\n \t.node_capabilities_get = txgbe_node_capabilities_get,\n };\n@@ -174,6 +183,126 @@ txgbe_tm_capabilities_get(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+static inline struct txgbe_tm_shaper_profile *\n+txgbe_shaper_profile_search(struct rte_eth_dev *dev,\n+\t\t\t uint32_t shaper_profile_id)\n+{\n+\tstruct txgbe_tm_conf *tm_conf = TXGBE_DEV_TM_CONF(dev);\n+\tstruct txgbe_shaper_profile_list *shaper_profile_list =\n+\t\t&tm_conf->shaper_profile_list;\n+\tstruct txgbe_tm_shaper_profile *shaper_profile;\n+\n+\tTAILQ_FOREACH(shaper_profile, shaper_profile_list, node) {\n+\t\tif (shaper_profile_id == shaper_profile->shaper_profile_id)\n+\t\t\treturn shaper_profile;\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+static int\n+txgbe_shaper_profile_param_check(struct rte_tm_shaper_params *profile,\n+\t\t\t\t struct rte_tm_error *error)\n+{\n+\t/* min rate not supported */\n+\tif (profile->committed.rate) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_COMMITTED_RATE;\n+\t\terror->message = \"committed rate not supported\";\n+\t\treturn -EINVAL;\n+\t}\n+\t/* min bucket size not supported */\n+\tif (profile->committed.size) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_COMMITTED_SIZE;\n+\t\terror->message = \"committed bucket size not supported\";\n+\t\treturn -EINVAL;\n+\t}\n+\t/* max bucket size not supported */\n+\tif (profile->peak.size) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PEAK_SIZE;\n+\t\terror->message = \"peak bucket size not supported\";\n+\t\treturn -EINVAL;\n+\t}\n+\t/* length adjustment not supported */\n+\tif (profile->pkt_length_adjust) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_PKT_ADJUST_LEN;\n+\t\terror->message = \"packet length adjustment not supported\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_shaper_profile_add(struct rte_eth_dev *dev,\n+\t\t\t uint32_t shaper_profile_id,\n+\t\t\t struct rte_tm_shaper_params *profile,\n+\t\t\t struct rte_tm_error *error)\n+{\n+\tstruct txgbe_tm_conf *tm_conf = TXGBE_DEV_TM_CONF(dev);\n+\tstruct txgbe_tm_shaper_profile *shaper_profile;\n+\tint ret;\n+\n+\tif (!profile || !error)\n+\t\treturn -EINVAL;\n+\n+\tret = txgbe_shaper_profile_param_check(profile, error);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tshaper_profile = txgbe_shaper_profile_search(dev, shaper_profile_id);\n+\n+\tif (shaper_profile) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_ID;\n+\t\terror->message = \"profile ID exist\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tshaper_profile = rte_zmalloc(\"txgbe_tm_shaper_profile\",\n+\t\t\t\t sizeof(struct txgbe_tm_shaper_profile),\n+\t\t\t\t 0);\n+\tif (!shaper_profile)\n+\t\treturn -ENOMEM;\n+\tshaper_profile->shaper_profile_id = shaper_profile_id;\n+\trte_memcpy(&shaper_profile->profile, profile,\n+\t\t\t sizeof(struct rte_tm_shaper_params));\n+\tTAILQ_INSERT_TAIL(&tm_conf->shaper_profile_list,\n+\t\t\t shaper_profile, node);\n+\n+\treturn 0;\n+}\n+\n+static int\n+txgbe_shaper_profile_del(struct rte_eth_dev *dev,\n+\t\t\t uint32_t shaper_profile_id,\n+\t\t\t struct rte_tm_error *error)\n+{\n+\tstruct txgbe_tm_conf *tm_conf = TXGBE_DEV_TM_CONF(dev);\n+\tstruct txgbe_tm_shaper_profile *shaper_profile;\n+\n+\tif (!error)\n+\t\treturn -EINVAL;\n+\n+\tshaper_profile = txgbe_shaper_profile_search(dev, shaper_profile_id);\n+\n+\tif (!shaper_profile) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE_ID;\n+\t\terror->message = \"profile ID not exist\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* don't delete a profile if it's used by one or several nodes */\n+\tif (shaper_profile->reference_count) {\n+\t\terror->type = RTE_TM_ERROR_TYPE_SHAPER_PROFILE;\n+\t\terror->message = \"profile in use\";\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tTAILQ_REMOVE(&tm_conf->shaper_profile_list, shaper_profile, node);\n+\trte_free(shaper_profile);\n+\n+\treturn 0;\n+}\n+\n static inline struct txgbe_tm_node *\n txgbe_tm_node_search(struct rte_eth_dev *dev, uint32_t node_id,\n \t\t enum txgbe_tm_node_type *node_type)\n", "prefixes": [ "v2", "29/37" ] }