Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83964/?format=api
{ "id": 83964, "url": "http://patches.dpdk.org/api/patches/83964/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-22-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-22-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-22-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:20", "name": "[v2,21/37] net/txgbe: add filter list init and uninit", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "29f281a6f112ee2f9c810476c6af5d0b98f99d36", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-22-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83964/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83964/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 690E2A09D2;\n\tWed, 11 Nov 2020 07:55:23 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6E66AC30F;\n\tWed, 11 Nov 2020 07:48:10 +0100 (CET)", "from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])\n by dpdk.org (Postfix) with ESMTP id 3CAADAD6F\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:54 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:47 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077267thy8q1w4", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "mEyZ4W2HZmBIyWiu714GG6/D6ZYV++ZqdRcHLaCLic0VA6wi0n9t6uJMxvFmW\n +5PGfxgM8iyOzQl7cazMPyeiOqENVK4yvThzmnJ7ONGY9AqYGPBe7Sc4B9akq9MnLC/swu4\n YVV86fAQV82IU8fCX/hnPqNcHW+fhT2BLc+ta5IsjVELaDb2Wt+8y3qgm86vU1LakqaoY+g\n 71jTDQlA+wojXVKLY+4q12ahsMxdkikzJfbRRby7zsWo33kS8pohs1T2ZciMy3DGi2cfNsd\n 9+LtdV4mLd81ieH/Vw3t436+JuHC6329C118y6lap0YS8qSPEzVpfXxo5MgS2k9uWJX/i/A\n 49RQfMR7ToYWhyuqw1w6zfTMiW1OA==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:20 +0800", "Message-Id": "<20201111064936.768604-22-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 21/37] net/txgbe: add filter list init and\n\tuninit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add filter list init and uninit.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 6 ++\n drivers/net/txgbe/txgbe_ethdev.h | 8 ++\n drivers/net/txgbe/txgbe_flow.c | 127 +++++++++++++++++++++++++++++++\n 3 files changed, 141 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 2983b63a2..bffccb822 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -698,6 +698,9 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t/* initialize l2 tunnel filter list & hash */\n \ttxgbe_l2_tn_filter_init(eth_dev);\n \n+\t/* initialize flow filter lists */\n+\ttxgbe_filterlist_init();\n+\n \t/* initialize bandwidth configuration info */\n \tmemset(bw_conf, 0, sizeof(struct txgbe_bw_conf));\n \n@@ -1941,6 +1944,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)\n \t/* Remove all ntuple filters of the device */\n \ttxgbe_ntuple_filter_uninit(dev);\n \n+\t/* clear all the filters list */\n+\ttxgbe_filterlist_flush();\n+\n \treturn ret;\n }\n \ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex b8fc605a7..ceecb746f 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -263,6 +263,11 @@ struct txgbe_l2_tn_info {\n \tuint16_t e_tag_ether_type; /* ether type for e-tag */\n };\n \n+struct rte_flow {\n+\tenum rte_filter_type filter_type;\n+\tvoid *rule;\n+};\n+\n /* The configuration of bandwidth */\n struct txgbe_bw_conf {\n \tuint8_t tc_num; /* Number of TCs. */\n@@ -448,6 +453,9 @@ txgbe_dev_l2_tunnel_filter_add(struct rte_eth_dev *dev,\n int\n txgbe_dev_l2_tunnel_filter_del(struct rte_eth_dev *dev,\n \t\t\t struct txgbe_l2_tunnel_conf *l2_tunnel);\n+void txgbe_filterlist_init(void);\n+void txgbe_filterlist_flush(void);\n+\n void txgbe_set_ivar_map(struct txgbe_hw *hw, int8_t direction,\n \t\t\t uint8_t queue, uint8_t msix_vector);\n \ndiff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex 0d90ef33a..77e025863 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -16,6 +16,7 @@\n #include <rte_cycles.h>\n \n #include <rte_bus_pci.h>\n+#include <rte_malloc.h>\n #include <rte_hash_crc.h>\n #include <rte_flow.h>\n #include <rte_flow_driver.h>\n@@ -29,6 +30,58 @@\n #define TXGBE_MAX_N_TUPLE_PRIO 7\n #define TXGBE_MAX_FLX_SOURCE_OFF 62\n \n+/* ntuple filter list structure */\n+struct txgbe_ntuple_filter_ele {\n+\tTAILQ_ENTRY(txgbe_ntuple_filter_ele) entries;\n+\tstruct rte_eth_ntuple_filter filter_info;\n+};\n+/* ethertype filter list structure */\n+struct txgbe_ethertype_filter_ele {\n+\tTAILQ_ENTRY(txgbe_ethertype_filter_ele) entries;\n+\tstruct rte_eth_ethertype_filter filter_info;\n+};\n+/* syn filter list structure */\n+struct txgbe_eth_syn_filter_ele {\n+\tTAILQ_ENTRY(txgbe_eth_syn_filter_ele) entries;\n+\tstruct rte_eth_syn_filter filter_info;\n+};\n+/* fdir filter list structure */\n+struct txgbe_fdir_rule_ele {\n+\tTAILQ_ENTRY(txgbe_fdir_rule_ele) entries;\n+\tstruct txgbe_fdir_rule filter_info;\n+};\n+/* l2_tunnel filter list structure */\n+struct txgbe_eth_l2_tunnel_conf_ele {\n+\tTAILQ_ENTRY(txgbe_eth_l2_tunnel_conf_ele) entries;\n+\tstruct txgbe_l2_tunnel_conf filter_info;\n+};\n+/* rss filter list structure */\n+struct txgbe_rss_conf_ele {\n+\tTAILQ_ENTRY(txgbe_rss_conf_ele) entries;\n+\tstruct txgbe_rte_flow_rss_conf filter_info;\n+};\n+/* txgbe_flow memory list structure */\n+struct txgbe_flow_mem {\n+\tTAILQ_ENTRY(txgbe_flow_mem) entries;\n+\tstruct rte_flow *flow;\n+};\n+\n+TAILQ_HEAD(txgbe_ntuple_filter_list, txgbe_ntuple_filter_ele);\n+TAILQ_HEAD(txgbe_ethertype_filter_list, txgbe_ethertype_filter_ele);\n+TAILQ_HEAD(txgbe_syn_filter_list, txgbe_eth_syn_filter_ele);\n+TAILQ_HEAD(txgbe_fdir_rule_filter_list, txgbe_fdir_rule_ele);\n+TAILQ_HEAD(txgbe_l2_tunnel_filter_list, txgbe_eth_l2_tunnel_conf_ele);\n+TAILQ_HEAD(txgbe_rss_filter_list, txgbe_rss_conf_ele);\n+TAILQ_HEAD(txgbe_flow_mem_list, txgbe_flow_mem);\n+\n+static struct txgbe_ntuple_filter_list filter_ntuple_list;\n+static struct txgbe_ethertype_filter_list filter_ethertype_list;\n+static struct txgbe_syn_filter_list filter_syn_list;\n+static struct txgbe_fdir_rule_filter_list filter_fdir_list;\n+static struct txgbe_l2_tunnel_filter_list filter_l2_tunnel_list;\n+static struct txgbe_rss_filter_list filter_rss_list;\n+static struct txgbe_flow_mem_list txgbe_flow_list;\n+\n /**\n * Endless loop will never happen with below assumption\n * 1. there is at least one no-void item(END)\n@@ -2502,3 +2555,77 @@ txgbe_parse_rss_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+void\n+txgbe_filterlist_init(void)\n+{\n+\tTAILQ_INIT(&filter_ntuple_list);\n+\tTAILQ_INIT(&filter_ethertype_list);\n+\tTAILQ_INIT(&filter_syn_list);\n+\tTAILQ_INIT(&filter_fdir_list);\n+\tTAILQ_INIT(&filter_l2_tunnel_list);\n+\tTAILQ_INIT(&filter_rss_list);\n+\tTAILQ_INIT(&txgbe_flow_list);\n+}\n+\n+void\n+txgbe_filterlist_flush(void)\n+{\n+\tstruct txgbe_ntuple_filter_ele *ntuple_filter_ptr;\n+\tstruct txgbe_ethertype_filter_ele *ethertype_filter_ptr;\n+\tstruct txgbe_eth_syn_filter_ele *syn_filter_ptr;\n+\tstruct txgbe_eth_l2_tunnel_conf_ele *l2_tn_filter_ptr;\n+\tstruct txgbe_fdir_rule_ele *fdir_rule_ptr;\n+\tstruct txgbe_flow_mem *txgbe_flow_mem_ptr;\n+\tstruct txgbe_rss_conf_ele *rss_filter_ptr;\n+\n+\twhile ((ntuple_filter_ptr = TAILQ_FIRST(&filter_ntuple_list))) {\n+\t\tTAILQ_REMOVE(&filter_ntuple_list,\n+\t\t\t\t ntuple_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(ntuple_filter_ptr);\n+\t}\n+\n+\twhile ((ethertype_filter_ptr = TAILQ_FIRST(&filter_ethertype_list))) {\n+\t\tTAILQ_REMOVE(&filter_ethertype_list,\n+\t\t\t\t ethertype_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(ethertype_filter_ptr);\n+\t}\n+\n+\twhile ((syn_filter_ptr = TAILQ_FIRST(&filter_syn_list))) {\n+\t\tTAILQ_REMOVE(&filter_syn_list,\n+\t\t\t\t syn_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(syn_filter_ptr);\n+\t}\n+\n+\twhile ((l2_tn_filter_ptr = TAILQ_FIRST(&filter_l2_tunnel_list))) {\n+\t\tTAILQ_REMOVE(&filter_l2_tunnel_list,\n+\t\t\t\t l2_tn_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(l2_tn_filter_ptr);\n+\t}\n+\n+\twhile ((fdir_rule_ptr = TAILQ_FIRST(&filter_fdir_list))) {\n+\t\tTAILQ_REMOVE(&filter_fdir_list,\n+\t\t\t\t fdir_rule_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(fdir_rule_ptr);\n+\t}\n+\n+\twhile ((rss_filter_ptr = TAILQ_FIRST(&filter_rss_list))) {\n+\t\tTAILQ_REMOVE(&filter_rss_list,\n+\t\t\t\t rss_filter_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(rss_filter_ptr);\n+\t}\n+\n+\twhile ((txgbe_flow_mem_ptr = TAILQ_FIRST(&txgbe_flow_list))) {\n+\t\tTAILQ_REMOVE(&txgbe_flow_list,\n+\t\t\t\t txgbe_flow_mem_ptr,\n+\t\t\t\t entries);\n+\t\trte_free(txgbe_flow_mem_ptr->flow);\n+\t\trte_free(txgbe_flow_mem_ptr);\n+\t}\n+}\n+\n", "prefixes": [ "v2", "21/37" ] }