Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 83962,
    "url": "http://patches.dpdk.org/api/patches/83962/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-20-jiawenwu@trustnetic.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201111064936.768604-20-jiawenwu@trustnetic.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-20-jiawenwu@trustnetic.com",
    "date": "2020-11-11T06:49:18",
    "name": "[v2,19/37] net/txgbe: add RSS filter parse rule",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "b1df39c4bdcd891f181c1c6f8b0011d5e3536386",
    "submitter": {
        "id": 1932,
        "url": "http://patches.dpdk.org/api/people/1932/?format=api",
        "name": "Jiawen Wu",
        "email": "jiawenwu@trustnetic.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-20-jiawenwu@trustnetic.com/mbox/",
    "series": [
        {
            "id": 13798,
            "url": "http://patches.dpdk.org/api/series/13798/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798",
            "date": "2020-11-11T06:49:00",
            "name": "net: add txgbe PMD part 2",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/13798/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/83962/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/83962/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 85972A09D2;\n\tWed, 11 Nov 2020 07:54:40 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 918A7BE83;\n\tWed, 11 Nov 2020 07:48:07 +0100 (CET)",
            "from smtpbg506.qq.com (smtpbg506.qq.com [203.205.250.33])\n by dpdk.org (Postfix) with ESMTP id 7CBBBA54B\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:49 +0100 (CET)",
            "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:45 +0800 (CST)"
        ],
        "X-QQ-mid": "bizesmtp27t1605077265tyw1opex",
        "X-QQ-SSF": "01400000000000C0C000B00A0000000",
        "X-QQ-FEAT": "uPKj8ga2w7FTI8s5aJKRcfSZZIqA2flRf0++hcBF7o9/oZB3XfRULl5GlhJQM\n 3kJLxI2J+JB6N1M+zYpPM24jbKjIlV0MZ0nq5ifLXX6+9g4QGWDh1PAhHX7GRjhJgTFtVl7\n k4xk1nQPZ75bcW2f+SGrz+zim1esc582FY0S2oIJa5yzMmEuFCqS40dPHs5hxJlAO0u4CIA\n K6f/M0/dUukaAsVUXTFVtOSX+jeaoaVk4lTw5LTyFEC84l8sR5ipKg0pVXbbwxZTTFcSa4u\n KISi2eYJoOKxiQ1G8tCX7gjuHLqiOSvgGJBFMOgYGny/6v4BQ1BdTfbtYwAwuU+eYnimeVz\n CLuV1a0vbF2/lL3dsoc5vLybwur6g==",
        "X-QQ-GoodBg": "2",
        "From": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "To": "dev@dpdk.org",
        "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>",
        "Date": "Wed, 11 Nov 2020 14:49:18 +0800",
        "Message-Id": "<20201111064936.768604-20-jiawenwu@trustnetic.com>",
        "X-Mailer": "git-send-email 2.18.4",
        "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>",
        "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>",
        "X-QQ-SENDSIZE": "520",
        "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6",
        "X-QQ-Bgrelay": "1",
        "Subject": "[dpdk-dev] [PATCH v2 19/37] net/txgbe: add RSS filter parse rule",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add support to parse flow for RSS filter.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.h |   8 +++\n drivers/net/txgbe/txgbe_flow.c   | 114 +++++++++++++++++++++++++++++++\n drivers/net/txgbe/txgbe_rxtx.c   |  20 ++++++\n 3 files changed, 142 insertions(+)",
    "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 47b095e4f..80587b245 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -121,6 +121,12 @@ struct txgbe_hw_fdir_info {\n \tbool mask_added; /* If already got mask from consistent filter */\n };\n \n+struct txgbe_rte_flow_rss_conf {\n+\tstruct rte_flow_action_rss conf; /**< RSS parameters. */\n+\tuint8_t key[TXGBE_HKEY_MAX_INDEX * sizeof(uint32_t)]; /* Hash key. */\n+\tuint16_t queue[TXGBE_MAX_RX_QUEUE_NUM]; /**< Queues indices to use. */\n+};\n+\n /* structure for interrupt relative data */\n struct txgbe_interrupt {\n \tuint32_t flags;\n@@ -479,6 +485,8 @@ int txgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,\n \t\t\t    uint16_t tx_rate, uint64_t q_msk);\n int txgbe_set_queue_rate_limit(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t\t       uint16_t tx_rate);\n+int txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n+\t\t\tconst struct rte_flow_action_rss *in);\n static inline int\n txgbe_ethertype_filter_lookup(struct txgbe_filter_info *filter_info,\n \t\t\t      uint16_t ethertype)\ndiff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c\nindex b7d0e08a9..0d90ef33a 100644\n--- a/drivers/net/txgbe/txgbe_flow.c\n+++ b/drivers/net/txgbe/txgbe_flow.c\n@@ -2388,3 +2388,117 @@ txgbe_parse_fdir_filter(struct rte_eth_dev *dev,\n \treturn ret;\n }\n \n+static int\n+txgbe_parse_rss_filter(struct rte_eth_dev *dev,\n+\t\t\tconst struct rte_flow_attr *attr,\n+\t\t\tconst struct rte_flow_action actions[],\n+\t\t\tstruct txgbe_rte_flow_rss_conf *rss_conf,\n+\t\t\tstruct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_action *act;\n+\tconst struct rte_flow_action_rss *rss;\n+\tuint16_t n;\n+\n+\t/**\n+\t * rss only supports forwarding,\n+\t * check if the first not void action is RSS.\n+\t */\n+\tact = next_no_void_action(actions, NULL);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_RSS) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\trss = (const struct rte_flow_action_rss *)act->conf;\n+\n+\tif (!rss || !rss->queue_num) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\tact,\n+\t\t\t   \"no valid queues\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tfor (n = 0; n < rss->queue_num; n++) {\n+\t\tif (rss->queue[n] >= dev->data->nb_rx_queues) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t   act,\n+\t\t\t\t   \"queue id > max number of queues\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\n+\tif (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"non-default RSS hash functions are not supported\");\n+\tif (rss->level)\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"a nonzero RSS encapsulation level is not supported\");\n+\tif (rss->key_len && rss->key_len != RTE_DIM(rss_conf->key))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"RSS hash key must be exactly 40 bytes\");\n+\tif (rss->queue_num > RTE_DIM(rss_conf->queue))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"too many queues for RSS context\");\n+\tif (txgbe_rss_conf_init(rss_conf, rss))\n+\t\treturn rte_flow_error_set\n+\t\t\t(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act,\n+\t\t\t \"RSS context initialization failure\");\n+\n+\t/* check if the next not void item is END */\n+\tact = next_no_void_action(actions, act);\n+\tif (act->type != RTE_FLOW_ACTION_TYPE_END) {\n+\t\tmemset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\tact, \"Not supported action.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* parse attr */\n+\t/* must be input direction */\n+\tif (!attr->ingress) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,\n+\t\t\t\t   attr, \"Only support ingress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->egress) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR_EGRESS,\n+\t\t\t\t   attr, \"Not support egress.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* not supported */\n+\tif (attr->transfer) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,\n+\t\t\t\t   attr, \"No support for transfer.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (attr->priority > 0xFFFF) {\n+\t\tmemset(rss_conf, 0, sizeof(struct txgbe_rte_flow_rss_conf));\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t   RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY,\n+\t\t\t\t   attr, \"Error priority.\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\treturn 0;\n+}\n+\ndiff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c\nindex 82dde509a..5f212ffc3 100644\n--- a/drivers/net/txgbe/txgbe_rxtx.c\n+++ b/drivers/net/txgbe/txgbe_rxtx.c\n@@ -4633,3 +4633,23 @@ txgbe_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = txq->tx_deferred_start;\n }\n \n+int\n+txgbe_rss_conf_init(struct txgbe_rte_flow_rss_conf *out,\n+\t\t    const struct rte_flow_action_rss *in)\n+{\n+\tif (in->key_len > RTE_DIM(out->key) ||\n+\t    in->queue_num > RTE_DIM(out->queue))\n+\t\treturn -EINVAL;\n+\tout->conf = (struct rte_flow_action_rss){\n+\t\t.func = in->func,\n+\t\t.level = in->level,\n+\t\t.types = in->types,\n+\t\t.key_len = in->key_len,\n+\t\t.queue_num = in->queue_num,\n+\t\t.key = memcpy(out->key, in->key, in->key_len),\n+\t\t.queue = memcpy(out->queue, in->queue,\n+\t\t\t\tsizeof(*in->queue) * in->queue_num),\n+\t};\n+\treturn 0;\n+}\n+\n",
    "prefixes": [
        "v2",
        "19/37"
    ]
}