Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83948/?format=api
{ "id": 83948, "url": "http://patches.dpdk.org/api/patches/83948/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-6-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-6-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-6-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:04", "name": "[v2,05/37] net/txgbe: support ethertype filter add and delete", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "25148b706922ef6e4e14f954be20cd7205048c17", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-6-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83948/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83948/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 09B65A09D2;\n\tWed, 11 Nov 2020 07:49:23 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 413B45F13;\n\tWed, 11 Nov 2020 07:47:41 +0100 (CET)", "from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216])\n by dpdk.org (Postfix) with ESMTP id 66C965A51\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:34 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:26 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077247talyedes", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "dMLGSgzcGotx8vWbQUmcG1n2+/JwwiroQy4oa58fQAax9NBekqtEU/InMITxs\n ajV8cmCm/HosEmZJrVbU3BfEcP3Yyn9/6iopJKEz/FjICTej8mVCWpz2IeFSEuDQfRD+RmO\n wEsfImNoDOPIR72ZstxK/BGOq6nlOhvFjzyfEtEqNHfnH6AQqdycQVIJyWC/yE6JnwaJMjT\n W9lTCOedP6YwUo6znOMMNsxsqAn2ToNp8CSWzb+AuCyXwajkIVze+MKCV39t5EIriaXHjU+\n /ue8gM6xfPfq2SmMbJcyfUqDZK8nLsw62BhW2mLabuFVuzRf9jhnETXKCAXxLZ7kHDDu5Z/\n p/itT1O38t/Jb4Q7FF0m33vZpGC2g==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:04 +0800", "Message-Id": "<20201111064936.768604-6-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 05/37] net/txgbe: support ethertype filter add\n\tand delete", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support add and delete operaions on ethertype filter.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ethdev.c | 111 +++++++++++++++++++++++++++++++\n drivers/net/txgbe/txgbe_ethdev.h | 19 ++++++\n 2 files changed, 130 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 472c5cc2b..63285bee9 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -3799,6 +3799,77 @@ txgbe_add_del_ntuple_filter(struct rte_eth_dev *dev,\n \treturn 0;\n }\n \n+int\n+txgbe_add_del_ethertype_filter(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_eth_ethertype_filter *filter,\n+\t\t\tbool add)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\tuint32_t etqf = 0;\n+\tuint32_t etqs = 0;\n+\tint ret;\n+\tstruct txgbe_ethertype_filter ethertype_filter;\n+\n+\tif (filter->queue >= TXGBE_MAX_RX_QUEUE_NUM)\n+\t\treturn -EINVAL;\n+\n+\tif (filter->ether_type == RTE_ETHER_TYPE_IPV4 ||\n+\t filter->ether_type == RTE_ETHER_TYPE_IPV6) {\n+\t\tPMD_DRV_LOG(ERR, \"unsupported ether_type(0x%04x) in\"\n+\t\t\t\" ethertype filter.\", filter->ether_type);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (filter->flags & RTE_ETHTYPE_FLAGS_MAC) {\n+\t\tPMD_DRV_LOG(ERR, \"mac compare is unsupported.\");\n+\t\treturn -EINVAL;\n+\t}\n+\tif (filter->flags & RTE_ETHTYPE_FLAGS_DROP) {\n+\t\tPMD_DRV_LOG(ERR, \"drop option is unsupported.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tret = txgbe_ethertype_filter_lookup(filter_info, filter->ether_type);\n+\tif (ret >= 0 && add) {\n+\t\tPMD_DRV_LOG(ERR, \"ethertype (0x%04x) filter exists.\",\n+\t\t\t filter->ether_type);\n+\t\treturn -EEXIST;\n+\t}\n+\tif (ret < 0 && !add) {\n+\t\tPMD_DRV_LOG(ERR, \"ethertype (0x%04x) filter doesn't exist.\",\n+\t\t\t filter->ether_type);\n+\t\treturn -ENOENT;\n+\t}\n+\n+\tif (add) {\n+\t\tetqf = TXGBE_ETFLT_ENA;\n+\t\tetqf |= TXGBE_ETFLT_ETID(filter->ether_type);\n+\t\tetqs |= TXGBE_ETCLS_QPID(filter->queue);\n+\t\tetqs |= TXGBE_ETCLS_QENA;\n+\n+\t\tethertype_filter.ethertype = filter->ether_type;\n+\t\tethertype_filter.etqf = etqf;\n+\t\tethertype_filter.etqs = etqs;\n+\t\tethertype_filter.conf = FALSE;\n+\t\tret = txgbe_ethertype_filter_insert(filter_info,\n+\t\t\t\t\t\t ðertype_filter);\n+\t\tif (ret < 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"ethertype filters are full.\");\n+\t\t\treturn -ENOSPC;\n+\t\t}\n+\t} else {\n+\t\tret = txgbe_ethertype_filter_remove(filter_info, (uint8_t)ret);\n+\t\tif (ret < 0)\n+\t\t\treturn -ENOSYS;\n+\t}\n+\twr32(hw, TXGBE_ETFLT(ret), etqf);\n+\twr32(hw, TXGBE_ETCLS(ret), etqs);\n+\ttxgbe_flush(hw);\n+\n+\treturn 0;\n+}\n+\n static u8 *\n txgbe_dev_addr_list_itr(__rte_unused struct txgbe_hw *hw,\n \t\t\tu8 **mc_addr_ptr, u32 *vmdq)\n@@ -4332,10 +4403,30 @@ txgbe_ntuple_filter_restore(struct rte_eth_dev *dev)\n \t}\n }\n \n+/* restore ethernet type filter */\n+static inline void\n+txgbe_ethertype_filter_restore(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\tint i;\n+\n+\tfor (i = 0; i < TXGBE_ETF_ID_MAX; i++) {\n+\t\tif (filter_info->ethertype_mask & (1 << i)) {\n+\t\t\twr32(hw, TXGBE_ETFLT(i),\n+\t\t\t\t\tfilter_info->ethertype_filters[i].etqf);\n+\t\t\twr32(hw, TXGBE_ETCLS(i),\n+\t\t\t\t\tfilter_info->ethertype_filters[i].etqs);\n+\t\t\ttxgbe_flush(hw);\n+\t\t}\n+\t}\n+}\n+\n static int\n txgbe_filter_restore(struct rte_eth_dev *dev)\n {\n \ttxgbe_ntuple_filter_restore(dev);\n+\ttxgbe_ethertype_filter_restore(dev);\n \n \treturn 0;\n }\n@@ -4351,6 +4442,26 @@ txgbe_clear_all_ntuple_filter(struct rte_eth_dev *dev)\n \t\ttxgbe_remove_5tuple_filter(dev, p_5tuple);\n }\n \n+/* remove all the ether type filters */\n+void\n+txgbe_clear_all_ethertype_filter(struct rte_eth_dev *dev)\n+{\n+\tstruct txgbe_hw *hw = TXGBE_DEV_HW(dev);\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(dev);\n+\tint i;\n+\n+\tfor (i = 0; i < TXGBE_ETF_ID_MAX; i++) {\n+\t\tif (filter_info->ethertype_mask & (1 << i) &&\n+\t\t !filter_info->ethertype_filters[i].conf) {\n+\t\t\t(void)txgbe_ethertype_filter_remove(filter_info,\n+\t\t\t\t\t\t\t (uint8_t)i);\n+\t\t\twr32(hw, TXGBE_ETFLT(i), 0);\n+\t\t\twr32(hw, TXGBE_ETCLS(i), 0);\n+\t\t\ttxgbe_flush(hw);\n+\t\t}\n+\t}\n+}\n+\n static const struct eth_dev_ops txgbe_eth_dev_ops = {\n \t.dev_configure = txgbe_dev_configure,\n \t.dev_infos_get = txgbe_dev_info_get,\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 7f96aef43..980c4b450 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -317,6 +317,10 @@ bool txgbe_rss_update_sp(enum txgbe_mac_type mac_type);\n int txgbe_add_del_ntuple_filter(struct rte_eth_dev *dev,\n \t\t\tstruct rte_eth_ntuple_filter *filter,\n \t\t\tbool add);\n+int txgbe_add_del_ethertype_filter(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_eth_ethertype_filter *filter,\n+\t\t\tbool add);\n+\n void txgbe_set_ivar_map(struct txgbe_hw *hw, int8_t direction,\n \t\t\t uint8_t queue, uint8_t msix_vector);\n \n@@ -337,6 +341,7 @@ int txgbe_pf_host_configure(struct rte_eth_dev *eth_dev);\n \n uint32_t txgbe_convert_vm_rx_mask_to_val(uint16_t rx_mask, uint32_t orig_val);\n \n+void txgbe_clear_all_ethertype_filter(struct rte_eth_dev *dev);\n void txgbe_clear_all_ntuple_filter(struct rte_eth_dev *dev);\n \n int txgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf,\n@@ -381,6 +386,20 @@ txgbe_ethertype_filter_insert(struct txgbe_filter_info *filter_info,\n \treturn (i < TXGBE_ETF_ID_MAX ? i : -1);\n }\n \n+static inline int\n+txgbe_ethertype_filter_remove(struct txgbe_filter_info *filter_info,\n+\t\t\t uint8_t idx)\n+{\n+\tif (idx >= TXGBE_ETF_ID_MAX)\n+\t\treturn -1;\n+\tfilter_info->ethertype_mask &= ~(1 << idx);\n+\tfilter_info->ethertype_filters[idx].ethertype = 0;\n+\tfilter_info->ethertype_filters[idx].etqf = 0;\n+\tfilter_info->ethertype_filters[idx].etqs = 0;\n+\tfilter_info->ethertype_filters[idx].etqs = FALSE;\n+\treturn idx;\n+}\n+\n /* High threshold controlling when to start sending XOFF frames. */\n #define TXGBE_FC_XOFF_HITH 128 /*KB*/\n /* Low threshold controlling when to start sending XON frames. */\n", "prefixes": [ "v2", "05/37" ] }