Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83943/?format=api
{ "id": 83943, "url": "http://patches.dpdk.org/api/patches/83943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-2-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201111064936.768604-2-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201111064936.768604-2-jiawenwu@trustnetic.com", "date": "2020-11-11T06:49:00", "name": "[v2,01/37] net/txgbe: add ntuple filter init and uninit", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c91bf0a876158116f128557ea75db96919461629", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201111064936.768604-2-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 13798, "url": "http://patches.dpdk.org/api/series/13798/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13798", "date": "2020-11-11T06:49:00", "name": "net: add txgbe PMD part 2", "version": 2, "mbox": "http://patches.dpdk.org/series/13798/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83943/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7DCA2A09D2;\n\tWed, 11 Nov 2020 07:47:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 59FD231FC;\n\tWed, 11 Nov 2020 07:47:29 +0100 (CET)", "from smtpproxy21.qq.com (smtpbg702.qq.com [203.205.195.102])\n by dpdk.org (Postfix) with ESMTP id C0AAD2AB\n for <dev@dpdk.org>; Wed, 11 Nov 2020 07:47:26 +0100 (CET)", "from localhost.localdomain.com (unknown [183.129.236.74])\n by esmtp10.qq.com (ESMTP) with\n id ; Wed, 11 Nov 2020 14:47:21 +0800 (CST)" ], "X-QQ-mid": "bizesmtp27t1605077241tun95pvw", "X-QQ-SSF": "01400000000000C0C000B00A0000000", "X-QQ-FEAT": "AssxAycWZ29vn4whqUc0v3tsIUk7chErVMm5UqWVk4Vx23vY9z7hWo+WeZzzn\n 0NTGSSf1RVbKpL1ILDOElur0Z4CtzKZM/G2tGE/MjeF0X/UcnM72TbvNz6t5xmaZCLHxUhK\n KIxjNHCKHc3f116etpUSbZ6kchaNz6RJa5AtMHyprF68nRaP8HRw1svxtEynHXfH8CQwgyo\n d4ga61nYbQFwqMAp6DBszT0AF04zRNIECY1V+KulJXEJTqAV08i/8dCXV25fMuzz51LgnQE\n M6RTUMey5L5zRuSCxg26P1GCDy4QaWR+qj2iSKczfJoVCsP3CbndgJElnzbyS3AJLwSIyZ9\n sX2CJSdETgSBcn2H2LeJ1wvWC6Q/Q==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Wed, 11 Nov 2020 14:49:00 +0800", "Message-Id": "<20201111064936.768604-2-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.18.4", "In-Reply-To": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "References": "<20201111064936.768604-1-jiawenwu@trustnetic.com>", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v2 01/37] net/txgbe: add ntuple filter init and\n\tuninit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add ntuple filter init and uninit.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/base/txgbe_type.h | 1 +\n drivers/net/txgbe/txgbe_ethdev.c | 28 ++++++++++++++++++++++++\n drivers/net/txgbe/txgbe_ethdev.h | 33 +++++++++++++++++++++++++++++\n 3 files changed, 62 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/base/txgbe_type.h\nindex b322a2cac..69aa8993a 100644\n--- a/drivers/net/txgbe/base/txgbe_type.h\n+++ b/drivers/net/txgbe/base/txgbe_type.h\n@@ -15,6 +15,7 @@\n #define TXGBE_FRAME_SIZE_DFT\t(1518) /* Default frame size, +FCS */\n #define TXGBE_NUM_POOL\t\t(64)\n #define TXGBE_PBTXSIZE_MAX\t0x00028000 /* 160KB Packet Buffer */\n+#define TXGBE_MAX_FTQF_FILTERS\t128\n #define TXGBE_TXPKT_SIZE_MAX\t0xA /* Max Tx Packet size */\n #define TXGBE_MAX_UP\t\t8\n #define TXGBE_MAX_QP\t\t(128)\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex 9f533603a..626c333e6 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -470,6 +470,7 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \tstruct txgbe_vfta *shadow_vfta = TXGBE_DEV_VFTA(eth_dev);\n \tstruct txgbe_hwstrip *hwstrip = TXGBE_DEV_HWSTRIP(eth_dev);\n \tstruct txgbe_dcb_config *dcb_config = TXGBE_DEV_DCB_CONFIG(eth_dev);\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(eth_dev);\n \tstruct txgbe_bw_conf *bw_conf = TXGBE_DEV_BW_CONF(eth_dev);\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tconst struct rte_memzone *mz;\n@@ -677,6 +678,13 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \t/* enable support intr */\n \ttxgbe_enable_intr(eth_dev);\n \n+\t/* initialize filter info */\n+\tmemset(filter_info, 0,\n+\t sizeof(struct txgbe_filter_info));\n+\n+\t/* initialize 5tuple filter list */\n+\tTAILQ_INIT(&filter_info->fivetuple_list);\n+\n \t/* initialize bandwidth configuration info */\n \tmemset(bw_conf, 0, sizeof(struct txgbe_bw_conf));\n \n@@ -696,6 +704,23 @@ eth_txgbe_dev_uninit(struct rte_eth_dev *eth_dev)\n \treturn 0;\n }\n \n+static int txgbe_ntuple_filter_uninit(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct txgbe_filter_info *filter_info = TXGBE_DEV_FILTER(eth_dev);\n+\tstruct txgbe_5tuple_filter *p_5tuple;\n+\n+\twhile ((p_5tuple = TAILQ_FIRST(&filter_info->fivetuple_list))) {\n+\t\tTAILQ_REMOVE(&filter_info->fivetuple_list,\n+\t\t\t p_5tuple,\n+\t\t\t entries);\n+\t\trte_free(p_5tuple);\n+\t}\n+\tmemset(filter_info->fivetuple_mask, 0,\n+\t sizeof(uint32_t) * TXGBE_5TUPLE_ARRAY_SIZE);\n+\n+\treturn 0;\n+}\n+\n static int\n eth_txgbe_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\tstruct rte_pci_device *pci_dev)\n@@ -1774,6 +1799,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)\n \trte_free(dev->data->hash_mac_addrs);\n \tdev->data->hash_mac_addrs = NULL;\n \n+\t/* Remove all ntuple filters of the device */\n+\ttxgbe_ntuple_filter_uninit(dev);\n+\n \treturn ret;\n }\n \ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex 696dd5a7e..4ba42a737 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -110,6 +110,36 @@ struct txgbe_vf_info {\n \tuint16_t mac_count;\n };\n \n+TAILQ_HEAD(txgbe_5tuple_filter_list, txgbe_5tuple_filter);\n+\n+struct txgbe_5tuple_filter_info {\n+\tuint32_t dst_ip;\n+\tuint32_t src_ip;\n+\tuint16_t dst_port;\n+\tuint16_t src_port;\n+\tenum txgbe_5tuple_protocol proto; /* l4 protocol. */\n+\tuint8_t priority; /* seven levels (001b-111b), 111b is highest,\n+\t\t\t\t * used when more than one filter matches.\n+\t\t\t\t */\n+\tuint8_t dst_ip_mask:1, /* if mask is 1b, do not compare dst ip. */\n+\t\tsrc_ip_mask:1, /* if mask is 1b, do not compare src ip. */\n+\t\tdst_port_mask:1, /* if mask is 1b, do not compare dst port. */\n+\t\tsrc_port_mask:1, /* if mask is 1b, do not compare src port. */\n+\t\tproto_mask:1; /* if mask is 1b, do not compare protocol. */\n+};\n+\n+/* 5tuple filter structure */\n+struct txgbe_5tuple_filter {\n+\tTAILQ_ENTRY(txgbe_5tuple_filter) entries;\n+\tuint16_t index; /* the index of 5tuple filter */\n+\tstruct txgbe_5tuple_filter_info filter_info;\n+\tuint16_t queue; /* rx queue assigned to */\n+};\n+\n+#define TXGBE_5TUPLE_ARRAY_SIZE \\\n+\t(RTE_ALIGN(TXGBE_MAX_FTQF_FILTERS, (sizeof(uint32_t) * NBBY)) / \\\n+\t (sizeof(uint32_t) * NBBY))\n+\n struct txgbe_ethertype_filter {\n \tuint16_t ethertype;\n \tuint32_t etqf;\n@@ -128,6 +158,9 @@ struct txgbe_filter_info {\n \tuint8_t ethertype_mask; /* Bit mask for every used ethertype filter */\n \t/* store used ethertype filters*/\n \tstruct txgbe_ethertype_filter ethertype_filters[TXGBE_ETF_ID_MAX];\n+\t/* Bit mask for every used 5tuple filter */\n+\tuint32_t fivetuple_mask[TXGBE_5TUPLE_ARRAY_SIZE];\n+\tstruct txgbe_5tuple_filter_list fivetuple_list;\n };\n \n /* The configuration of bandwidth */\n", "prefixes": [ "v2", "01/37" ] }