Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83914/?format=api
{ "id": 83914, "url": "http://patches.dpdk.org/api/patches/83914/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110175457.734922-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110175457.734922-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110175457.734922-1-ferruh.yigit@intel.com", "date": "2020-11-10T17:54:57", "name": "[v2] net/i40e: fix build for log format specifier", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9aa9025857883feafcc6b344fd187025dbb05ca3", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110175457.734922-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 13783, "url": "http://patches.dpdk.org/api/series/13783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13783", "date": "2020-11-10T17:54:57", "name": "[v2] net/i40e: fix build for log format specifier", "version": 2, "mbox": "http://patches.dpdk.org/series/13783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83914/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83914/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48FF2A04DD;\n\tTue, 10 Nov 2020 18:55:15 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 070482B93;\n\tTue, 10 Nov 2020 18:55:13 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 400F9F64;\n Tue, 10 Nov 2020 18:55:09 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Nov 2020 09:55:03 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.180])\n by fmsmga005.fm.intel.com with ESMTP; 10 Nov 2020 09:54:59 -0800" ], "IronPort-SDR": [ "\n qDwPtkTqEJE+6Jjb67+FErqNdVW59yS5Z05MQwMIqe5F1kqHeqwtFl3Wu/Fd37MScErMJQUx23\n BXqhkjViS9WQ==", "\n ygGTI8m9PwV/CSTJJWJwb0KtvmKHC5miQpDshuJY/tYFu3vlj3mgCsrPbBDfQ9kScpR228LH2n\n YhP04nzAi35w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9801\"; a=\"187988682\"", "E=Sophos;i=\"5.77,467,1596524400\"; d=\"scan'208\";a=\"187988682\"", "E=Sophos;i=\"5.77,467,1596524400\"; d=\"scan'208\";a=\"531320234\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>,\n Helin Zhang <helin.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,\n Remy Horton <remy.horton@intel.com>, Jijiang Liu <jijiang.liu@intel.com>,\n Jing Chen <jing.d.chen@intel.com>, Heqing Zhu <heqing.zhu@intel.com>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, stable@dpdk.org,\n Luca Boccassi <bluca@debian.org>,\n David Marchand <david.marchand@redhat.com>", "Date": "Tue, 10 Nov 2020 17:54:57 +0000", "Message-Id": "<20201110175457.734922-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20201110134852.3959367-1-ferruh.yigit@intel.com>", "References": "<20201110134852.3959367-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: fix build for log format specifier", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Build error:\ni40e_common.c: In function \"i40e_parse_discover_capabilities\":\n../drivers/net/i40e/base/../i40e_logs.h:43:50:\n error: format \"%llX\" expects argument of type \"long long unsigned\n int\", but argument 7 has type \"u64\" {aka \"long unsigned int\"\n [-Werror=format=]\n 43 | rte_log(RTE_LOG_ ## level, i40e_logtype_driver, \"%s(): \" fmt, \\\n | ^~~~~~~~\n.../i40e_osdep.h:87:3: note: in expansion of macro \"PMD_DRV_LOG_RAW\"\n 87 | PMD_DRV_LOG_RAW(DEBUG, \"i40e %02x.%x \" s, \\\n | ^~~~~~~~~~~~~~~\n.../base/i40e_common.c:4100:4: note: in expansion of macro \"i40e_debug\"\n 4100 | i40e_debug(hw, I40E_DEBUG_INIT,\n | ^~~~~~~~~~\n\nThere are multiple build error because of same reason, all fixed.\n\nUsing 'PRIX64' to fix the build error.\n\nFixes: 889bc9f0cd3a (\"i40e/base: unify the capability function\")\nFixes: 9b1041574cd4 (\"i40e/base: enhance polling of NVM semaphore\")\nFixes: 8db9e2a1b232 (\"i40e: base driver\")\nFixes: 3b7271f3958a (\"i40e/base: catch NVM write semaphore timeout and retry\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nCc: helin.zhang@intel.com\nCc: Luca Boccassi <bluca@debian.org>\nCc: David Marchand <david.marchand@redhat.com>\n\nv2:\n* Fix more build error from same reason\n---\n drivers/net/i40e/base/i40e_common.c | 4 +++-\n drivers/net/i40e/base/i40e_nvm.c | 8 +++++---\n 2 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 8e3db0756c..e20bb9ac35 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2001-2020 Intel Corporation\n */\n \n+#include <inttypes.h>\n+\n #include \"i40e_type.h\"\n #include \"i40e_adminq.h\"\n #include \"i40e_prototype.h\"\n@@ -4098,7 +4100,7 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,\n \t\t\tp->wr_csr_prot = (u64)number;\n \t\t\tp->wr_csr_prot |= (u64)logical_id << 32;\n \t\t\ti40e_debug(hw, I40E_DEBUG_INIT,\n-\t\t\t\t \"HW Capability: wr_csr_prot = 0x%llX\\n\\n\",\n+\t\t\t\t \"HW Capability: wr_csr_prot = 0x%\" PRIX64 \"\\n\\n\",\n \t\t\t\t (p->wr_csr_prot & 0xffff));\n \t\t\tbreak;\n \t\tcase I40E_AQ_CAP_ID_DIS_UNUSED_PORTS:\ndiff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c\nindex 6466d86486..561ed21136 100644\n--- a/drivers/net/i40e/base/i40e_nvm.c\n+++ b/drivers/net/i40e/base/i40e_nvm.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2001-2020 Intel Corporation\n */\n \n+#include <inttypes.h>\n+\n #include \"i40e_prototype.h\"\n \n /**\n@@ -77,7 +79,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,\n \n \tif (ret_code)\n \t\ti40e_debug(hw, I40E_DEBUG_NVM,\n-\t\t\t \"NVM acquire type %d failed time_left=%llu ret=%d aq_err=%d\\n\",\n+\t\t\t \"NVM acquire type %d failed time_left=%\" PRIu64 \" ret=%d aq_err=%d\\n\",\n \t\t\t access, time_left, ret_code, hw->aq.asq_last_status);\n \n \tif (ret_code && time_left) {\n@@ -99,7 +101,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,\n \t\tif (ret_code != I40E_SUCCESS) {\n \t\t\thw->nvm.hw_semaphore_timeout = 0;\n \t\t\ti40e_debug(hw, I40E_DEBUG_NVM,\n-\t\t\t\t \"NVM acquire timed out, wait %llu ms before trying again. status=%d aq_err=%d\\n\",\n+\t\t\t\t \"NVM acquire timed out, wait %\" PRIu64 \" ms before trying again. status=%d aq_err=%d\\n\",\n \t\t\t\t time_left, ret_code, hw->aq.asq_last_status);\n \t\t}\n \t}\n@@ -1300,7 +1302,7 @@ STATIC enum i40e_status_code i40e_nvmupd_state_writing(struct i40e_hw *hw,\n \t\tgtime = rd32(hw, I40E_GLVFGEN_TIMER);\n \t\tif (gtime >= hw->nvm.hw_semaphore_timeout) {\n \t\t\ti40e_debug(hw, I40E_DEBUG_ALL,\n-\t\t\t\t \"NVMUPD: write semaphore expired (%d >= %lld), retrying\\n\",\n+\t\t\t\t \"NVMUPD: write semaphore expired (%d >= %\" PRIu64 \"), retrying\\n\",\n \t\t\t\t gtime, hw->nvm.hw_semaphore_timeout);\n \t\t\ti40e_release_nvm(hw);\n \t\t\tstatus = i40e_acquire_nvm(hw, I40E_RESOURCE_WRITE);\n", "prefixes": [ "v2" ] }