Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8391,
    "url": "http://patches.dpdk.org/api/patches/8391/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1446210879-14242-3-git-send-email-jijiang.liu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1446210879-14242-3-git-send-email-jijiang.liu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1446210879-14242-3-git-send-email-jijiang.liu@intel.com",
    "date": "2015-10-30T13:14:39",
    "name": "[dpdk-dev,v2,2/2] lib/lpm:fix an initialization issue of valid_group in the delete_depth_small()",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "f773243bf0190d7678d3ecff3f423aec5b6f8a0e",
    "submitter": {
        "id": 52,
        "url": "http://patches.dpdk.org/api/people/52/?format=api",
        "name": "Jijiang Liu",
        "email": "jijiang.liu@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1446210879-14242-3-git-send-email-jijiang.liu@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/8391/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/8391/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 43FCD8EA0;\n\tFri, 30 Oct 2015 14:14:53 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 444648E9F\n\tfor <dev@dpdk.org>; Fri, 30 Oct 2015 14:14:52 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 30 Oct 2015 06:14:51 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 30 Oct 2015 06:14:50 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9UDEokS021663;\n\tFri, 30 Oct 2015 21:14:50 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9UDElGT014291; Fri, 30 Oct 2015 21:14:49 +0800",
            "(from jijiangl@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9UDEkbg014287; \n\tFri, 30 Oct 2015 21:14:46 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.20,218,1444719600\"; d=\"scan'208\";a=\"807472138\"",
        "From": "Jijiang Liu <jijiang.liu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 30 Oct 2015 21:14:39 +0800",
        "Message-Id": "<1446210879-14242-3-git-send-email-jijiang.liu@intel.com>",
        "X-Mailer": "git-send-email 1.7.12.2",
        "In-Reply-To": "<1446210879-14242-1-git-send-email-jijiang.liu@intel.com>",
        "References": "<1446210879-14242-1-git-send-email-jijiang.liu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue of\n\tvalid_group in the delete_depth_small()",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fixes an initialization issue of 'valid_group' in the delete_depth_small function.\n\nIn this function, use new rte_lpm_tbl8_entry we call A to replace the old rte_lpm_tbl8_entry. But the valid_group do not set VALID, so it \nwill be INVALID.\n\nThen when adding a new route which depth is > 24,the tbl8_alloc() function will search the rte_lpm_tbl8_entrys to find INVALID \nvalid_group, and it will return the A to the add_depth_big function, so A's data is overridden.\n\nSigned-off-by: NaNa <nana.nn@alibaba-inc.com>\n\n---\n lib/librte_lpm/rte_lpm.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)",
    "diff": "diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c\nindex 57ec2f0..3981452 100644\n--- a/lib/librte_lpm/rte_lpm.c\n+++ b/lib/librte_lpm/rte_lpm.c\n@@ -769,6 +769,7 @@ delete_depth_small(struct rte_lpm *lpm, uint32_t ip_masked,\n \n \t\tstruct rte_lpm_tbl8_entry new_tbl8_entry = {\n \t\t\t.valid = VALID,\n+\t\t\t.valid_group = VALID,\n \t\t\t.depth = sub_rule_depth,\n \t\t\t.next_hop = lpm->rules_tbl\n \t\t\t[sub_rule_index].next_hop,\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/2"
    ]
}