Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83884/?format=api
{ "id": 83884, "url": "http://patches.dpdk.org/api/patches/83884/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110110313.1924365-1-conor.walsh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110110313.1924365-1-conor.walsh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110110313.1924365-1-conor.walsh@intel.com", "date": "2020-11-10T11:03:13", "name": "[v2] app/test: fix to prevent zcd gcc compile error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d5bc77894edabbe0108dd16f3c5d85d118b49bd", "submitter": { "id": 1935, "url": "http://patches.dpdk.org/api/people/1935/?format=api", "name": "Conor Walsh", "email": "conor.walsh@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110110313.1924365-1-conor.walsh@intel.com/mbox/", "series": [ { "id": 13771, "url": "http://patches.dpdk.org/api/series/13771/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13771", "date": "2020-11-10T11:03:13", "name": "[v2] app/test: fix to prevent zcd gcc compile error", "version": 2, "mbox": "http://patches.dpdk.org/series/13771/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83884/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83884/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 14559A0526;\n\tTue, 10 Nov 2020 12:03:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E3762F90;\n\tTue, 10 Nov 2020 12:03:21 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 6DC5F2AB\n for <dev@dpdk.org>; Tue, 10 Nov 2020 12:03:19 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Nov 2020 03:03:17 -0800", "from silpixa00400466.ir.intel.com ([10.237.213.98])\n by fmsmga004.fm.intel.com with ESMTP; 10 Nov 2020 03:03:15 -0800" ], "IronPort-SDR": [ "\n fwoJLEJjWY6Zn1DvQMkSgedTZw5RJ7LGZpcElISbRTPVS2JakL9DfoK0WQz/KQ1pgowlBSLHlF\n xY0uKE934GBw==", "\n XPZLpl+UD9VHBOkPEOBOoHETzJXBUwrVIRXQBPPnvVoOopuP2m6F2L1ixZ36kAaz2+9U7RE3fr\n le0ZToaI2ESg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9800\"; a=\"156961142\"", "E=Sophos;i=\"5.77,466,1596524400\"; d=\"scan'208\";a=\"156961142\"", "E=Sophos;i=\"5.77,466,1596524400\"; d=\"scan'208\";a=\"356096678\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Conor Walsh <conor.walsh@intel.com>", "To": "honnappa.nagarahalli@arm.com,\n\tkonstantin.ananyev@intel.com", "Cc": "dev@dpdk.org, linglix.chen@intel.com, Conor Walsh <conor.walsh@intel.com>", "Date": "Tue, 10 Nov 2020 11:03:13 +0000", "Message-Id": "<20201110110313.1924365-1-conor.walsh@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201104170306.1688771-1-conor.walsh@intel.com>", "References": "<20201104170306.1688771-1-conor.walsh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When DPDK is compiled with gcc < 9 with the optimization level set to 1\ngcc sees zcd in test_ring.h as possibly being uninitialised. To correct\nthis error if statements from _st_ring_dequeue_bulk and\n_st_ring_enqueue_bulk were corrected within test_ring_mt_peek_stress_zc.c\n\nSigned-off-by: Conor Walsh <conor.walsh@intel.com>\n\n---\n\nv2: Moved from initialising zcd to changing if statements within\n test_ring_mt_peek_stress_zc.c following list feedback as the\n original method used may have masked errors within the library.\n---\n app/test/test_ring_mt_peek_stress_zc.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_ring_mt_peek_stress_zc.c b/app/test/test_ring_mt_peek_stress_zc.c\nindex 7e0bd511a7..85f0262ba0 100644\n--- a/app/test/test_ring_mt_peek_stress_zc.c\n+++ b/app/test/test_ring_mt_peek_stress_zc.c\n@@ -14,8 +14,7 @@ _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, uint32_t n,\n \tstruct rte_ring_zc_data zcd;\n \n \tm = rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail);\n-\tn = (m == n) ? n : 0;\n-\tif (n != 0) {\n+\tif (m != 0) {\n \t\t/* Copy the data from the ring */\n \t\ttest_ring_copy_from(&zcd, obj, -1, n);\n \t\trte_ring_dequeue_zc_finish(r, n);\n@@ -32,8 +31,7 @@ _st_ring_enqueue_bulk(struct rte_ring *r, void * const *obj, uint32_t n,\n \tstruct rte_ring_zc_data zcd;\n \n \tm = rte_ring_enqueue_zc_bulk_start(r, n, &zcd, free);\n-\tn = (m == n) ? n : 0;\n-\tif (n != 0) {\n+\tif (m != 0) {\n \t\t/* Copy the data from the ring */\n \t\ttest_ring_copy_to(&zcd, obj, -1, n);\n \t\trte_ring_enqueue_zc_finish(r, n);\n", "prefixes": [ "v2" ] }