Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83882/?format=api
http://patches.dpdk.org/api/patches/83882/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110084503.1320021-1-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110084503.1320021-1-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110084503.1320021-1-junfeng.guo@intel.com", "date": "2020-11-10T08:45:03", "name": "net/ice: fix mismatched hash flds with hdrs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd2165d9b2e88946e0c16b8365b677aacdb4c649", "submitter": { "id": 1785, "url": "http://patches.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110084503.1320021-1-junfeng.guo@intel.com/mbox/", "series": [ { "id": 13769, "url": "http://patches.dpdk.org/api/series/13769/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13769", "date": "2020-11-10T08:45:03", "name": "net/ice: fix mismatched hash flds with hdrs", "version": 1, "mbox": "http://patches.dpdk.org/series/13769/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83882/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1B629A04E6;\n\tTue, 10 Nov 2020 09:47:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4EEF3F64;\n\tTue, 10 Nov 2020 09:47:30 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id C9A002AB\n for <dev@dpdk.org>; Tue, 10 Nov 2020 09:47:28 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Nov 2020 00:47:26 -0800", "from dpdk-junfengguo-v3.sh.intel.com ([10.67.119.146])\n by fmsmga008.fm.intel.com with ESMTP; 10 Nov 2020 00:47:24 -0800" ], "IronPort-SDR": [ "\n h3JoU/zJWmaBtupcHuyJxxQoGHDSHVGpB5nIBUVLjv1R7M02qwOmtOM7YG4cBHylVChP441Cum\n Z+3OZqGAoEBQ==", "\n cDECXQRl4oCNfS4G5QYDPHlHVfThyy3msYkq3TRXz6CKlAQFU3qaDA/9zh6B8zFFVHwfaGjwrV\n oFVLT3caIpsw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9800\"; a=\"231568144\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"231568144\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"307974783\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tjingjing.wu@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tjunfeng.guo@intel.com", "Date": "Tue, 10 Nov 2020 16:45:03 +0800", "Message-Id": "<20201110084503.1320021-1-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice: fix mismatched hash flds with hdrs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous code in ice_rss_hash_set has mismatched hash fields and\nheaders for UDP and TCP.\n\nFixes: 16187528a923 (\"net/ice/base: refactor RSS configure API\")\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 1e15cd3960..9a5d6a559f 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3068,7 +3068,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)\n \tif (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) {\n \t\tcfg.addl_hdrs = ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_UDP |\n \t\t\t\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER;\n-\t\tcfg.hash_flds = ICE_FLOW_HASH_IPV4;\n+\t\tcfg.hash_flds = ICE_HASH_UDP_IPV4;\n \t\tret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);\n \t\tif (ret)\n \t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV4_UDP rss flow fail %d\",\n@@ -3092,7 +3092,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)\n \tif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) {\n \t\tcfg.addl_hdrs = ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_UDP |\n \t\t\t\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER;\n-\t\tcfg.hash_flds = ICE_FLOW_HASH_IPV6;\n+\t\tcfg.hash_flds = ICE_HASH_UDP_IPV6;\n \t\tret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);\n \t\tif (ret)\n \t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV6_UDP rss flow fail %d\",\n@@ -3116,7 +3116,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)\n \tif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) {\n \t\tcfg.addl_hdrs = ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_TCP |\n \t\t\t\tICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_OTHER;\n-\t\tcfg.hash_flds = ICE_FLOW_HASH_IPV4;\n+\t\tcfg.hash_flds = ICE_HASH_TCP_IPV4;\n \t\tret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);\n \t\tif (ret)\n \t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV4_TCP rss flow fail %d\",\n@@ -3140,7 +3140,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)\n \tif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) {\n \t\tcfg.addl_hdrs = ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_TCP |\n \t\t\t\tICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_OTHER;\n-\t\tcfg.hash_flds = ICE_FLOW_HASH_IPV6;\n+\t\tcfg.hash_flds = ICE_HASH_TCP_IPV6;\n \t\tret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);\n \t\tif (ret)\n \t\t\tPMD_DRV_LOG(ERR, \"%s GTPU_IPV6_TCP rss flow fail %d\",\n", "prefixes": [] }{ "id": 83882, "url": "