Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83880/?format=api
http://patches.dpdk.org/api/patches/83880/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1604990761-61335-1-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1604990761-61335-1-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1604990761-61335-1-git-send-email-wenzhuo.lu@intel.com", "date": "2020-11-10T06:46:01", "name": "net/iavf: fix missed pointer check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dcfe6ad151ace37995c72b2f3ed16fdefc496414", "submitter": { "id": 258, "url": "http://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1604990761-61335-1-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [ { "id": 13767, "url": "http://patches.dpdk.org/api/series/13767/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13767", "date": "2020-11-10T06:46:01", "name": "net/iavf: fix missed pointer check", "version": 1, "mbox": "http://patches.dpdk.org/series/13767/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83880/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9570CA052A;\n\tTue, 10 Nov 2020 07:46:45 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 569C55928;\n\tTue, 10 Nov 2020 07:46:34 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 4A2735913\n for <dev@dpdk.org>; Tue, 10 Nov 2020 07:46:33 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Nov 2020 22:46:30 -0800", "from dpdk-wenzhuo-haswell.sh.intel.com ([10.67.111.137])\n by orsmga004.jf.intel.com with ESMTP; 09 Nov 2020 22:46:28 -0800" ], "IronPort-SDR": [ "\n fa0vKyVPNehmpfc5OQeYE9CGYvUOtbUfmjR5ShAancFX66xzA6JhaCa4DaCEBe1usqVaFFUiCI\n +bmXxOhBoHrg==", "\n +VfrRaCCAlLaT+yISzTODcvjF6rF1avGaZs8f1oCErciXhEenQXuFtIbtRChylJyupDZ7cfqKS\n RoymCI0pVkcA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9800\"; a=\"157708186\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"157708186\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"473309917\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "Date": "Tue, 10 Nov 2020 14:46:01 +0800", "Message-Id": "<1604990761-61335-1-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.9.3", "Subject": "[dpdk-dev] [PATCH] net/iavf: fix missed pointer check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The return value of rte_mempool_default_cache should be\nchecked as it can be NULL.\n\nFixes: 9ab9514c150e (\"net/iavf: enable AVX512 for Tx\")\n\nReported-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\nindex 8680734..584d12e 100644\n--- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n+++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c\n@@ -1424,7 +1424,12 @@\n \t\tstruct rte_mempool *mp = txep[0].mbuf->pool;\n \t\tstruct rte_mempool_cache *cache = rte_mempool_default_cache(mp,\n \t\t\t\t\t\t\t\trte_lcore_id());\n-\t\tvoid **cache_objs = &cache->objs[cache->len];\n+\t\tvoid **cache_objs;\n+\n+\t\tif (!cache || cache->len == 0)\n+\t\t\tgoto normal;\n+\n+\t\tcache_objs = &cache->objs[cache->len];\n \n \t\tif (n > RTE_MEMPOOL_CACHE_MAX_SIZE) {\n \t\t\trte_mempool_ops_enqueue_bulk(mp, (void *)txep, n);\n@@ -1462,6 +1467,7 @@\n \t\tgoto done;\n \t}\n \n+normal:\n \tm = rte_pktmbuf_prefree_seg(txep[0].mbuf);\n \tif (likely(m)) {\n \t\tfree[0] = m;\n", "prefixes": [] }{ "id": 83880, "url": "