Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83869/?format=api
{ "id": 83869, "url": "http://patches.dpdk.org/api/patches/83869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201110020150.173762-1-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201110020150.173762-1-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201110020150.173762-1-simei.su@intel.com", "date": "2020-11-10T02:01:50", "name": "net/ice: fix core dump when device reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "51491f950acf77307bcd83a095a4f6a262477259", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201110020150.173762-1-simei.su@intel.com/mbox/", "series": [ { "id": 13759, "url": "http://patches.dpdk.org/api/series/13759/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13759", "date": "2020-11-10T02:01:50", "name": "net/ice: fix core dump when device reset", "version": 1, "mbox": "http://patches.dpdk.org/series/13759/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83869/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C27EBA052A;\n\tTue, 10 Nov 2020 03:11:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A242A8E9;\n\tTue, 10 Nov 2020 03:11:21 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 82BE072E2\n for <dev@dpdk.org>; Tue, 10 Nov 2020 03:11:18 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Nov 2020 18:11:17 -0800", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.119.195])\n by fmsmga004.fm.intel.com with ESMTP; 09 Nov 2020 18:11:16 -0800" ], "IronPort-SDR": [ "\n GQQeCc6tmu/Y9X40aacTqrKBzo3nzGoBeleIHRWO55b5x3qh41StZSvSZNqnyCareb0X264evq\n se3zbv89NoBg==", "\n sOUm781+8kYW7n3uhyfka9JSLEs/Ds6AeZIYfoF9SsRcYLgABLLVlKGksUPc4N20bQ4GWe0drN\n gqRkswZpjRlg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9800\"; a=\"166394147\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"166394147\"", "E=Sophos;i=\"5.77,465,1596524400\"; d=\"scan'208\";a=\"355947444\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, haiyue.wang@intel.com, xuan.ding@intel.com,\n Simei Su <simei.su@intel.com>", "Date": "Tue, 10 Nov 2020 10:01:50 +0800", "Message-Id": "<20201110020150.173762-1-simei.su@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH] net/ice: fix core dump when device reset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When device resets, it should not implememt ACL initialization\nwhich is only executed in DCF. This patch disable ACL init and\nuninit when in DPDK PF only mode.\n\nFixes: 40d466fa9f76 (\"net/ice: support ACL filter in DCF\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/ice/ice_acl_filter.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_acl_filter.c b/drivers/net/ice/ice_acl_filter.c\nindex ca483f0..8ca88d2 100644\n--- a/drivers/net/ice/ice_acl_filter.c\n+++ b/drivers/net/ice/ice_acl_filter.c\n@@ -935,6 +935,9 @@ ice_acl_init(struct ice_adapter *ad)\n \tstruct ice_hw *hw = ICE_PF_TO_HW(pf);\n \tstruct ice_flow_parser *parser = &ice_acl_parser;\n \n+\tif (!ad->hw.dcf_enabled)\n+\t\treturn 0;\n+\n \tret = ice_acl_prof_alloc(hw);\n \tif (ret) {\n \t\tPMD_DRV_LOG(ERR, \"Cannot allocate memory for \"\n@@ -979,10 +982,11 @@ ice_acl_uninit(struct ice_adapter *ad)\n \tstruct ice_hw *hw = ICE_PF_TO_HW(pf);\n \tstruct ice_flow_parser *parser = &ice_acl_parser;\n \n-\tice_unregister_parser(parser, ad);\n-\n-\tice_deinit_acl(pf);\n-\tice_acl_prof_free(hw);\n+\tif (ad->hw.dcf_enabled) {\n+\t\tice_unregister_parser(parser, ad);\n+\t\tice_deinit_acl(pf);\n+\t\tice_acl_prof_free(hw);\n+\t}\n }\n \n static struct\n", "prefixes": [] }