Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83863/?format=api
{ "id": 83863, "url": "http://patches.dpdk.org/api/patches/83863/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201109212937.989954-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201109212937.989954-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201109212937.989954-2-thomas@monjalon.net", "date": "2020-11-09T21:29:36", "name": "[v2,1/2] drivers: disable OCTEON TX2 in 32-bit build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c257c2f1ab3e3290d39ef3ee448935b52e258bf2", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201109212937.989954-2-thomas@monjalon.net/mbox/", "series": [ { "id": 13754, "url": "http://patches.dpdk.org/api/series/13754/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13754", "date": "2020-11-09T21:29:35", "name": "move mbuf pool pointer", "version": 2, "mbox": "http://patches.dpdk.org/series/13754/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83863/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83863/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0E2D9A0527;\n\tMon, 9 Nov 2020 22:30:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6209B72E9;\n\tMon, 9 Nov 2020 22:29:55 +0100 (CET)", "from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com\n [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 0BA3C6A6F\n for <dev@dpdk.org>; Mon, 9 Nov 2020 22:29:50 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailnew.nyi.internal (Postfix) with ESMTP id A2DBB5809B2;\n Mon, 9 Nov 2020 16:29:49 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Mon, 09 Nov 2020 16:29:49 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id C3253306301C;\n Mon, 9 Nov 2020 16:29:47 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=dAID93QLU6U2T\n CN8MH9UnqMZncPr4zCsttfX0evoQVk=; b=rUPQ4vrLykK0czV9Bel0TltS6zYcp\n ifPE3gXOYz22jvGOzv800RxK39aihCV64dMHu3ylQK13/2O446nRGjwK47n+r0PW\n Ycl6SbQ8OEmQhMWg7ERefmeyALNLdOr0RgtBoTbrpv0hDhKh3+pnLFVnsrykdt/j\n o6xjbccb5+ZrcRS+y8/bUipFOj+Mva54fOvuu8vTonffa0am1jgv1IBDPVTkaSH5\n 9lVu2MtQm2R8JC8F3SaP0rUUAMdhRwrWJjFKuOExXvyUVl9mdzH9RtPHJoLvLWSb\n D0TeBmsElnGPNyj7/RLWkqh1z9tSinW8XpBn5fz+XI/s+733ksofF8GmA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=dAID93QLU6U2TCN8MH9UnqMZncPr4zCsttfX0evoQVk=; b=NAxlsJwO\n rXR3y4sKf8R4XiafIx/jCVv5lyhR8K0HscCWsHvjUmuicBb1vJ83zWHdfaRlWNuB\n Suy5wyTdsmMcKVtsaMc1cMWjdIy4cQ1XluIrVbYXnLEoZa8iTd5rL4KGNccJpLvV\n 5Aan3A3oDN4d+McOhkDXD10NuJYzIKSmP8Q3MvVdocnbtk5LscKS4fhkFc/aN4At\n bukJK7utXH/3S/0YKlEU39VEcB0vohqYWBuOz/rdt7U48P5hzrkuy7yBuW4qaq0k\n FAB+y1z7jNp5jQj0RiB6t2tWRHx6YQH0Z1ZJzFSEKnLzlMXGOaRsTk5zpvvToLJO\n uctAcFKw/Q/dFg==" ], "X-ME-Sender": "<xms:zbSpXyhN28-va72DPSQtxx1Ax6iTcP_DL0JOalgRr-4WQZLSen9Zag>\n <xme:zbSpXzDmh6CukxwL0mL0WSunVPqFBluM1ItCqDJJoAQVI8UIBLx83JOQa4YjJNygg\n Hlkll6nAkIqDPrTHA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrudduhedgudehvdcutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedt\n gfeutdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh\n fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:zbSpX6F6TD7MS3Q0EhS3Dy8wdhEIMWnLoT9qWiaE19QRCSsL5QmIRg>\n <xmx:zbSpX7RIDCwOBQIVEYpsRUZEzUNks4HeMPBlR352z3-7bQ8A2S1ERg>\n <xmx:zbSpX_xwwCQfdnrCuor7YWAEz-7l594r3mih6y8v0ltWJCeR00H_1A>\n <xmx:zbSpX0L4NIOvcFnyXantT8JN_9kkx3GDAhYI0tPIQPK6TWyjTo2kIQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, ferruh.yigit@intel.com, olivier.matz@6wind.com,\n mb@smartsharesystems.com, konstantin.ananyev@intel.com,\n andrew.rybchenko@oktetlabs.ru, viacheslavo@nvidia.com,\n ajit.khaparde@broadcom.com, jerinj@marvell.com, hemant.agrawal@nxp.com,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Ankur Dwivedi <adwivedi@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>, Guy Kaneti <guyk@marvell.com>", "Date": "Mon, 9 Nov 2020 22:29:36 +0100", "Message-Id": "<20201109212937.989954-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201109212937.989954-1-thomas@monjalon.net>", "References": "<20201107155306.463148-1-thomas@monjalon.net>\n <20201109212937.989954-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit\n\tbuild", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The drivers for OCTEON TX2 are not supported in 32-bit mode.\n\nSuggested-by: Jerin Jacob <jerinj@marvell.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/common/octeontx2/meson.build | 18 ++++++------------\n drivers/crypto/octeontx2/meson.build | 17 +++--------------\n drivers/event/octeontx2/meson.build | 18 ++++++------------\n drivers/mempool/octeontx2/meson.build | 18 ++++++------------\n drivers/net/octeontx2/meson.build | 11 ++++++-----\n drivers/regex/octeontx2/meson.build | 22 +++-------------------\n 6 files changed, 30 insertions(+), 74 deletions(-)", "diff": "diff --git a/drivers/common/octeontx2/meson.build b/drivers/common/octeontx2/meson.build\nindex f2c04342e9..84fb11524d 100644\n--- a/drivers/common/octeontx2/meson.build\n+++ b/drivers/common/octeontx2/meson.build\n@@ -2,6 +2,12 @@\n # Copyright(C) 2019 Marvell International Ltd.\n #\n \n+if not dpdk_conf.get('RTE_ARCH_64')\n+\tbuild = false\n+\treason = 'only supported on 64-bit'\n+\tsubdir_done()\n+endif\n+\n sources= files('otx2_dev.c',\n \t\t'otx2_irq.c',\n \t\t'otx2_mbox.c',\n@@ -9,18 +15,6 @@ sources= files('otx2_dev.c',\n \t\t'otx2_sec_idev.c',\n \t )\n \n-extra_flags = []\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n-foreach flag: extra_flags\n-\tif cc.has_argument(flag)\n-\t\tcflags += flag\n-\tendif\n-endforeach\n-\n deps = ['eal', 'pci', 'ethdev', 'kvargs']\n includes += include_directories('../../common/octeontx2',\n \t\t'../../mempool/octeontx2', '../../bus/pci')\ndiff --git a/drivers/crypto/octeontx2/meson.build b/drivers/crypto/octeontx2/meson.build\nindex 4e4522cace..0aad4e9a16 100644\n--- a/drivers/crypto/octeontx2/meson.build\n+++ b/drivers/crypto/octeontx2/meson.build\n@@ -1,9 +1,10 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright (C) 2019 Marvell International Ltd.\n \n-if not is_linux\n+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')\n \tbuild = false\n-\treason = 'only supported on Linux'\n+\treason = 'only supported on 64-bit Linux'\n+\tsubdir_done()\n endif\n \n deps += ['bus_pci']\n@@ -21,18 +22,6 @@ sources = files('otx2_cryptodev.c',\n \t\t'otx2_cryptodev_ops.c',\n \t\t'otx2_cryptodev_sec.c')\n \n-extra_flags = []\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n-foreach flag: extra_flags\n-\tif cc.has_argument(flag)\n-\t\tcflags += flag\n-\tendif\n-endforeach\n-\n includes += include_directories('../../common/cpt')\n includes += include_directories('../../common/octeontx2')\n includes += include_directories('../../crypto/octeontx2')\ndiff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build\nindex 724da2e6b7..22e7e4cb63 100644\n--- a/drivers/event/octeontx2/meson.build\n+++ b/drivers/event/octeontx2/meson.build\n@@ -2,6 +2,12 @@\n # Copyright(C) 2019 Marvell International Ltd.\n #\n \n+if not dpdk_conf.get('RTE_ARCH_64')\n+\tbuild = false\n+\treason = 'only supported on 64-bit'\n+\tsubdir_done()\n+endif\n+\n sources = files('otx2_worker.c',\n \t\t'otx2_worker_dual.c',\n \t\t'otx2_evdev.c',\n@@ -13,18 +19,6 @@ sources = files('otx2_worker.c',\n \t\t'otx2_tim_worker.c'\n \t\t)\n \n-extra_flags = []\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n-foreach flag: extra_flags\n-\tif cc.has_argument(flag)\n-\t\tcflags += flag\n-\tendif\n-endforeach\n-\n deps += ['bus_pci', 'common_octeontx2', 'crypto_octeontx2', 'mempool_octeontx2', 'net_octeontx2']\n \n includes += include_directories('../../crypto/octeontx2')\ndiff --git a/drivers/mempool/octeontx2/meson.build b/drivers/mempool/octeontx2/meson.build\nindex 0226f76d4b..0586321abe 100644\n--- a/drivers/mempool/octeontx2/meson.build\n+++ b/drivers/mempool/octeontx2/meson.build\n@@ -5,6 +5,12 @@\n if is_windows\n \tbuild = false\n \treason = 'not supported on Windows'\n+\tsubdir_done()\n+endif\n+if not dpdk_conf.get('RTE_ARCH_64')\n+\tbuild = false\n+\treason = 'only supported on 64-bit'\n+\tsubdir_done()\n endif\n \n sources = files('otx2_mempool_ops.c',\n@@ -13,16 +19,4 @@ sources = files('otx2_mempool_ops.c',\n \t\t'otx2_mempool_debug.c'\n \t\t)\n \n-extra_flags = []\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n-foreach flag: extra_flags\n-\tif cc.has_argument(flag)\n-\t\tcflags += flag\n-\tendif\n-endforeach\n-\n deps += ['eal', 'mbuf', 'kvargs', 'bus_pci', 'common_octeontx2', 'mempool']\ndiff --git a/drivers/net/octeontx2/meson.build b/drivers/net/octeontx2/meson.build\nindex 599ade6727..638c04a2fe 100644\n--- a/drivers/net/octeontx2/meson.build\n+++ b/drivers/net/octeontx2/meson.build\n@@ -2,6 +2,12 @@\n # Copyright(C) 2019 Marvell International Ltd.\n #\n \n+if not dpdk_conf.get('RTE_ARCH_64')\n+\tbuild = false\n+\treason = 'only supported on 64-bit'\n+\tsubdir_done()\n+endif\n+\n sources = files('otx2_rx.c',\n \t\t'otx2_tx.c',\n \t\t'otx2_tm.c',\n@@ -29,11 +35,6 @@ deps += ['bus_pci', 'cryptodev', 'eventdev', 'security']\n deps += ['common_octeontx2', 'mempool_octeontx2']\n \n extra_flags = ['-flax-vector-conversions']\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n foreach flag: extra_flags\n \tif cc.has_argument(flag)\n \t\tcflags += flag\ndiff --git a/drivers/regex/octeontx2/meson.build b/drivers/regex/octeontx2/meson.build\nindex aada0b5601..34e51728c2 100644\n--- a/drivers/regex/octeontx2/meson.build\n+++ b/drivers/regex/octeontx2/meson.build\n@@ -2,9 +2,10 @@\n # Copyright(C) 2020 Marvell International Ltd.\n #\n \n-if not is_linux\n+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')\n \tbuild = false\n-\treason = 'only supported on Linux'\n+\treason = 'only supported on 64-bit Linux'\n+\tsubdir_done()\n endif\n \n lib = cc.find_library('librxp_compiler', required: false)\n@@ -21,23 +22,6 @@ sources = files('otx2_regexdev.c',\n \t\t'otx2_regexdev_compiler.c'\n \t\t)\n \n-extra_flags = []\n-# This integrated controller runs only on a arm64 machine, remove 32bit warnings\n-if not dpdk_conf.get('RTE_ARCH_64')\n-\textra_flags += ['-Wno-int-to-pointer-cast', '-Wno-pointer-to-int-cast']\n-endif\n-\n-# for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n-if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n-\text_deps += cc.find_library('atomic')\n-endif\n-\n-foreach flag: extra_flags\n-\tif cc.has_argument(flag)\n-\t\tcflags += flag\n-\tendif\n-endforeach\n-\n fmt_name = 'octeontx2_regex'\n deps += ['bus_pci', 'common_octeontx2', 'regexdev']\n \n", "prefixes": [ "v2", "1/2" ] }