Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83851/?format=api
{ "id": 83851, "url": "http://patches.dpdk.org/api/patches/83851/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1604932142-19900-3-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1604932142-19900-3-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1604932142-19900-3-git-send-email-oulijun@huawei.com", "date": "2020-11-09T14:28:58", "name": "[V3,2/6] net/hns3: use unsigned types for bit operator", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "78407a57fd3cef9f54b29a17c30d1670c821f6ee", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1604932142-19900-3-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 13748, "url": "http://patches.dpdk.org/api/series/13748/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13748", "date": "2020-11-09T14:29:00", "name": "bugfix and cleanups for hns3", "version": 3, "mbox": "http://patches.dpdk.org/series/13748/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83851/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98D7CA0527;\n\tMon, 9 Nov 2020 15:29:05 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0146469A4;\n\tMon, 9 Nov 2020 15:28:48 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by dpdk.org (Postfix) with ESMTP id 160F26947\n for <dev@dpdk.org>; Mon, 9 Nov 2020 15:28:44 +0100 (CET)", "from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CVCz420G0zkhYR\n for <dev@dpdk.org>; Mon, 9 Nov 2020 22:28:32 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id\n 14.3.487.0; Mon, 9 Nov 2020 22:28:34 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@huawei.com>", "Date": "Mon, 9 Nov 2020 22:28:58 +0800", "Message-ID": "<1604932142-19900-3-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1604932142-19900-1-git-send-email-oulijun@huawei.com>", "References": "<1604634716-43484-1-git-send-email-oulijun@huawei.com>\n <1604932142-19900-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH V3 2/6] net/hns3: use unsigned types for bit\n\toperator", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hongbo Zheng <zhenghongbo3@huawei.com>\n\nAccording to bit operator reliability style, variables in\nthe right expression participating int bit operation\nmust be an unsigned type.\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\nV2->V3:\n- fix commit log for correct descriptions\n- fix unnecessary variable declarations line merge\n\nV1->V2:\n- no fix\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 2 +-\n drivers/net/hns3/hns3_rxtx_vec_neon.h | 8 +++++---\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 6f71cd6..2e9bfda 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1331,7 +1331,7 @@ hns3vf_get_tc_info(struct hns3_hw *hw)\n {\n \tuint8_t resp_msg;\n \tint ret;\n-\tint i;\n+\tuint32_t i;\n \n \tret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_TCINFO, 0, NULL, 0,\n \t\t\t\ttrue, &resp_msg, sizeof(resp_msg));\ndiff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h b/drivers/net/hns3/hns3_rxtx_vec_neon.h\nindex 8d7721b..54addbf 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_neon.h\n+++ b/drivers/net/hns3/hns3_rxtx_vec_neon.h\n@@ -93,9 +93,10 @@ hns3_desc_parse_field(struct hns3_rx_queue *rxq,\n \tstruct rte_mbuf *pkt;\n \tuint32_t retcode = 0;\n \tuint32_t cksum_err;\n-\tint ret, i;\n+\tuint32_t i;\n+\tint ret;\n \n-\tfor (i = 0; i < (int)bd_vld_num; i++) {\n+\tfor (i = 0; i < bd_vld_num; i++) {\n \t\tpkt = sw_ring[i].mbuf;\n \n \t\t/* init rte_mbuf.rearm_data last 64-bit */\n@@ -131,7 +132,8 @@ hns3_recv_burst_vec(struct hns3_rx_queue *__restrict rxq,\n \tstruct hns3_desc *rxdp = &rxq->rx_ring[rx_id];\n \tuint32_t bd_valid_num, parse_retcode;\n \tuint16_t nb_rx = 0;\n-\tint pos, offset;\n+\tuint32_t pos;\n+\tint offset;\n \n \t/* mask to shuffle from desc to mbuf's rx_descriptor_fields1 */\n \tuint8x16_t shuf_desc_fields_msk = {\n", "prefixes": [ "V3", "2/6" ] }