Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 83841,
    "url": "http://patches.dpdk.org/api/patches/83841/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201109114606.23876-2-ivan.malov@oktetlabs.ru/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20201109114606.23876-2-ivan.malov@oktetlabs.ru>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20201109114606.23876-2-ivan.malov@oktetlabs.ru",
    "date": "2020-11-09T11:46:06",
    "name": "[2/2] net/sfc: use more robust string comparison",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2f0697c6ed52adfa3795b06186c1599db566c01f",
    "submitter": {
        "id": 869,
        "url": "http://patches.dpdk.org/api/people/869/?format=api",
        "name": "Ivan Malov",
        "email": "Ivan.Malov@oktetlabs.ru"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201109114606.23876-2-ivan.malov@oktetlabs.ru/mbox/",
    "series": [
        {
            "id": 13742,
            "url": "http://patches.dpdk.org/api/series/13742/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13742",
            "date": "2020-11-09T11:46:05",
            "name": "[1/2] common/sfc_efx/base: apply MCDI version/boot clarity fixes",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/13742/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/83841/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/83841/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5610A0527;\n\tMon,  9 Nov 2020 12:46:56 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D6466A1B;\n\tMon,  9 Nov 2020 12:46:39 +0100 (CET)",
            "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by dpdk.org (Postfix) with ESMTP id 39E076883\n for <dev@dpdk.org>; Mon,  9 Nov 2020 12:46:36 +0100 (CET)",
            "from localhost.localdomain (unknown [188.242.7.54])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E2C417F576;\n Mon,  9 Nov 2020 14:46:34 +0300 (MSK)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E2C417F576",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1604922394;\n bh=rxbLtvVd3wGQzXAAjg/KeFIczPpCEzcKpvc4X9kQa0c=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=E2I52ZzG7P813xMVFvpvHUgPZKsuHlS0K2fRT74yuW7EtcJBFfmmGRQuk+TfX1sTd\n OJ+tU5eVH2NmlTnnHsEct0ROY6umCbBVZLtUqyCDLYBXHkBambbEP9M0JPPzUGhlwT\n EGmxdoxpT1xSKMrXOXd3PT9AwdXIXLC9AxbjHfEs=",
        "From": "Ivan Malov <ivan.malov@oktetlabs.ru>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>",
        "Date": "Mon,  9 Nov 2020 14:46:06 +0300",
        "Message-Id": "<20201109114606.23876-2-ivan.malov@oktetlabs.ru>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20201109114606.23876-1-ivan.malov@oktetlabs.ru>",
        "References": "<20201109114606.23876-1-ivan.malov@oktetlabs.ru>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 2/2] net/sfc: use more robust string comparison",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When it comes to comparing HW switch ID strings,\nuse strncmp to avoid reading past the buffer.\n\nFixes: e86b48aa46d4 (\"net/sfc: add HW switch ID helpers\")\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/sfc/sfc.c b/drivers/net/sfc/sfc.c\nindex a4fe49578..671a16640 100644\n--- a/drivers/net/sfc/sfc.c\n+++ b/drivers/net/sfc/sfc.c\n@@ -1301,5 +1301,6 @@ bool\n sfc_hw_switch_ids_equal(const struct sfc_hw_switch_id *left,\n \t\t\tconst struct sfc_hw_switch_id *right)\n {\n-\treturn strcmp(left->board_sn, right->board_sn) == 0;\n+\treturn strncmp(left->board_sn, right->board_sn,\n+\t\t       sizeof(left->board_sn)) == 0;\n }\n",
    "prefixes": [
        "2/2"
    ]
}