Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83817/?format=api
{ "id": 83817, "url": "http://patches.dpdk.org/api/patches/83817/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201106165611.232288-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201106165611.232288-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201106165611.232288-1-thomas@monjalon.net", "date": "2020-11-06T16:56:10", "name": "[v3,1/1] devtools: test 32-bit build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6e8e8eb4fd33998901e592d196ff167f968130d1", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201106165611.232288-1-thomas@monjalon.net/mbox/", "series": [ { "id": 13724, "url": "http://patches.dpdk.org/api/series/13724/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13724", "date": "2020-11-06T16:56:10", "name": "[v3,1/1] devtools: test 32-bit build", "version": 3, "mbox": "http://patches.dpdk.org/series/13724/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83817/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/83817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8447CA04B5;\n\tFri, 6 Nov 2020 17:56:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E60F6DED;\n\tFri, 6 Nov 2020 17:56:29 +0100 (CET)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3A7362AB\n for <dev@dpdk.org>; Fri, 6 Nov 2020 17:56:28 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.nyi.internal (Postfix) with ESMTP id 968125C0163;\n Fri, 6 Nov 2020 11:56:26 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Fri, 06 Nov 2020 11:56:26 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 598A9306005C;\n Fri, 6 Nov 2020 11:56:25 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=MGWlfweRqD5rg\n 24aVi6+fsMW/ADm4cs7HfB513cSVXk=; b=Mc8RslxHXOBGeXlEIIE2B3Pl7M4LL\n u24lNCQVNWsvwiP1tKnCTmfKt+0Tbu4qhN/LTKjhsz7v1rMHD0vZG8cgHcYsKnGG\n Du8xZjarps5/+TpW2q2ksyNrGNAGKUHi1WLWu4MfIqY6znpq/+HZ1FoJGwcN8EjA\n NkBvO4+2UIKdoxE8yedts/0yyx01UjeGxIbLdI0shyAnXTK+IAB6TI+NHoM1MiCQ\n uP4XNSRY8jGHgzAHlEyC7QHGRwmx/LnEjoVqiLrf4+Hzui3r+bV7wz6m+HiV1R3K\n xkfuzXODhuPP5T3vncBPEJEEomrZosDjBnvglPmGmCocY4DCl3GfpF86Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=MGWlfweRqD5rg24aVi6+fsMW/ADm4cs7HfB513cSVXk=; b=GxWZd8et\n z3L06o/inftxJOoioeRC0mJy07a4hhgW2sYtt5LN7PjX07bMHQD/I7H7RzFGFjix\n ZGlW5JbDRJhGgsUD3eQDznRR/DpqUwZJMnzM1dRl2/QWVL0zPnulFtf5qDjJPK2G\n wkPJQ1H12OIHOb87oKzUpPzviHkaArIXY2dr+eDyzR/zv5lt4iKIvWqLdQwKI8t0\n eNDDNLv7EMXa27HN6pLhGyvbqmzc+XPbLxGlZdHnYYHVy//BTcipNKPJc/fwW9L6\n olvgzxE3fN1qqL+Ufw63c2JQ5Nyg4PWVZLYPqxQ/++zXFFsZ4mM0u+qYWMQFycr+\n Uuc3ppvDBZMiWg==" ], "X-ME-Sender": "<xms:OYClX8_W41pZQEnmb1lmv39ZedHfTjmUZ6yA9-9xcDMy_SAd6IKqxQ>\n <xme:OYClX0uMyjat3k9BqsQeMvhjtPfRoY3kHGguVs1B0Gi3emSgVX-Bx8in09v4GJyzA\n OGTtRCzkg-VM1BHig>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedruddtledgleekucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:OYClXyB2zaQL_bcvAipGGfgZBilV3kKNO8cxIG_AEECUfMFoctDtVA>\n <xmx:OYClX8d3_60Nxcq_nbQkVk_meRWBQ9FsN2eIRS2pIy-D9yzbvsPDmw>\n <xmx:OYClXxOOGtWKQfM9uxDT6DFHtGubE6OektFvNlcf-8Zc8SfyNSZ-FQ>\n <xmx:OoClXzU3x_UNxorud6DlJKgZWo9_kkp_YtygtQtBeyqsY3fZ69zQ1w>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 6 Nov 2020 17:56:10 +0100", "Message-Id": "<20201106165611.232288-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201105110728.220957-1-bruce.richardson@intel.com>", "References": "<20201105110728.220957-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/1] devtools: test 32-bit build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nIt's reasonably common for patches to have issues when built on 32-bits, so\nto prevent this, we can add a 32-bit build (if supported) to the\n\"test-meson-builds.sh\" script. The tricky bit is using a valid\nPKG_CONFIG_LIBDIR, so for now we use two common possibilities for where that\nshould point to in order to get a successful build.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\nv3: unset override\n move and rename override\n split command in check_cc_flags\n use check_cc_flags for x86 default build\nv2: added separate flag checking function\n added override of the DPDK_TARGET value\n added /usr/lib32 as possible 32-bit libdir\n---\n devtools/test-meson-builds.sh | 32 +++++++++++++++++++++++++++++---\n 1 file changed, 29 insertions(+), 3 deletions(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex a87de635a2..ac76c2184b 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -43,6 +43,12 @@ default_cppflags=$CPPFLAGS\n default_cflags=$CFLAGS\n default_ldflags=$LDFLAGS\n \n+check_cc_flags () # <flag to check> <flag2> ...\n+{\n+\techo 'int main(void) { return 0; }' |\n+\tcc $@ -x c - -o /dev/null 2> /dev/null\n+}\n+\n load_env () # <target compiler>\n {\n \ttargetcc=$1\n@@ -52,11 +58,14 @@ load_env () # <target compiler>\n \texport CFLAGS=$default_cflags\n \texport LDFLAGS=$default_ldflags\n \tunset DPDK_MESON_OPTIONS\n-\tif command -v $targetcc >/dev/null 2>&1 ; then\n+\tif [ -n \"$target_override\" ] ; then\n+\t\tDPDK_TARGET=$target_override\n+\telif command -v $targetcc >/dev/null 2>&1 ; then\n \t\tDPDK_TARGET=$($targetcc -v 2>&1 | sed -n 's,^Target: ,,p')\n \telse # toolchain not yet in PATH: its name should be enough\n \t\tDPDK_TARGET=$targetcc\n \tfi\n+\techo \"Using DPDK_TARGET $DPDK_TARGET\"\n \t# config input: $DPDK_TARGET\n \t. $srcdir/devtools/load-devel-config\n \t# config output: $DPDK_MESON_OPTIONS, $PATH, $PKG_CONFIG_PATH, etc\n@@ -200,12 +209,29 @@ done\n # Set the install path for libraries to \"lib\" explicitly to prevent problems\n # with pkg-config prefixes if installed in \"lib/x86_64-linux-gnu\" later.\n default_machine='nehalem'\n-ok=$(cc -march=$default_machine -E - < /dev/null > /dev/null 2>&1 || echo false)\n-if [ \"$ok\" = \"false\" ] ; then\n+if ! check_cc_flags \"-march=$default_machine\" ; then\n \tdefault_machine='corei7'\n fi\n build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine $use_shared\n \n+# 32-bit with default compiler\n+if check_cc_flags '-m32' ; then\n+\tif [ -d '/usr/lib/i386-linux-gnu' ] ; then\n+\t\t# 32-bit pkgconfig on Debian/Ubuntu\n+\t\texport PKG_CONFIG_LIBDIR='/usr/lib/i386-linux-gnu/pkgconfig'\n+\telif [ -d '/usr/lib32' ] ; then\n+\t\t# 32-bit pkgconfig on Arch\n+\t\texport PKG_CONFIG_LIBDIR='/usr/lib32/pkgconfig'\n+\telse\n+\t\t# 32-bit pkgconfig on RHEL/Fedora (lib vs lib64)\n+\t\texport PKG_CONFIG_LIBDIR='/usr/lib/pkgconfig'\n+\tfi\n+\ttarget_override='i386-pc-linux-gnu'\n+\tbuild build-32b cc -Dc_args='-m32' -Dc_link_args='-m32'\n+\ttarget_override=\n+\tunset PKG_CONFIG_LIBDIR\n+fi\n+\n # x86 MinGW\n build build-x86-mingw $srcdir/config/x86/cross-mingw -Dexamples=helloworld\n \n", "prefixes": [ "v3", "1/1" ] }