Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83796/?format=api
{ "id": 83796, "url": "http://patches.dpdk.org/api/patches/83796/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1604649795-27476-3-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1604649795-27476-3-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1604649795-27476-3-git-send-email-juraj.linkes@pantheon.tech", "date": "2020-11-06T08:03:03", "name": "[v8,02/14] build: rename Arm build variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cad2f854f31bd136e962625d60a1bd572084565e", "submitter": { "id": 1626, "url": "http://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1604649795-27476-3-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 13717, "url": "http://patches.dpdk.org/api/series/13717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13717", "date": "2020-11-06T08:03:01", "name": "Arm build options rework", "version": 8, "mbox": "http://patches.dpdk.org/series/13717/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83796/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 632EDA0524;\n\tFri, 6 Nov 2020 09:04:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D1B6E4C96;\n\tFri, 6 Nov 2020 09:03:26 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by dpdk.org (Postfix) with ESMTP id 55A442D41\n for <dev@dpdk.org>; Fri, 6 Nov 2020 09:03:24 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 20B3AB6B69;\n Fri, 6 Nov 2020 09:03:21 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id y3hF6JJO2-Nn; Fri, 6 Nov 2020 09:03:19 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 12F51B6B65;\n Fri, 6 Nov 2020 09:03:17 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com,\n Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com,\n ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, aconole@redhat.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Fri, 6 Nov 2020 09:03:03 +0100", "Message-Id": "<1604649795-27476-3-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1604649795-27476-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1604584762-25321-1-git-send-email-juraj.linkes@pantheon.tech>\n <1604649795-27476-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 02/14] build: rename Arm build variables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rename Arm build variables and values so that they better conform to Arm\nspecifications. Also rename generically sounding variable to names that\nbetter capture what the variables hold.\n\nRename machine_args_generic to part_number_config_arm since the\nvariable contains more than just the generic machine args and is used\nmainly as the fallback arm configuration.\nRename the default machine args to generic machine args to reflect that.\nThe rest of the variables are self-explanatory.\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n config/arm/arm64_armada_linux_gcc | 2 +-\n config/arm/arm64_armv8_linux_gcc | 8 +-\n config/arm/arm64_bluefield_linux_gcc | 4 +-\n config/arm/arm64_dpaa_linux_gcc | 2 +-\n config/arm/arm64_emag_linux_gcc | 2 +-\n config/arm/arm64_n1sdp_linux_gcc | 4 +-\n config/arm/arm64_octeontx2_linux_gcc | 4 +-\n config/arm/arm64_stingray_linux_gcc | 4 +-\n config/arm/arm64_thunderx2_linux_gcc | 4 +-\n config/arm/arm64_thunderx_linux_gcc | 2 +-\n config/arm/meson.build | 110 +++++++++++++--------------\n 11 files changed, 73 insertions(+), 73 deletions(-)", "diff": "diff --git a/config/arm/arm64_armada_linux_gcc b/config/arm/arm64_armada_linux_gcc\nindex fa40c0398..52c5f4476 100644\n--- a/config/arm/arm64_armada_linux_gcc\n+++ b/config/arm/arm64_armada_linux_gcc\n@@ -14,4 +14,4 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x56'\n+implementer_id = '0x56'\ndiff --git a/config/arm/arm64_armv8_linux_gcc b/config/arm/arm64_armv8_linux_gcc\nindex 88f0ff9da..13ee8b223 100644\n--- a/config/arm/arm64_armv8_linux_gcc\n+++ b/config/arm/arm64_armv8_linux_gcc\n@@ -13,10 +13,10 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = 'generic'\n+implementer_id = 'generic'\n \n-# Valid options for Arm's implementor_pn:\n-# 'default': valid for all armv8-a architectures (default value)\n+# Valid options for Arm's part_number:\n+# 'generic': valid for all armv8-a architectures (default value)\n # '0xd03': cortex-a53\n # '0xd04': cortex-a35\n # '0xd05': cortex-a55\n@@ -25,4 +25,4 @@ implementor_id = 'generic'\n # '0xd09': cortex-a73\n # '0xd0a': cortex-a75\n # '0xd0b': cortex-a76\n-implementor_pn = 'default'\n+part_number = 'generic'\ndiff --git a/config/arm/arm64_bluefield_linux_gcc b/config/arm/arm64_bluefield_linux_gcc\nindex 86797d23c..b79389d85 100644\n--- a/config/arm/arm64_bluefield_linux_gcc\n+++ b/config/arm/arm64_bluefield_linux_gcc\n@@ -13,5 +13,5 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x41'\n-implementor_pn = '0xd08'\n+implementer_id = '0x41'\n+part_number = '0xd08'\ndiff --git a/config/arm/arm64_dpaa_linux_gcc b/config/arm/arm64_dpaa_linux_gcc\nindex 1a4682154..573ae7e42 100644\n--- a/config/arm/arm64_dpaa_linux_gcc\n+++ b/config/arm/arm64_dpaa_linux_gcc\n@@ -14,4 +14,4 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = 'dpaa'\n+implementer_id = 'dpaa'\ndiff --git a/config/arm/arm64_emag_linux_gcc b/config/arm/arm64_emag_linux_gcc\nindex 8edcd3e97..24f3d533e 100644\n--- a/config/arm/arm64_emag_linux_gcc\n+++ b/config/arm/arm64_emag_linux_gcc\n@@ -13,4 +13,4 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x50'\n+implementer_id = '0x50'\ndiff --git a/config/arm/arm64_n1sdp_linux_gcc b/config/arm/arm64_n1sdp_linux_gcc\nindex 022e06303..6fb3f02ea 100644\n--- a/config/arm/arm64_n1sdp_linux_gcc\n+++ b/config/arm/arm64_n1sdp_linux_gcc\n@@ -13,5 +13,5 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x41'\n-implementor_pn = '0xd0c'\n+implementer_id = '0x41'\n+part_number = '0xd0c'\ndiff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc\nindex 365bd7cbd..ac1042806 100644\n--- a/config/arm/arm64_octeontx2_linux_gcc\n+++ b/config/arm/arm64_octeontx2_linux_gcc\n@@ -13,5 +13,5 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x43'\n-implementor_pn = '0xb2'\n+implementer_id = '0x43'\n+part_number = '0xb2'\ndiff --git a/config/arm/arm64_stingray_linux_gcc b/config/arm/arm64_stingray_linux_gcc\nindex 86797d23c..b79389d85 100644\n--- a/config/arm/arm64_stingray_linux_gcc\n+++ b/config/arm/arm64_stingray_linux_gcc\n@@ -13,5 +13,5 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x41'\n-implementor_pn = '0xd08'\n+implementer_id = '0x41'\n+part_number = '0xd08'\ndiff --git a/config/arm/arm64_thunderx2_linux_gcc b/config/arm/arm64_thunderx2_linux_gcc\nindex 2b41acc61..dd257745e 100644\n--- a/config/arm/arm64_thunderx2_linux_gcc\n+++ b/config/arm/arm64_thunderx2_linux_gcc\n@@ -13,5 +13,5 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x43'\n-implementor_pn = '0xaf'\n+implementer_id = '0x43'\n+part_number = '0xaf'\ndiff --git a/config/arm/arm64_thunderx_linux_gcc b/config/arm/arm64_thunderx_linux_gcc\nindex 6572ab615..670764437 100644\n--- a/config/arm/arm64_thunderx_linux_gcc\n+++ b/config/arm/arm64_thunderx_linux_gcc\n@@ -13,4 +13,4 @@ cpu = 'armv8-a'\n endian = 'little'\n \n [properties]\n-implementor_id = '0x43'\n+implementer_id = '0x43'\ndiff --git a/config/arm/meson.build b/config/arm/meson.build\nindex d4066ade8..7fe0f3f3c 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -29,58 +29,58 @@ flags_common_default = [\n \t['RTE_ARM_USE_WFE', false],\n ]\n \n-flags_generic = [\n+flags_implementer_generic = [\n \t['RTE_MACHINE', '\"armv8a\"'],\n \t['RTE_MAX_LCORE', 256],\n \t['RTE_USE_C11_MEM_MODEL', true],\n \t['RTE_CACHE_LINE_SIZE', 128]]\n-flags_arm = [\n+flags_implementer_arm = [\n \t['RTE_MACHINE', '\"armv8a\"'],\n \t['RTE_MAX_LCORE', 16],\n \t['RTE_USE_C11_MEM_MODEL', true],\n \t['RTE_CACHE_LINE_SIZE', 64]]\n-flags_cavium = [\n+flags_implementer_cavium = [\n \t['RTE_CACHE_LINE_SIZE', 128],\n \t['RTE_MAX_NUMA_NODES', 2],\n \t['RTE_MAX_LCORE', 96],\n \t['RTE_MAX_VFIO_GROUPS', 128]]\n-flags_dpaa = [\n+flags_implementer_dpaa = [\n \t['RTE_MACHINE', '\"dpaa\"'],\n \t['RTE_USE_C11_MEM_MODEL', true],\n \t['RTE_CACHE_LINE_SIZE', 64],\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 16],\n \t['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]\n-flags_emag = [\n+flags_implementer_emag = [\n \t['RTE_MACHINE', '\"emag\"'],\n \t['RTE_CACHE_LINE_SIZE', 64],\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 32]]\n-flags_armada = [\n+flags_implementer_armada = [\n \t['RTE_MACHINE', '\"armv8a\"'],\n \t['RTE_CACHE_LINE_SIZE', 64],\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 16]]\n \n-flags_default_extra = []\n-flags_thunderx_extra = [\n+flags_part_number_default = []\n+flags_part_number_thunderx = [\n \t['RTE_MACHINE', '\"thunderx\"'],\n \t['RTE_USE_C11_MEM_MODEL', false]]\n-flags_thunderx2_extra = [\n+flags_part_number_thunderx2 = [\n \t['RTE_MACHINE', '\"thunderx2\"'],\n \t['RTE_CACHE_LINE_SIZE', 64],\n \t['RTE_MAX_NUMA_NODES', 2],\n \t['RTE_MAX_LCORE', 256],\n \t['RTE_ARM_FEATURE_ATOMICS', true],\n \t['RTE_USE_C11_MEM_MODEL', true]]\n-flags_octeontx2_extra = [\n+flags_part_number_octeontx2 = [\n \t['RTE_MACHINE', '\"octeontx2\"'],\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 36],\n \t['RTE_ARM_FEATURE_ATOMICS', true],\n \t['RTE_EAL_IGB_UIO', false],\n \t['RTE_USE_C11_MEM_MODEL', true]]\n-flags_n1generic_extra = [\n+flags_part_number_n1generic = [\n \t['RTE_MACHINE', '\"neoverse-n1\"'],\n \t['RTE_MAX_LCORE', 64],\n \t['RTE_CACHE_LINE_SIZE', 64],\n@@ -91,8 +91,8 @@ flags_n1generic_extra = [\n \t['RTE_EAL_NUMA_AWARE_HUGEPAGES', false],\n \t['RTE_LIBRTE_VHOST_NUMA', false]]\n \n-machine_args_generic = [\n-\t['default', ['-march=armv8-a+crc', '-moutline-atomics']],\n+part_number_config_arm = [\n+\t['generic', ['-march=armv8-a+crc', '-moutline-atomics']],\n \t['native', ['-march=native']],\n \t['0xd03', ['-mcpu=cortex-a53']],\n \t['0xd04', ['-mcpu=cortex-a35']],\n@@ -101,36 +101,36 @@ machine_args_generic = [\n \t['0xd09', ['-mcpu=cortex-a73']],\n \t['0xd0a', ['-mcpu=cortex-a75']],\n \t['0xd0b', ['-mcpu=cortex-a76']],\n-\t['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_n1generic_extra]]\n+\t['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'], flags_part_number_n1generic]]\n \n-machine_args_cavium = [\n-\t['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],\n+part_number_config_cavium = [\n+\t['generic', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],\n \t['native', ['-march=native']],\n-\t['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],\n-\t['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],\n-\t['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra],\n-\t['0xaf', ['-march=armv8.1-a+crc+crypto','-mcpu=thunderx2t99'], flags_thunderx2_extra],\n-\t['0xb2', ['-march=armv8.2-a+crc+crypto+lse','-mcpu=octeontx2'], flags_octeontx2_extra]]\n-\n-machine_args_emag = [\n-\t['default', ['-march=armv8-a+crc+crypto', '-mtune=emag']],\n+\t['0xa1', ['-mcpu=thunderxt88'], flags_part_number_thunderx],\n+\t['0xa2', ['-mcpu=thunderxt81'], flags_part_number_thunderx],\n+\t['0xa3', ['-mcpu=thunderxt83'], flags_part_number_thunderx],\n+\t['0xaf', ['-march=armv8.1-a+crc+crypto','-mcpu=thunderx2t99'], flags_part_number_thunderx2],\n+\t['0xb2', ['-march=armv8.2-a+crc+crypto+lse','-mcpu=octeontx2'], flags_part_number_octeontx2]]\n+\n+part_number_config_emag = [\n+\t['generic', ['-march=armv8-a+crc+crypto', '-mtune=emag']],\n \t['native', ['-march=native']]]\n \n ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)\n-impl_generic = ['Generic armv8', flags_generic, machine_args_generic]\n-impl_0x41 = ['Arm', flags_arm, machine_args_generic]\n-impl_0x42 = ['Broadcom', flags_generic, machine_args_generic]\n-impl_0x43 = ['Cavium', flags_cavium, machine_args_cavium]\n-impl_0x44 = ['DEC', flags_generic, machine_args_generic]\n-impl_0x49 = ['Infineon', flags_generic, machine_args_generic]\n-impl_0x4d = ['Motorola', flags_generic, machine_args_generic]\n-impl_0x4e = ['NVIDIA', flags_generic, machine_args_generic]\n-impl_0x50 = ['Ampere Computing', flags_emag, machine_args_emag]\n-impl_0x51 = ['Qualcomm', flags_generic, machine_args_generic]\n-impl_0x53 = ['Samsung', flags_generic, machine_args_generic]\n-impl_0x56 = ['Marvell ARMADA', flags_armada, machine_args_generic]\n-impl_0x69 = ['Intel', flags_generic, machine_args_generic]\n-impl_dpaa = ['NXP DPAA', flags_dpaa, machine_args_generic]\n+implementer_generic = ['Generic armv8', flags_implementer_generic, part_number_config_arm]\n+implementer_0x41 = ['Arm', flags_implementer_arm, part_number_config_arm]\n+implementer_0x42 = ['Broadcom', flags_implementer_generic, part_number_config_arm]\n+implementer_0x43 = ['Cavium', flags_implementer_cavium, part_number_config_cavium]\n+implementer_0x44 = ['DEC', flags_implementer_generic, part_number_config_arm]\n+implementer_0x49 = ['Infineon', flags_implementer_generic, part_number_config_arm]\n+implementer_0x4d = ['Motorola', flags_implementer_generic, part_number_config_arm]\n+implementer_0x4e = ['NVIDIA', flags_implementer_generic, part_number_config_arm]\n+implementer_0x50 = ['Ampere Computing', flags_implementer_emag, part_number_config_emag]\n+implementer_0x51 = ['Qualcomm', flags_implementer_generic, part_number_config_arm]\n+implementer_0x53 = ['Samsung', flags_implementer_generic, part_number_config_arm]\n+implementer_0x56 = ['Marvell ARMADA', flags_implementer_armada, part_number_config_arm]\n+implementer_0x69 = ['Intel', flags_implementer_generic, part_number_config_arm]\n+implementer_dpaa = ['NXP DPAA', flags_implementer_dpaa, part_number_config_arm]\n \n dpdk_conf.set('RTE_ARCH_ARM', 1)\n dpdk_conf.set('RTE_FORCE_INTRINSICS', 1)\n@@ -145,13 +145,13 @@ else\n \tdpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)\n \tdpdk_conf.set('RTE_ARCH_ARM64', 1)\n \n-\tmachine = []\n-\tcmd_generic = ['generic', '', '', 'default', '']\n+\timplementer_config = []\n+\tcmd_generic = ['generic', '', '', 'generic', '']\n \tcmd_output = cmd_generic # Set generic by default\n \tmachine_args = [] # Clear previous machine args\n \tif arm_force_generic_march and not meson.is_cross_build()\n-\t\tmachine = impl_generic\n-\t\timpl_pn = 'default'\n+\t\timplementer_config = implementer_generic\n+\t\tpart_number = 'generic'\n \telif not meson.is_cross_build()\n \t\t# The script returns ['Implementer', 'Variant', 'Architecture',\n \t\t# 'Primary Part number', 'Revision']\n@@ -162,19 +162,19 @@ else\n \t\t\tcmd_output = cmd.stdout().to_lower().strip().split(' ')\n \t\tendif\n \t\t# Set to generic if variable is not found\n-\t\tmachine = get_variable('impl_' + cmd_output[0], ['generic'])\n-\t\tif machine[0] == 'generic'\n-\t\t\tmachine = impl_generic\n+\t\timplementer_config = get_variable('implementer_' + cmd_output[0], ['generic'])\n+\t\tif implementer_config[0] == 'generic'\n+\t\t\timplementer_config = implementer_generic\n \t\t\tcmd_output = cmd_generic\n \t\tendif\n-\t\timpl_pn = cmd_output[3]\n+\t\tpart_number = cmd_output[3]\n \t\tif arm_force_native_march == true\n-\t\t\timpl_pn = 'native'\n+\t\t\tpart_number = 'native'\n \t\tendif\n \telse\n-\t\timpl_id = meson.get_cross_property('implementor_id', 'generic')\n-\t\timpl_pn = meson.get_cross_property('implementor_pn', 'default')\n-\t\tmachine = get_variable('impl_' + impl_id)\n+\t\timplementer_id = meson.get_cross_property('implementer_id', 'generic')\n+\t\tpart_number = meson.get_cross_property('part_number', 'generic')\n+\t\timplementer_config = get_variable('implementer_' + implementer_id)\n \tendif\n \n \t# Apply Common Defaults. These settings may be overwritten by machine\n@@ -185,22 +185,22 @@ else\n \t\tendif\n \tendforeach\n \n-\tmessage('Implementer : ' + machine[0])\n-\tforeach flag: machine[1]\n+\tmessage('Implementer : ' + implementer_config[0])\n+\tforeach flag: implementer_config[1]\n \t\tif flag.length() > 0\n \t\t\tdpdk_conf.set(flag[0], flag[1])\n \t\tendif\n \tendforeach\n \n-\tforeach marg: machine[2]\n-\t\tif marg[0] == impl_pn\n+\tforeach marg: implementer_config[2]\n+\t\tif marg[0] == part_number\n \t\t\tforeach flag: marg[1]\n \t\t\t\tif cc.has_argument(flag)\n \t\t\t\t\tmachine_args += flag\n \t\t\t\tendif\n \t\t\tendforeach\n \t\t\t# Apply any extra machine specific flags.\n-\t\t\tforeach flag: marg.get(2, flags_default_extra)\n+\t\t\tforeach flag: marg.get(2, flags_part_number_default)\n \t\t\t\tif flag.length() > 0\n \t\t\t\t\tdpdk_conf.set(flag[0], flag[1])\n \t\t\t\tendif\n", "prefixes": [ "v8", "02/14" ] }