Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/83752/?format=api
{ "id": 83752, "url": "http://patches.dpdk.org/api/patches/83752/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201105153316.27918-1-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201105153316.27918-1-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201105153316.27918-1-dharmik.thakkar@arm.com", "date": "2020-11-05T15:33:15", "name": "[1/2] crypto/armv8: update meson build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c6f7eb225f433afae206877af116c3519d0c25dc", "submitter": { "id": 1108, "url": "http://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201105153316.27918-1-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 13697, "url": "http://patches.dpdk.org/api/series/13697/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13697", "date": "2020-11-05T15:33:15", "name": "[1/2] crypto/armv8: update meson build", "version": 1, "mbox": "http://patches.dpdk.org/series/13697/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/83752/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/83752/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FFF7A04E7;\n\tThu, 5 Nov 2020 16:33:44 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D558C866;\n\tThu, 5 Nov 2020 16:33:42 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id C3637C858\n for <dev@dpdk.org>; Thu, 5 Nov 2020 16:33:40 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DCF814BF;\n Thu, 5 Nov 2020 07:33:39 -0800 (PST)", "from localhost.localdomain (2p2660v4-1.austin.arm.com\n [10.118.13.220])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 167573F718;\n Thu, 5 Nov 2020 07:33:39 -0800 (PST)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Ruifeng Wang <ruifeng.wang@arm.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org,\n\tnd@arm.com,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>", "Date": "Thu, 5 Nov 2020 09:33:15 -0600", "Message-Id": "<20201105153316.27918-1-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With pkg-config support available within AArch64crypto library,\nmeson option 'armv8_crypto_dir' can be removed.\nPKG_CONFIG_PATH environment variable should be set appropriately\nto use the crypto library.\n\nRefer [1] for build instructions.\n\n[1]\nhttps://doc.dpdk.org/guides/cryptodevs/armv8.html\n\nSuggested-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/crypto/armv8/meson.build | 19 ++++---------------\n meson_options.txt | 2 --\n 2 files changed, 4 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/crypto/armv8/meson.build b/drivers/crypto/armv8/meson.build\nindex c445c5bd3dfd..3289a2adcac5 100644\n--- a/drivers/crypto/armv8/meson.build\n+++ b/drivers/crypto/armv8/meson.build\n@@ -1,24 +1,13 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2019 Arm Limited\n \n-path = get_option('armv8_crypto_dir')\n-if path == ''\n+dep = dependency('libAArch64crypto', required: false)\n+if not dep.found()\n \tbuild = false\n-\treason = 'missing dependency, \"armv8_crypto\"'\n+\treason = 'missing dependency, \"libAArch64crypto\"'\n \tsubdir_done()\n endif\n \n-inc_dir = path\n-\n-lib = cc.find_library('libAArch64crypto', dirs: [path], required: false)\n-if not lib.found()\n-\tbuild = false\n-\treason = 'missing dependency, \"AArch64crypto\"'\n-\tsubdir_done()\n-else\n-\text_deps += lib\n-\tincludes += include_directories(inc_dir)\n-endif\n-\n+ext_deps += dep\n deps += ['bus_vdev']\n sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c')\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 9bf18ab6b1c9..e384e6dbb29e 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -1,7 +1,5 @@\n # Please keep these options sorted alphabetically.\n \n-option('armv8_crypto_dir', type: 'string', value: '',\n-\tdescription: 'path to the armv8_crypto library installation directory')\n option('disable_drivers', type: 'string', value: '',\n \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n", "prefixes": [ "1/2" ] }