Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8310/?format=api
{ "id": 8310, "url": "http://patches.dpdk.org/api/patches/8310/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1446182873-28814-5-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1446182873-28814-5-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1446182873-28814-5-git-send-email-cunming.liang@intel.com", "date": "2015-10-30T05:27:46", "name": "[dpdk-dev,v2,04/11] eal/linux: not allow to enable zero intr efd", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1845f6d7f899436dae616f2b040753bcf5418c2d", "submitter": { "id": 46, "url": "http://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1446182873-28814-5-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/8310/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/8310/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 9EF6A8E64;\n\tFri, 30 Oct 2015 06:28:14 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 6E08F8DAC\n\tfor <dev@dpdk.org>; Fri, 30 Oct 2015 06:28:12 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 29 Oct 2015 22:28:11 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 29 Oct 2015 22:28:10 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9U5S9NC023327;\n\tFri, 30 Oct 2015 13:28:09 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9U5S5Re028891; Fri, 30 Oct 2015 13:28:07 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9U5S54O028887; \n\tFri, 30 Oct 2015 13:28:05 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,217,1444719600\"; d=\"scan'208\";a=\"839040012\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 30 Oct 2015 13:27:46 +0800", "Message-Id": "<1446182873-28814-5-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1446182873-28814-1-git-send-email-cunming.liang@intel.com>", "References": "<1443072831-19065-1-git-send-email-cunming.liang@intel.com>\n\t<1446182873-28814-1-git-send-email-cunming.liang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 04/11] eal/linux: not allow to enable zero\n\tintr efd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The patch adds condition check to avoid enable nothing.\nIn disable state, both max_intr and nb_efd are zero.\n\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h | 3 ++-\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 8 +++++++-\n lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h | 3 ++-\n 3 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h b/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h\nindex 88d4ae1..cd8817d 100644\n--- a/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h\n+++ b/lib/librte_eal/bsdapp/eal/include/exec-env/rte_interrupts.h\n@@ -82,8 +82,9 @@ rte_intr_rx_ctl(struct rte_intr_handle *intr_handle,\n *\n * @param intr_handle\n * Pointer to the interrupt handle.\n- * @param nb_vec\n+ * @param nb_efd\n * Number of interrupt vector trying to enable.\n+ * The value 0 is not allowed.\n * @return\n * - On success, zero.\n * - On failure, a negative value.\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\nindex 8e76a7a..96226d6 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c\n@@ -45,6 +45,7 @@\n #include <sys/signalfd.h>\n #include <sys/ioctl.h>\n #include <sys/eventfd.h>\n+#include <assert.h>\n \n #include <rte_common.h>\n #include <rte_interrupts.h>\n@@ -1132,6 +1133,8 @@ rte_intr_efd_enable(struct rte_intr_handle *intr_handle, uint32_t nb_efd)\n \tint fd;\n \tuint32_t n = RTE_MIN(nb_efd, (uint32_t)RTE_MAX_RXTX_INTR_VEC_ID);\n \n+\tassert(nb_efd != 0);\n+\n \tif (intr_handle->type == RTE_INTR_HANDLE_VFIO_MSIX) {\n \t\tfor (i = 0; i < n; i++) {\n \t\t\tfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);\n@@ -1188,5 +1191,8 @@ rte_intr_dp_is_en(struct rte_intr_handle *intr_handle)\n int\n rte_intr_allow_others(struct rte_intr_handle *intr_handle)\n {\n-\treturn !!(intr_handle->max_intr - intr_handle->nb_efd);\n+\tif (!rte_intr_dp_is_en(intr_handle))\n+\t\treturn 1;\n+\telse\n+\t\treturn !!(intr_handle->max_intr - intr_handle->nb_efd);\n }\ndiff --git a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\nindex b8fd318..6a2f495 100644\n--- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\n+++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h\n@@ -176,8 +176,9 @@ rte_intr_rx_ctl(struct rte_intr_handle *intr_handle,\n *\n * @param intr_handle\n * Pointer to the interrupt handle.\n- * @param nb_vec\n+ * @param nb_efd\n * Number of interrupt vector trying to enable.\n+ * The value 0 is not allowed.\n * @return\n * - On success, zero.\n * - On failure, a negative value.\n", "prefixes": [ "dpdk-dev", "v2", "04/11" ] }