Patch Comment List
List patch comments
GET /api/patches/83/comments/?format=api
[ { "id": 204, "web_url": "http://patches.dpdk.org/comment/204/", "msgid": "<4341B239C0EFF9468EE453F9E9F4604D015AE27C@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4341B239C0EFF9468EE453F9E9F4604D015AE27C@shsmsx102.ccr.corp.intel.com", "date": "2014-07-23T06:46:11", "subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor\tqueue start and stop", "submitter": { "id": 40, "url": "http://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "> -----Original Message-----\n> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ouyang Changchun\n> Sent: Wednesday, July 23, 2014 12:48 PM\n> To: dev@dpdk.org\n> Subject: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n> for queue start and stop\n> \n> Update comments for the field start_rx_per_q for better readability.\n> Rename the field name to rx_enable_queue for better readability too.\n> Accordingly Update its reference in sample vhost.\n> \n> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>\n\n\nAcked-by Chen Jing (Mark) <jing.d.chen@intel.com>\n\n> ---\n> examples/vhost/main.c | 4 ++--\n> lib/librte_ether/rte_ethdev.h | 16 ++++++++++++++--\n> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++----\n> lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 4 ++--\n> 4 files changed, 22 insertions(+), 10 deletions(-)\n> \n> diff --git a/examples/vhost/main.c b/examples/vhost/main.c\n> index 193aa25..2eea431 100644\n> --- a/examples/vhost/main.c\n> +++ b/examples/vhost/main.c\n> @@ -2984,9 +2984,9 @@ MAIN(int argc, char *argv[])\n> \t\tchar pool_name[RTE_MEMPOOL_NAMESIZE];\n> \t\tchar ring_name[RTE_MEMPOOL_NAMESIZE];\n> \n> -\t\trx_conf_default.start_rx_per_q = (uint8_t)zero_copy;\n> +\t\trx_conf_default.rx_enable_queue = (uint8_t)zero_copy;\n> \t\trx_conf_default.rx_drop_en = 0;\n> -\t\ttx_conf_default.start_tx_per_q = (uint8_t)zero_copy;\n> +\t\ttx_conf_default.tx_enable_queue = (uint8_t)zero_copy;\n> \t\tnb_mbuf = num_rx_descriptor\n> \t\t\t+ num_switching_cores * MBUF_CACHE_SIZE_ZCP\n> \t\t\t+ num_switching_cores * MAX_PKT_BURST;\n> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\n> index 50df654..ba439f6 100644\n> --- a/lib/librte_ether/rte_ethdev.h\n> +++ b/lib/librte_ether/rte_ethdev.h\n> @@ -604,7 +604,16 @@ struct rte_eth_rxconf {\n> \tstruct rte_eth_thresh rx_thresh; /**< RX ring threshold registers. */\n> \tuint16_t rx_free_thresh; /**< Drives the freeing of RX descriptors.\n> */\n> \tuint8_t rx_drop_en; /**< Drop packets if no descriptors are available.\n> */\n> -\tuint8_t start_rx_per_q; /**< start rx per queue. */\n> +\t/**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start\n> should be\n> +\t\tinvocated to start RX for one queue after rte_eth_dev_start\n> is\n> +\t\tinvocated, and rte_eth_dev_rx_queue_start instead of\n> +\t\trte_eth_dev_start is responsible for allocating mbuf from\n> +\t\tmempool and setup the DMA physical address. It is useful in\n> +\t\tsuch scenario: buffer address is not available at the point of\n> +\t\trte_eth_dev_start's invocating but available later, e.g. in\n> +\t\tVHOST zero copy case, the buffer address used to setup\n> DMA\n> +\t\taddress is available only after one VM(guest) startup. */\n> +\tuint8_t rx_enable_queue;\n> };\n> \n> #define ETH_TXQ_FLAGS_NOMULTSEGS 0x0001 /**< nb_segs=1 for all\n> mbufs */\n> @@ -625,7 +634,10 @@ struct rte_eth_txconf {\n> \tuint16_t tx_rs_thresh; /**< Drives the setting of RS bit on TXDs. */\n> \tuint16_t tx_free_thresh; /**< Drives the freeing of TX buffers. */\n> \tuint32_t txq_flags; /**< Set flags for the Tx queue */\n> -\tuint8_t start_tx_per_q; /**< start tx per queue. */\n> +\t/**< If tx_enable_queue is true, rte_eth_dev_tx_queue_start must\n> be\n> +\t\tinvocated to start TX for one queue after rte_eth_dev_start\n> is\n> +\t\tinvocated. Refer to start_rx_per_q for the use case. */\n> +\tuint8_t tx_enable_queue;\n> };\n> \n> /**\n> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n> index dfc2076..2872fad 100644\n> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n> @@ -1846,7 +1846,7 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev\n> *dev,\n> \ttxq->port_id = dev->data->port_id;\n> \ttxq->txq_flags = tx_conf->txq_flags;\n> \ttxq->ops = &def_txq_ops;\n> -\ttxq->start_tx_per_q = tx_conf->start_tx_per_q;\n> +\ttxq->tx_enable_queue = tx_conf->tx_enable_queue;\n> \n> \t/*\n> \t * Modification to set VFTDT for virtual function if vf is detected\n> @@ -2091,7 +2091,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev\n> *dev,\n> \trxq->crc_len = (uint8_t) ((dev->data-\n> >dev_conf.rxmode.hw_strip_crc) ?\n> \t\t\t\t\t\t\t0 : ETHER_CRC_LEN);\n> \trxq->drop_en = rx_conf->rx_drop_en;\n> -\trxq->start_rx_per_q = rx_conf->start_rx_per_q;\n> +\trxq->rx_enable_queue = rx_conf->rx_enable_queue;\n> \n> \t/*\n> \t * Allocate RX ring hardware descriptors. A memzone large enough to\n> @@ -3652,13 +3652,13 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n> \n> \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n> \t\ttxq = dev->data->tx_queues[i];\n> -\t\tif (!txq->start_tx_per_q)\n> +\t\tif (!txq->tx_enable_queue)\n> \t\t\tixgbe_dev_tx_queue_start(dev, i);\n> \t}\n> \n> \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n> \t\trxq = dev->data->rx_queues[i];\n> -\t\tif (!rxq->start_rx_per_q)\n> +\t\tif (!rxq->rx_enable_queue)\n> \t\t\tixgbe_dev_rx_queue_start(dev, i);\n> \t}\n> \n> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h\n> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h\n> index 64c0695..d6d856e 100644\n> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.h\n> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.h\n> @@ -135,7 +135,7 @@ struct igb_rx_queue {\n> \tuint8_t port_id; /**< Device port identifier. */\n> \tuint8_t crc_len; /**< 0 if CRC stripped, 4 otherwise. */\n> \tuint8_t drop_en; /**< If not 0, set SRRCTL.Drop_En. */\n> -\tuint8_t start_rx_per_q;\n> +\tuint8_t rx_enable_queue;\n> #ifdef RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC\n> \t/** need to alloc dummy mbuf, for wraparound when scanning hw\n> ring */\n> \tstruct rte_mbuf fake_mbuf;\n> @@ -200,7 +200,7 @@ struct igb_tx_queue {\n> \t/** Hardware context0 history. */\n> \tstruct ixgbe_advctx_info ctx_cache[IXGBE_CTX_NUM];\n> \tstruct ixgbe_txq_ops *ops; /**< txq ops */\n> -\tuint8_t start_tx_per_q;\n> +\tuint8_t tx_enable_queue;\n> };\n> \n> struct ixgbe_txq_ops {\n> --\n> 1.8.4.2", "headers": { "Return-Path": "<jing.d.chen@intel.com>", "Received": [ "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 34DB968CD\n\tfor <dev@dpdk.org>; Wed, 23 Jul 2014 08:45:00 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 22 Jul 2014 23:46:15 -0700", "from fmsmsx104.amr.corp.intel.com ([10.19.9.35])\n\tby fmsmga002.fm.intel.com with ESMTP; 22 Jul 2014 23:46:15 -0700", "from fmsmsx156.amr.corp.intel.com (10.18.116.74) by\n\tFMSMSX104.amr.corp.intel.com (10.19.9.35) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Tue, 22 Jul 2014 23:46:15 -0700", "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tfmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Tue, 22 Jul 2014 23:46:15 -0700", "from shsmsx102.ccr.corp.intel.com ([169.254.2.120]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.188]) with mapi id\n\t14.03.0123.003; Wed, 23 Jul 2014 14:46:12 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,715,1400050800\"; d=\"scan'208\";a=\"574046999\"", "From": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "To": "\"Ouyang, Changchun\" <changchun.ouyang@intel.com>, \"dev@dpdk.org\"\n\t<dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor\tqueue start and stop", "Thread-Index": "AQHPpjGC8waKsRF5k06Jxqy1IYflBputNpUg", "Date": "Wed, 23 Jul 2014 06:46:11 +0000", "Message-ID": "<4341B239C0EFF9468EE453F9E9F4604D015AE27C@shsmsx102.ccr.corp.intel.com>", "References": "<1406090907-24347-1-git-send-email-changchun.ouyang@intel.com>", "In-Reply-To": "<1406090907-24347-1-git-send-email-changchun.ouyang@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor\tqueue start and stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Wed, 23 Jul 2014 06:45:01 -0000" }, "addressed": null }, { "id": 1004, "web_url": "http://patches.dpdk.org/comment/1004/", "msgid": "<1577833.5iZA1XeDyr@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1577833.5iZA1XeDyr@xps13", "date": "2014-09-25T09:30:51", "subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor queue start and stop", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi Ouyang,\n\n2014-07-23 12:48, Ouyang Changchun:\n> Update comments for the field start_rx_per_q for better readability.\n> Rename the field name to rx_enable_queue for better readability too.\n> Accordingly Update its reference in sample vhost.\n\n> -\tuint8_t start_rx_per_q; /**< start rx per queue. */\n> +\t/**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start should be\n> +\t\tinvocated to start RX for one queue after rte_eth_dev_start is\n> +\t\tinvocated, and rte_eth_dev_rx_queue_start instead of\n> +\t\trte_eth_dev_start is responsible for allocating mbuf from\n> +\t\tmempool and setup the DMA physical address. It is useful in\n> +\t\tsuch scenario: buffer address is not available at the point of\n> +\t\trte_eth_dev_start's invocating but available later, e.g. in\n> +\t\tVHOST zero copy case, the buffer address used to setup DMA\n> +\t\taddress is available only after one VM(guest) startup. */\n> +\tuint8_t rx_enable_queue;\n> };\n\nI have many comments here.\n\nThe doxygen comment /**< must be used only after the symbol you are\ncommenting:\n\thttp://doxygen.org/manual/docblocks.html#memberdoc\n\nThe comment is too long.\nThe use case would be in the manual, not in doxygen.\nThe comment about rte_eth_dev_rx_queue_start would be in the doxygen\ncomment of rte_eth_dev_rx_queue_start.\n\nWhen this variable is set, it doesn't enable anything. It only disables\nthe queue when doing a global start. Its name should be rx_deferred_start.\nAll fields of this structure are about one queue, so the \"queue\" word is\nnot needed.\n\n> -\tuint8_t start_tx_per_q; /**< start tx per queue. */\n> +\t/**< If tx_enable_queue is true, rte_eth_dev_tx_queue_start must be\n> +\t\tinvocated to start TX for one queue after rte_eth_dev_start is\n> +\t\tinvocated. Refer to start_rx_per_q for the use case. */\n> +\tuint8_t tx_enable_queue;\n> };\n\nYou refer to the old name (start_rx_per_q).\nBy the way, a one line description (without referral) for both fields should\nbe enough. Something like \"do not start with rte_eth_dev_start()\".\n\n> @@ -3652,13 +3652,13 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n> \n> \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n> \t\ttxq = dev->data->tx_queues[i];\n> -\t\tif (!txq->start_tx_per_q)\n> +\t\tif (!txq->tx_enable_queue)\n> \t\t\tixgbe_dev_tx_queue_start(dev, i);\n> \t}\n\nHere it's clear that this field is about disabling start.\n\nPlease rework this patch and update i40e accordingly.\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B56C6B3DE;\n\tThu, 25 Sep 2014 11:24:44 +0200 (CEST)", "from mail-we0-f182.google.com (mail-we0-f182.google.com\n\t[74.125.82.182]) by dpdk.org (Postfix) with ESMTP id 5BF4DB3DA\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 11:24:43 +0200 (CEST)", "by mail-we0-f182.google.com with SMTP id u57so5679095wes.13\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 02:31:00 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tmx5sm8610409wic.0.2014.09.25.02.30.58 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 25 Sep 2014 02:30:59 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=A/GtJqRvbiy2Gs1PvcXa5s8Sl41kyDCiIUs4ooMUf80=;\n\tb=OSGPubWutIzJgnYZJPnrk5w3pbHGJNx3Mv74/3daqKUmNIjMAJBxmadXV/jFpTCwsr\n\tV1/FyTVywaahYaRwzOGzCyRnNaEw1j3flov9r7ky//R5qlx/0YuK4KD4YqsbPGlSEXsg\n\tai+kToEPdb1/vUjB5ZepzUQcieNIpSYou4HNdFq5Qc8LjmAkxvBx51tiUZ7kmuofvOLX\n\tKa4Xd97uAAf0NGnajMLghj+I2qmqGg+/V/kVuMjyEL8e4E4+aXBr/wv7WVCQ3URZY00X\n\tEQd2Yahhw9PjY4fQQ+fNsM3ghSSx044Qgm4TXdeWGzD1+gmL1MWVSZMeAAzPXixaQj7X\n\tmJtA==", "X-Gm-Message-State": "ALoCoQnrs+WI39ElZt9V5akoER4lV2gXJJt3xFiA3k/PIGrIzybo4jH3M0wKuWnlVSzAz/sRvMcR", "X-Received": "by 10.180.95.163 with SMTP id dl3mr18101767wib.79.1411637460284; \n\tThu, 25 Sep 2014 02:31:00 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Ouyang Changchun <changchun.ouyang@intel.com>", "Date": "Thu, 25 Sep 2014 11:30:51 +0200", "Message-ID": "<1577833.5iZA1XeDyr@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1406090907-24347-1-git-send-email-changchun.ouyang@intel.com>", "References": "<1406090907-24347-1-git-send-email-changchun.ouyang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor queue start and stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1031, "web_url": "http://patches.dpdk.org/comment/1031/", "msgid": "<F52918179C57134FAEC9EA62FA2F96251185B434@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F52918179C57134FAEC9EA62FA2F96251185B434@shsmsx102.ccr.corp.intel.com", "date": "2014-09-25T14:26:56", "subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor queue start and stop", "submitter": { "id": 31, "url": "http://patches.dpdk.org/api/people/31/?format=api", "name": "Ouyang Changchun", "email": "changchun.ouyang@intel.com" }, "content": "Hi Thomas,\n\nThanks very much for your comments!\nI will rework this patch and also update for i40e.\n\nThanks and best regards,\nChangchun\n\n\n> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Thursday, September 25, 2014 5:31 PM\n> To: Ouyang, Changchun\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue\n> field for queue start and stop\n> \n> Hi Ouyang,\n> \n> 2014-07-23 12:48, Ouyang Changchun:\n> > Update comments for the field start_rx_per_q for better readability.\n> > Rename the field name to rx_enable_queue for better readability too.\n> > Accordingly Update its reference in sample vhost.\n> \n> > -\tuint8_t start_rx_per_q; /**< start rx per queue. */\n> > +\t/**< If rx_enable_queue is true, rte_eth_dev_rx_queue_start\n> should be\n> > +\t\tinvocated to start RX for one queue after rte_eth_dev_start\n> is\n> > +\t\tinvocated, and rte_eth_dev_rx_queue_start instead of\n> > +\t\trte_eth_dev_start is responsible for allocating mbuf from\n> > +\t\tmempool and setup the DMA physical address. It is useful in\n> > +\t\tsuch scenario: buffer address is not available at the point of\n> > +\t\trte_eth_dev_start's invocating but available later, e.g. in\n> > +\t\tVHOST zero copy case, the buffer address used to setup\n> DMA\n> > +\t\taddress is available only after one VM(guest) startup. */\n> > +\tuint8_t rx_enable_queue;\n> > };\n> \n> I have many comments here.\n> \n> The doxygen comment /**< must be used only after the symbol you are\n> commenting:\n> \thttp://doxygen.org/manual/docblocks.html#memberdoc\n> \n> The comment is too long.\n> The use case would be in the manual, not in doxygen.\n> The comment about rte_eth_dev_rx_queue_start would be in the doxygen\n> comment of rte_eth_dev_rx_queue_start.\n> \n> When this variable is set, it doesn't enable anything. It only disables the\n> queue when doing a global start. Its name should be rx_deferred_start.\n> All fields of this structure are about one queue, so the \"queue\" word is not\n> needed.\n> \n> > -\tuint8_t start_tx_per_q; /**< start tx per queue. */\n> > +\t/**< If tx_enable_queue is true, rte_eth_dev_tx_queue_start must\n> be\n> > +\t\tinvocated to start TX for one queue after rte_eth_dev_start\n> is\n> > +\t\tinvocated. Refer to start_rx_per_q for the use case. */\n> > +\tuint8_t tx_enable_queue;\n> > };\n> \n> You refer to the old name (start_rx_per_q).\n> By the way, a one line description (without referral) for both fields should be\n> enough. Something like \"do not start with rte_eth_dev_start()\".\n> \n> > @@ -3652,13 +3652,13 @@ ixgbe_dev_rxtx_start(struct rte_eth_dev *dev)\n> >\n> > \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n> > \t\ttxq = dev->data->tx_queues[i];\n> > -\t\tif (!txq->start_tx_per_q)\n> > +\t\tif (!txq->tx_enable_queue)\n> > \t\t\tixgbe_dev_tx_queue_start(dev, i);\n> > \t}\n> \n> Here it's clear that this field is about disabling start.\n> \n> Please rework this patch and update i40e accordingly.\n> Thanks\n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B8104B3EA;\n\tThu, 25 Sep 2014 16:20:45 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 52330B3D7\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 16:20:44 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 25 Sep 2014 07:26:59 -0700", "from fmsmsx106.amr.corp.intel.com ([10.18.124.204])\n\tby orsmga002.jf.intel.com with ESMTP; 25 Sep 2014 07:26:59 -0700", "from fmsmsx115.amr.corp.intel.com (10.18.116.19) by\n\tFMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 25 Sep 2014 07:26:59 -0700", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tfmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 25 Sep 2014 07:26:58 -0700", "from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.230]) with mapi id\n\t14.03.0195.001; Thu, 25 Sep 2014 22:26:57 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,597,1406617200\"; d=\"scan'208\";a=\"608504143\"", "From": "\"Ouyang, Changchun\" <changchun.ouyang@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor queue start and stop", "Thread-Index": "AQHP2KN2AoGjGVuw3Eymcd0tnJ8asZwR57Nw", "Date": "Thu, 25 Sep 2014 14:26:56 +0000", "Message-ID": "<F52918179C57134FAEC9EA62FA2F96251185B434@shsmsx102.ccr.corp.intel.com>", "References": "<1406090907-24347-1-git-send-email-changchun.ouyang@intel.com>\n\t<1577833.5iZA1XeDyr@xps13>", "In-Reply-To": "<1577833.5iZA1XeDyr@xps13>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2] ethdev: Rename RX/TX enable queue field\n\tfor queue start and stop", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]