Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82857/?format=api
http://patches.dpdk.org/api/patches/82857/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201030052159.63051-1-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201030052159.63051-1-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201030052159.63051-1-jia.guo@intel.com", "date": "2020-10-30T05:21:59", "name": "[v1] net/iavf: fix PROT filed for rss hash", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "88af21f7e1a020ce708c06306045a2703ad41886", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201030052159.63051-1-jia.guo@intel.com/mbox/", "series": [ { "id": 13484, "url": "http://patches.dpdk.org/api/series/13484/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13484", "date": "2020-10-30T05:21:59", "name": "[v1] net/iavf: fix PROT filed for rss hash", "version": 1, "mbox": "http://patches.dpdk.org/series/13484/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82857/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/82857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8151A04DE;\n\tFri, 30 Oct 2020 06:30:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 26B1D4CBD;\n\tFri, 30 Oct 2020 06:30:27 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id ACDA44C91\n for <dev@dpdk.org>; Fri, 30 Oct 2020 06:30:24 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Oct 2020 22:30:22 -0700", "from npg-dpdk-cvl-jeffguo-01.sh.intel.com ([10.67.111.128])\n by fmsmga004.fm.intel.com with ESMTP; 29 Oct 2020 22:30:21 -0700" ], "IronPort-SDR": [ "\n r+4vw8wUqaIbagt7BI30+N5vp93UMfmgIXh/PBfhRHuwxZGGTZtViOOGDJXSnrYRvQPSbAHihL\n rJhTsqJYDCcA==", "\n YKEtclQf/IagbLVpWL15pARurucXA9NyGIJDc5g0DWfO7I28fl0+iDn/Ml3vx8+ObenHHMw3n5\n zaxA35jXaNfA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9789\"; a=\"165976045\"", "E=Sophos;i=\"5.77,432,1596524400\"; d=\"scan'208\";a=\"165976045\"", "E=Sophos;i=\"5.77,432,1596524400\"; d=\"scan'208\";a=\"351748058\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Jeff Guo <jia.guo@intel.com>", "To": "jingjing.wu@intel.com,\n\tqi.z.zhang@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com", "Date": "Fri, 30 Oct 2020 13:21:59 +0800", "Message-Id": "<20201030052159.63051-1-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/iavf: fix PROT filed for rss hash", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add PROT field into IPv4 and IPv6 protocol headers for rss hash.\n\nFixes: 91f27b2e39ab (\"net/iavf: refactor RSS\")\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n drivers/net/iavf/iavf_hash.c | 32 ++++++++++++++++++++------------\n 1 file changed, 20 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c\nindex be821b62eb..1b4434c1e1 100644\n--- a/drivers/net/iavf/iavf_hash.c\n+++ b/drivers/net/iavf/iavf_hash.c\n@@ -99,12 +99,14 @@ iavf_hash_parse_pattern_action(struct iavf_adapter *ad,\n #define proto_hdr_ipv4 { \\\n \tVIRTCHNL_PROTO_HDR_IPV4, \\\n \tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_SRC) | \\\n-\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST), {BUFF_NOUSED} }\n+\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_DST) | \\\n+\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_PROT), {BUFF_NOUSED} }\n \n #define proto_hdr_ipv6 { \\\n \tVIRTCHNL_PROTO_HDR_IPV6, \\\n \tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_SRC) | \\\n-\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST), {BUFF_NOUSED} }\n+\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) | \\\n+\tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT), {BUFF_NOUSED} }\n \n #define proto_hdr_udp { \\\n \tVIRTCHNL_PROTO_HDR_UDP, \\\n@@ -581,14 +583,17 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,\n \t\t\t ETH_RSS_NONFRAG_IPV4_UDP |\n \t\t\t ETH_RSS_NONFRAG_IPV4_TCP |\n \t\t\t ETH_RSS_NONFRAG_IPV4_SCTP)) {\n-\t\t\t\tif (rss_type & ETH_RSS_L3_SRC_ONLY)\n+\t\t\t\tif (rss_type & ETH_RSS_L3_SRC_ONLY) {\n \t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV4_DST);\n-\t\t\t\telse if (rss_type & ETH_RSS_L3_DST_ONLY)\n+\t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV4_PROT);\n+\t\t\t\t} else if (rss_type & ETH_RSS_L3_DST_ONLY) {\n \t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV4_SRC);\n-\t\t\t\telse if (rss_type &\n-\t\t\t\t\t (ETH_RSS_L4_SRC_ONLY |\n-\t\t\t\t\t ETH_RSS_L4_DST_ONLY))\n+\t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV4_PROT);\n+\t\t\t\t} else if (rss_type &\n+\t\t\t\t\t (ETH_RSS_L4_SRC_ONLY |\n+\t\t\t\t\t ETH_RSS_L4_DST_ONLY)) {\n \t\t\t\t\thdr->field_selector = 0;\n+\t\t\t\t}\n \t\t\t} else {\n \t\t\t\thdr->field_selector = 0;\n \t\t\t}\n@@ -599,14 +604,17 @@ iavf_refine_proto_hdrs_l234(struct virtchnl_proto_hdrs *proto_hdrs,\n \t\t\t ETH_RSS_NONFRAG_IPV6_UDP |\n \t\t\t ETH_RSS_NONFRAG_IPV6_TCP |\n \t\t\t ETH_RSS_NONFRAG_IPV6_SCTP)) {\n-\t\t\t\tif (rss_type & ETH_RSS_L3_SRC_ONLY)\n+\t\t\t\tif (rss_type & ETH_RSS_L3_SRC_ONLY) {\n \t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV6_DST);\n-\t\t\t\telse if (rss_type & ETH_RSS_L3_DST_ONLY)\n+\t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV6_PROT);\n+\t\t\t\t} else if (rss_type & ETH_RSS_L3_DST_ONLY) {\n \t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV6_SRC);\n-\t\t\t\telse if (rss_type &\n-\t\t\t\t\t (ETH_RSS_L4_SRC_ONLY |\n-\t\t\t\t\t ETH_RSS_L4_DST_ONLY))\n+\t\t\t\t\tREFINE_PROTO_FLD(DEL, IPV6_PROT);\n+\t\t\t\t} else if (rss_type &\n+\t\t\t\t\t (ETH_RSS_L4_SRC_ONLY |\n+\t\t\t\t\t ETH_RSS_L4_DST_ONLY)) {\n \t\t\t\t\thdr->field_selector = 0;\n+\t\t\t\t}\n \t\t\t} else {\n \t\t\t\thdr->field_selector = 0;\n \t\t\t}\n", "prefixes": [ "v1" ] }{ "id": 82857, "url": "