Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82856/?format=api
{ "id": 82856, "url": "http://patches.dpdk.org/api/patches/82856/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201030031638.370766-1-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201030031638.370766-1-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201030031638.370766-1-simei.su@intel.com", "date": "2020-10-30T03:16:38", "name": "net/iavf: fix invalid RSS type", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a28eae68f92845dc895ce1e8c2b0e82600097d73", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201030031638.370766-1-simei.su@intel.com/mbox/", "series": [ { "id": 13483, "url": "http://patches.dpdk.org/api/series/13483/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13483", "date": "2020-10-30T03:16:38", "name": "net/iavf: fix invalid RSS type", "version": 1, "mbox": "http://patches.dpdk.org/series/13483/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82856/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/82856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1A12A04DD;\n\tFri, 30 Oct 2020 04:26:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 22666CCA9;\n\tFri, 30 Oct 2020 04:26:27 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 7EDF9CC79\n for <dev@dpdk.org>; Fri, 30 Oct 2020 04:26:24 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Oct 2020 20:26:23 -0700", "from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com)\n ([10.67.119.195])\n by fmsmga005.fm.intel.com with ESMTP; 29 Oct 2020 20:26:22 -0700" ], "IronPort-SDR": [ "\n z1HHtL5XkY4+Aj7nmjfYAy+RDPToMTTvgs6x10+P1ucAJMZ67LLsNXE9Pi6FRuDWVO3/FKHNRX\n xFcuVJbK5WFQ==", "\n Zv54fHPm09hXCB6xMKf0F1uAFAqE2tE2oSgWMBBc0N3E6qzVr5Go/pyv931wf2afYYMtbe3BZ7\n kxvHOITzCtPw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9789\"; a=\"165056497\"", "E=Sophos;i=\"5.77,432,1596524400\"; d=\"scan'208\";a=\"165056497\"", "E=Sophos;i=\"5.77,432,1596524400\"; d=\"scan'208\";a=\"526980890\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, jia.guo@intel.com, junfeng.guo@intel.com,\n Simei Su <simei.su@intel.com>", "Date": "Fri, 30 Oct 2020 11:16:38 +0800", "Message-Id": "<20201030031638.370766-1-simei.su@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH] net/iavf: fix invalid RSS type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a RSS rule with symmetric hash function, the RSS type shouldn't\ncarry with SRC/DST_ONLY. This patch adds invalid RSS type check for\nthe case.\n\nFixes: 91f27b2e39ab (\"net/iavf: refactor RSS\")\n\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/net/iavf/iavf_hash.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c\nindex be821b6..6d0360a 100644\n--- a/drivers/net/iavf/iavf_hash.c\n+++ b/drivers/net/iavf/iavf_hash.c\n@@ -917,6 +917,22 @@ iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,\n \t\t\t */\n \t\t\trss_type = rte_eth_rss_hf_refine(rss_type);\n \n+\t\t\t/**\n+\t\t\t * Check if SRC/DST_ONLY is set for SYMMETRIC_TOEPLITZ\n+\t\t\t * hash function.\n+\t\t\t */\n+\t\t\tif (rss->func ==\n+\t\t\t RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) {\n+\t\t\t\tif (rss_type & ((VALID_RSS_ATTR &\n+\t\t\t\t ~RTE_ETH_RSS_L3_PRE64) |\n+\t\t\t\t ~(VALID_RSS_IPV4 | VALID_RSS_IPV6)))\n+\t\t\t\t\treturn rte_flow_error_set(error,\n+\t\t\t\t\t\tENOTSUP,\n+\t\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t\taction,\n+\t\t\t\t\t\t\"invalid rss types\");\n+\t\t\t}\n+\n \t\t\tif (iavf_any_invalid_rss_type(rss_type,\n \t\t\t\t\tmatch_item->input_set_mask))\n \t\t\t\treturn rte_flow_error_set(error, ENOTSUP,\n", "prefixes": [] }