Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82721/?format=api
{ "id": 82721, "url": "http://patches.dpdk.org/api/patches/82721/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201029092751.3837177-10-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201029092751.3837177-10-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20201029092751.3837177-10-thomas@monjalon.net", "date": "2020-10-29T09:27:44", "name": "[09/15] net/nfb: switch timestamp to dynamic mbuf field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4cc7ec2c5f17b460fb629b0fa22f70e8208cd329", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201029092751.3837177-10-thomas@monjalon.net/mbox/", "series": [ { "id": 13454, "url": "http://patches.dpdk.org/api/series/13454/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13454", "date": "2020-10-29T09:27:35", "name": "remove mbuf timestamp", "version": 1, "mbox": "http://patches.dpdk.org/series/13454/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82721/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/82721/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA75BA04DD;\n\tThu, 29 Oct 2020 10:31:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3DB2FC942;\n\tThu, 29 Oct 2020 10:28:28 +0100 (CET)", "from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com\n [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 3533FC904\n for <dev@dpdk.org>; Thu, 29 Oct 2020 10:28:21 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id DF8E09EF;\n Thu, 29 Oct 2020 05:28:19 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute2.internal (MEProxy); Thu, 29 Oct 2020 05:28:20 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 46EED328005A;\n Thu, 29 Oct 2020 05:28:18 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=gBQ3EENVoHp7n\n Z+5f/s4THoJvHHh3lJew6ghBdkyeM8=; b=vaGLA6ILk0V75KYc33KSC2r/Q/MAE\n wV10SCK6qG9ftOq8n1+TmQWAea79f0qiL/VYh8oeEwmgr2mrDCh9eI1CotO7M/dL\n 28hp7WsNbKRDTklaCZNyFqwUuOjaBc1HXydOBySdsp5iLS+9xgPQLBC6klf+z5ny\n 93KBJxI4oeCUN2w72UzF9iLE++8Z962P6wEIf2tW4M4G4kdxB7Gbp1JqA3ASJKTl\n 7Q7dpcDEwi0zH7uS5rgP0YIvBJoXUySQcvAFxJUrOJIj/aq/YL7uvU6SaE4u8G9r\n nYbxEca3tDh3gdAbhvCd5tJl6DgZriqv5IZkoRKP9PN0940MbtpMh9rcw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=gBQ3EENVoHp7nZ+5f/s4THoJvHHh3lJew6ghBdkyeM8=; b=OdNQOcLK\n sq9MTc4lgmt7TMNqJEER2J38oMbeoKmonZ3XRxmN0PkRFc8zYbhkQMxLq/DhHlPO\n 7/CSSJEqHE/fkjPsWhrjQx842JtADJUbNBYH06LfZxyXBTsI4+HDpcCJ3dHpvt0c\n 6zNJ4WL5p5GRTZycCdMBfBMbS/pKlLiiIKPg3O2AVvdvQpBQvD0xpH1W7yEczCCC\n TnZ3xuVFkBOfZPTqBVfXCR137VJhq0ABP/1b9rZzRT97uiwB3djRuhAPtG+WclSP\n uEBpJ7x4DRLD4IG43PRs7toTT2hRd3Ux6cTiF3v8KD/XVUXgj0/rboeM+C1cOH8d\n VVH1Hl6VkIwKSA==" ], "X-ME-Sender": "<xms:M4uaX6Hn6X73yid63bpi5YSRDDfVtl0YDDSpP2eDmzrK5On2BfILSA>\n <xme:M4uaX7VhFJ4-8O_IhUH80pumxMF7dk81lwXtLA0E1cOEQO3fVWrR1XKetbzl2RksV\n AlS9Oo1Xq4wQdvQIQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedujedrleefgddthecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs\n ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf\n frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu\n tdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih\n iivgepkeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho\n nhdrnhgvth", "X-ME-Proxy": "<xmx:M4uaX0KQsp4_iceYbhT74mwYVz1tK1_SB8kYqJQjt-RwnZ3dglz2Tw>\n <xmx:M4uaX0EkXn0hwOH47VRxjEhhAKlqpPKEP670GEFByeoTdNUSus0tPQ>\n <xmx:M4uaXwWa1_s-_x_NZhonzu8v6Btal81zcEMrGwB49C1WVc2Rmk19Og>\n <xmx:M4uaXyJ3lA2MmycFMweR0AlcZ4Ox_8xzIwuwyGBwU1b6b1bMVKXfTw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, david.marchand@redhat.com,\n bruce.richardson@intel.com, olivier.matz@6wind.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com, viacheslavo@nvidia.com,\n Martin Spinler <spinler@cesnet.cz>", "Date": "Thu, 29 Oct 2020 10:27:44 +0100", "Message-Id": "<20201029092751.3837177-10-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201029092751.3837177-1-thomas@monjalon.net>", "References": "<20201029092751.3837177-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 09/15] net/nfb: switch timestamp to dynamic mbuf\n\tfield", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mbuf timestamp is moved to a dynamic field\nin order to allow removal of the deprecated static field.\nThe related mbuf flag is also replaced.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/nfb/nfb_rx.c | 23 ++++++++++++++++++++++-\n drivers/net/nfb/nfb_rx.h | 18 ++++++++++++++----\n 2 files changed, 36 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/nfb/nfb_rx.c b/drivers/net/nfb/nfb_rx.c\nindex d97179f818..1f90357522 100644\n--- a/drivers/net/nfb/nfb_rx.c\n+++ b/drivers/net/nfb/nfb_rx.c\n@@ -5,10 +5,14 @@\n */\n \n #include <rte_kvargs.h>\n+#include <rte_bitops.h>\n \n #include \"nfb_rx.h\"\n #include \"nfb.h\"\n \n+uint64_t nfb_timestamp_rx_dynflag;\n+int nfb_timestamp_dynfield_offset = -1;\n+\n static int\n timestamp_check_handler(__rte_unused const char *key,\n \tconst char *value, __rte_unused void *opaque)\n@@ -23,6 +27,7 @@ timestamp_check_handler(__rte_unused const char *key,\n static int\n nfb_check_timestamp(struct rte_devargs *devargs)\n {\n+\tint timestamp_rx_dynflag_offset;\n \tstruct rte_kvargs *kvlist;\n \n \tif (devargs == NULL)\n@@ -38,6 +43,7 @@ nfb_check_timestamp(struct rte_devargs *devargs)\n \t}\n \t/* Timestamps are enabled when there is\n \t * key-value pair: enable_timestamp=1\n+\t * TODO: timestamp should be enabled with DEV_RX_OFFLOAD_TIMESTAMP\n \t */\n \tif (rte_kvargs_process(kvlist, TIMESTAMP_ARG,\n \t\ttimestamp_check_handler, NULL) < 0) {\n@@ -46,6 +52,21 @@ nfb_check_timestamp(struct rte_devargs *devargs)\n \t}\n \trte_kvargs_free(kvlist);\n \n+\tnfb_timestamp_dynfield_offset = rte_mbuf_dynfield_lookup(\n+\t\t\tRTE_MBUF_DYNFIELD_TIMESTAMP_NAME, NULL);\n+\tif (nfb_timestamp_dynfield_offset < 0) {\n+\t\tRTE_LOG(ERR, PMD, \"Cannot lookup timestamp field\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\ttimestamp_rx_dynflag_offset = rte_mbuf_dynflag_lookup(\n+\t\t\tRTE_MBUF_DYNFLAG_RX_TIMESTAMP_NAME, NULL);\n+\tif (timestamp_rx_dynflag_offset < 0) {\n+\t\tRTE_LOG(ERR, PMD, \"Cannot lookup Rx timestamp flag\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\tnfb_timestamp_rx_dynflag =\n+\t\tRTE_BIT64(timestamp_rx_dynflag_offset);\n+\n \treturn 1;\n }\n \n@@ -125,7 +146,7 @@ nfb_eth_rx_queue_setup(struct rte_eth_dev *dev,\n \telse\n \t\trte_free(rxq);\n \n-\tif (nfb_check_timestamp(dev->device->devargs))\n+\tif (nfb_check_timestamp(dev->device->devargs) > 0)\n \t\trxq->flags |= NFB_TIMESTAMP_FLAG;\n \n \treturn ret;\ndiff --git a/drivers/net/nfb/nfb_rx.h b/drivers/net/nfb/nfb_rx.h\nindex cf3899b2fb..e548226e0f 100644\n--- a/drivers/net/nfb/nfb_rx.h\n+++ b/drivers/net/nfb/nfb_rx.h\n@@ -15,6 +15,16 @@\n \n #define NFB_TIMESTAMP_FLAG (1 << 0)\n \n+extern uint64_t nfb_timestamp_rx_dynflag;\n+extern int nfb_timestamp_dynfield_offset;\n+\n+static inline rte_mbuf_timestamp_t *\n+nfb_timestamp_dynfield(struct rte_mbuf *mbuf)\n+{\n+\treturn RTE_MBUF_DYNFIELD(mbuf,\n+\t\tnfb_timestamp_dynfield_offset, rte_mbuf_timestamp_t *);\n+}\n+\n struct ndp_rx_queue {\n \tstruct nfb_device *nfb;\t /* nfb dev structure */\n \tstruct ndp_queue *queue; /* rx queue */\n@@ -191,15 +201,15 @@ nfb_eth_ndp_rx(void *queue,\n \n \t\t\tif (timestamping_enabled) {\n \t\t\t\t/* nanoseconds */\n-\t\t\t\tmbuf->timestamp =\n+\t\t\t\t*nfb_timestamp_dynfield(mbuf) =\n \t\t\t\t\trte_le_to_cpu_32(*((uint32_t *)\n \t\t\t\t\t(packets[i].header + 4)));\n-\t\t\t\tmbuf->timestamp <<= 32;\n+\t\t\t\t*nfb_timestamp_dynfield(mbuf) <<= 32;\n \t\t\t\t/* seconds */\n-\t\t\t\tmbuf->timestamp |=\n+\t\t\t\t*nfb_timestamp_dynfield(mbuf) |=\n \t\t\t\t\trte_le_to_cpu_32(*((uint32_t *)\n \t\t\t\t\t(packets[i].header + 8)));\n-\t\t\t\tmbuf->ol_flags |= PKT_RX_TIMESTAMP;\n+\t\t\t\tmbuf->ol_flags |= nfb_timestamp_rx_dynflag;\n \t\t\t}\n \n \t\t\tbufs[num_rx++] = mbuf;\n", "prefixes": [ "09/15" ] }