Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82601/?format=api
{ "id": 82601, "url": "http://patches.dpdk.org/api/patches/82601/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1603877633-293405-28-git-send-email-suanmingm@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1603877633-293405-28-git-send-email-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1603877633-293405-28-git-send-email-suanmingm@nvidia.com", "date": "2020-10-28T09:33:46", "name": "[v5,27/34] net/mlx5: simplify sample attributes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b17ca3f6da1724d90bb326db599231305fbe2f96", "submitter": { "id": 1887, "url": "http://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1603877633-293405-28-git-send-email-suanmingm@nvidia.com/mbox/", "series": [ { "id": 13413, "url": "http://patches.dpdk.org/api/series/13413/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13413", "date": "2020-10-28T09:33:20", "name": "[v5,01/34] net/mlx5: use thread safe index pool for flow objects", "version": 5, "mbox": "http://patches.dpdk.org/series/13413/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82601/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/82601/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0A454A04DD;\n\tWed, 28 Oct 2020 10:43:04 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0EA22C9EA;\n\tWed, 28 Oct 2020 10:37:30 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 2CDB2C9A0\n for <dev@dpdk.org>; Wed, 28 Oct 2020 10:35:04 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n suanmingm@nvidia.com) with SMTP; 28 Oct 2020 11:34:57 +0200", "from nvidia.com (mtbc-r640-04.mtbc.labs.mlnx [10.75.70.9])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 09S9Y0S9014036;\n Wed, 28 Oct 2020 11:34:56 +0200" ], "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Cc": "dev@dpdk.org, rasland@nvidia.com", "Date": "Wed, 28 Oct 2020 17:33:46 +0800", "Message-Id": "<1603877633-293405-28-git-send-email-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1603877633-293405-1-git-send-email-suanmingm@nvidia.com>", "References": "<1601984948-313027-1-git-send-email-suanmingm@nvidia.com>\n <1603877633-293405-1-git-send-email-suanmingm@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v5 27/34] net/mlx5: simplify sample attributes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the sample action resource already has ft_type to indicate\nthe action domain attribute, the extra flow attributes parameter can\nbe optimized.\n\nThis commit uses action resource ty_type as domain attribute instead of\nthe flow attribute.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 29 ++++++++++++++---------------\n 1 file changed, 14 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex d6414eb..fbe114c 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -8605,8 +8605,6 @@ struct mlx5_hlist_entry *\n *\n * @param[in, out] dev\n * Pointer to rte_eth_dev structure.\n- * @param[in] attr\n- * Attributes of flow that includes this item.\n * @param[in] resource\n * Pointer to sample resource.\n * @parm[in, out] dev_flow\n@@ -8621,7 +8619,6 @@ struct mlx5_hlist_entry *\n */\n static int\n flow_dv_sample_resource_register(struct rte_eth_dev *dev,\n-\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct mlx5_flow_dv_sample_resource *resource,\n \t\t\t struct mlx5_flow *dev_flow,\n \t\t\t void **sample_dv_actions,\n@@ -8635,6 +8632,8 @@ struct mlx5_hlist_entry *\n \tuint32_t idx = 0;\n \tconst uint32_t next_ft_step = 1;\n \tuint32_t next_ft_id = resource->ft_id +\tnext_ft_step;\n+\tuint8_t is_egress = 0;\n+\tuint8_t is_transfer = 0;\n \n \t/* Lookup a matching resource from cache. */\n \tILIST_FOREACH(sh->ipool[MLX5_IPOOL_SAMPLE], sh->sample_action_list,\n@@ -8667,8 +8666,12 @@ struct mlx5_hlist_entry *\n \t\t\t\t\t \"cannot allocate resource memory\");\n \t*cache_resource = *resource;\n \t/* Create normal path table level */\n+\tif (resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_FDB)\n+\t\tis_transfer = 1;\n+\telse if (resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_NIC_TX)\n+\t\tis_egress = 1;\n \ttbl = flow_dv_tbl_resource_get(dev, next_ft_id,\n-\t\t\t\t\tattr->egress, attr->transfer,\n+\t\t\t\t\tis_egress, is_transfer,\n \t\t\t\t\tdev_flow->external, NULL, 0, 0, error);\n \tif (!tbl) {\n \t\trte_flow_error_set(error, ENOMEM,\n@@ -8751,8 +8754,6 @@ struct mlx5_hlist_entry *\n *\n * @param[in, out] dev\n * Pointer to rte_eth_dev structure.\n- * @param[in] attr\n- * Attributes of flow that includes this item.\n * @param[in] resource\n * Pointer to destination array resource.\n * @parm[in, out] dev_flow\n@@ -8765,7 +8766,6 @@ struct mlx5_hlist_entry *\n */\n static int\n flow_dv_dest_array_resource_register(struct rte_eth_dev *dev,\n-\t\t\t const struct rte_flow_attr *attr,\n \t\t\t struct mlx5_flow_dv_dest_array_resource *resource,\n \t\t\t struct mlx5_flow *dev_flow,\n \t\t\t struct rte_flow_error *error)\n@@ -8809,9 +8809,9 @@ struct mlx5_hlist_entry *\n \t\t\t\t\t NULL,\n \t\t\t\t\t \"cannot allocate resource memory\");\n \t*cache_resource = *resource;\n-\tif (attr->transfer)\n+\tif (resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_FDB)\n \t\tdomain = sh->fdb_domain;\n-\telse if (attr->ingress)\n+\telse if (resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_NIC_RX)\n \t\tdomain = sh->rx_domain;\n \telse\n \t\tdomain = sh->tx_domain;\n@@ -9100,6 +9100,8 @@ struct mlx5_hlist_entry *\n \t\tres->set_action = action_ctx.set_action;\n \t} else if (attr->ingress) {\n \t\tres->ft_type = MLX5DV_FLOW_TABLE_TYPE_NIC_RX;\n+\t} else {\n+\t\tres->ft_type = MLX5DV_FLOW_TABLE_TYPE_NIC_TX;\n \t}\n \treturn 0;\n }\n@@ -9111,8 +9113,6 @@ struct mlx5_hlist_entry *\n * Pointer to rte_eth_dev structure.\n * @param[in, out] dev_flow\n * Pointer to the mlx5_flow.\n- * @param[in] attr\n- * Pointer to the flow attributes.\n * @param[in] num_of_dest\n * The num of destination.\n * @param[in, out] res\n@@ -9132,7 +9132,6 @@ struct mlx5_hlist_entry *\n static int\n flow_dv_create_action_sample(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_flow *dev_flow,\n-\t\t\t const struct rte_flow_attr *attr,\n \t\t\t uint32_t num_of_dest,\n \t\t\t struct mlx5_flow_dv_sample_resource *res,\n \t\t\t struct mlx5_flow_dv_dest_array_resource *mdest_res,\n@@ -9192,14 +9191,14 @@ struct mlx5_hlist_entry *\n \t\tmemcpy(&mdest_res->sample_act[0], &res->sample_act,\n \t\t\t\tsizeof(struct mlx5_flow_sub_actions_list));\n \t\tmdest_res->num_of_dest = num_of_dest;\n-\t\tif (flow_dv_dest_array_resource_register(dev, attr, mdest_res,\n+\t\tif (flow_dv_dest_array_resource_register(dev, mdest_res,\n \t\t\t\t\t\t\t dev_flow, error))\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t\t\t NULL, \"can't create sample \"\n \t\t\t\t\t\t \"action\");\n \t} else {\n-\t\tif (flow_dv_sample_resource_register(dev, attr, res, dev_flow,\n+\t\tif (flow_dv_sample_resource_register(dev, res, dev_flow,\n \t\t\t\t\t\t sample_actions, error))\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n@@ -9839,7 +9838,7 @@ struct mlx5_hlist_entry *\n \t\t\t}\n \t\t\tif (action_flags & MLX5_FLOW_ACTION_SAMPLE) {\n \t\t\t\tret = flow_dv_create_action_sample(dev,\n-\t\t\t\t\t\t\t dev_flow, attr,\n+\t\t\t\t\t\t\t dev_flow,\n \t\t\t\t\t\t\t num_of_dest,\n \t\t\t\t\t\t\t &sample_res,\n \t\t\t\t\t\t\t &mdest_res,\n", "prefixes": [ "v5", "27/34" ] }