Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/82388/?format=api
{ "id": 82388, "url": "http://patches.dpdk.org/api/patches/82388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201027221343.28551-9-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201027221343.28551-9-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201027221343.28551-9-david.marchand@redhat.com", "date": "2020-10-27T22:13:43", "name": "[8/8] mbuf: remove seqn field", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "70db37ba0b2ac08ddb8ab2bd63d936f433c002f6", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201027221343.28551-9-david.marchand@redhat.com/mbox/", "series": [ { "id": 13394, "url": "http://patches.dpdk.org/api/series/13394/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=13394", "date": "2020-10-27T22:13:35", "name": "remove mbuf seqn", "version": 1, "mbox": "http://patches.dpdk.org/series/13394/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/82388/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/82388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B10B1A04B5;\n\tTue, 27 Oct 2020 23:16:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3076A3257;\n\tTue, 27 Oct 2020 23:14:19 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by dpdk.org (Postfix) with ESMTP id 9077C378B\n for <dev@dpdk.org>; Tue, 27 Oct 2020 23:14:12 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-347-P1gyTgMbMHSR22nl0gvzgA-1; Tue, 27 Oct 2020 18:14:09 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com\n [10.5.11.16])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2AA8EC504;\n Tue, 27 Oct 2020 22:14:07 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.192.40])\n by smtp.corp.redhat.com (Postfix) with ESMTP id BA61A5C1BB;\n Tue, 27 Oct 2020 22:14:06 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1603836851;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DBnlScejIvByuSDnuJF5EFPMp8dL2s7aO3/g/+IK9yA=;\n b=M0QJFmufXZdO0I8NRrArBvdEjh0iCYkr2FkLIQHGDed8dwo7stXqwTocU/2OxudsGJ6M3E\n KT5QMdf2DnMF4F79rHsCgLWtAaF6DkIvaRQ864IHm8aW8yp/hUdL0h0238BvRTNmS2ZxuU\n g8330FLGT/jImffcw9ILSi1y8n216TU=", "X-MC-Unique": "P1gyTgMbMHSR22nl0gvzgA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,\n Olivier Matz <olivier.matz@6wind.com>", "Date": "Tue, 27 Oct 2020 23:13:43 +0100", "Message-Id": "<20201027221343.28551-9-david.marchand@redhat.com>", "In-Reply-To": "<20201027221343.28551-1-david.marchand@redhat.com>", "References": "<20201027221343.28551-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 8/8] mbuf: remove seqn field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As announced in the deprecation note, the field seqn is removed to give\nmore space to the dynamic fields.\n\nThis is how the mbuf layout looks like (pahole-style):\n\nword type name byte size\n 0 void * buf_addr; /* 0 + 8 */\n 1 rte_iova_t buf_iova /* 8 + 8 */\n /* --- RTE_MARKER64 rearm_data; */\n 2 uint16_t data_off; /* 16 + 2 */\n uint16_t refcnt; /* 18 + 2 */\n uint16_t nb_segs; /* 20 + 2 */\n uint16_t port; /* 22 + 2 */\n 3 uint64_t ol_flags; /* 24 + 8 */\n /* --- RTE_MARKER rx_descriptor_fields1; */\n 4 uint32_t union packet_type; /* 32 + 4 */\n uint32_t pkt_len; /* 36 + 4 */\n 5 uint16_t data_len; /* 40 + 2 */\n uint16_t vlan_tci; /* 42 + 2 */\n 5.5 uint64_t union hash; /* 44 + 8 */\n 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */\n uint16_t buf_len; /* 54 + 2 */\n 7 uint64_t timestamp; /* 56 + 8 */\n /* --- RTE_MARKER cacheline1; */\n 8 struct rte_mempool * pool; /* 64 + 8 */\n 9 struct rte_mbuf * next; /* 72 + 8 */\n10 uint64_t union tx_offload; /* 80 + 8 */\n11 struct rte_mbuf_ext_shared_info * shinfo; /* 88 + 8 */\n12 uint16_t priv_size; /* 96 + 2 */\n uint16_t timesync; /* 98 + 2 */\n12.5 uint32_t dynfield1[7]; /* 100 + 28 */\n16 /* --- END 128 */\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/rel_notes/deprecation.rst | 1 -\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n lib/librte_mbuf/rte_mbuf_core.h | 15 ++++++---------\n 3 files changed, 9 insertions(+), 10 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 0f6f1df12a..fe3fd3956c 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -87,7 +87,6 @@ Deprecation Notices\n The following static fields will be moved as dynamic:\n \n - ``timestamp``\n- - ``seqn``\n \n As a consequence, the layout of the ``struct rte_mbuf`` will be re-arranged,\n avoiding impact on vectorized implementation of the driver datapaths,\ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex 3d7edbfdbb..c0a9fc96aa 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -429,6 +429,9 @@ API Changes\n * mbuf: Removed the unioned fields ``userdata`` and ``udata64``\n from the structure ``rte_mbuf``. It is replaced with dynamic fields.\n \n+* mbuf: Removed the field ``seqn`` from the structure ``rte_mbuf``.\n+ It is replaced with dynamic fields.\n+\n * pci: Removed the ``rte_kernel_driver`` enum defined in rte_dev.h and\n replaced with a private enum in the PCI subsystem.\n \ndiff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h\nindex a65eaaf692..3fb5abda3c 100644\n--- a/lib/librte_mbuf/rte_mbuf_core.h\n+++ b/lib/librte_mbuf/rte_mbuf_core.h\n@@ -640,6 +640,11 @@ struct rte_mbuf {\n \t\t};\n \t};\n \n+\t/** Shared data for external buffer attached to mbuf. See\n+\t * rte_pktmbuf_attach_extbuf().\n+\t */\n+\tstruct rte_mbuf_ext_shared_info *shinfo;\n+\n \t/** Size of the application private data. In case of an indirect\n \t * mbuf, it stores the direct mbuf private data size.\n \t */\n@@ -648,15 +653,7 @@ struct rte_mbuf {\n \t/** Timesync flags for use with IEEE1588. */\n \tuint16_t timesync;\n \n-\t/** Sequence number. See also rte_reorder_insert(). */\n-\tuint32_t seqn;\n-\n-\t/** Shared data for external buffer attached to mbuf. See\n-\t * rte_pktmbuf_attach_extbuf().\n-\t */\n-\tstruct rte_mbuf_ext_shared_info *shinfo;\n-\n-\tuint64_t dynfield1[3]; /**< Reserved for dynamic fields. */\n+\tuint32_t dynfield1[7]; /**< Reserved for dynamic fields. */\n } __rte_cache_aligned;\n \n /**\n", "prefixes": [ "8/8" ] }